* [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
@ 2016-12-15 15:27 Corentin Labbe
2016-12-15 16:20 ` Srinivas Pandruvada
2016-12-19 10:17 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Corentin Labbe @ 2016-12-15 15:27 UTC (permalink / raw)
To: srinivas.pandruvada, jikos, benjamin.tissoires, linux-input
Cc: linux-kernel, Corentin Labbe
hid/intel-ish-hid does not use any miscdevice so this patch remove
this unnecessary inclusion.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
drivers/hid/intel-ish-hid/ishtp/hbm.c | 1 -
drivers/hid/intel-ish-hid/ishtp/init.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index 20d647d..d20da39 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -24,7 +24,6 @@
#include <linux/sched.h>
#include <linux/interrupt.h>
#include <linux/workqueue.h>
-#include <linux/miscdevice.h>
#define CREATE_TRACE_POINTS
#include <trace/events/intel_ish.h>
#include "ishtp-dev.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c
index 59460b6..b721360 100644
--- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
+++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
@@ -19,7 +19,6 @@
#include <linux/sched.h>
#include <linux/wait.h>
#include <linux/spinlock.h>
-#include <linux/miscdevice.h>
#include "ishtp-dev.h"
#include "hbm.h"
#include "client.h"
diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c b/drivers/hid/intel-ish-hid/ishtp/init.c
index ac36441..d27e035 100644
--- a/drivers/hid/intel-ish-hid/ishtp/init.c
+++ b/drivers/hid/intel-ish-hid/ishtp/init.c
@@ -16,7 +16,6 @@
#include <linux/export.h>
#include <linux/slab.h>
#include <linux/sched.h>
-#include <linux/miscdevice.h>
#include "ishtp-dev.h"
#include "hbm.h"
#include "client.h"
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
2016-12-15 15:27 [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include Corentin Labbe
@ 2016-12-15 16:20 ` Srinivas Pandruvada
2016-12-19 10:17 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Pandruvada @ 2016-12-15 16:20 UTC (permalink / raw)
To: Corentin Labbe, jikos, benjamin.tissoires, linux-input; +Cc: linux-kernel
On Thu, 2016-12-15 at 16:27 +0100, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 1 -
> drivers/hid/intel-ish-hid/ishtp/init.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 20d647d..d20da39 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -24,7 +24,6 @@
> #include <linux/sched.h>
> #include <linux/interrupt.h>
> #include <linux/workqueue.h>
> -#include <linux/miscdevice.h>
> #define CREATE_TRACE_POINTS
> #include <trace/events/intel_ish.h>
> #include "ishtp-dev.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> index 59460b6..b721360 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> @@ -19,7 +19,6 @@
> #include <linux/sched.h>
> #include <linux/wait.h>
> #include <linux/spinlock.h>
> -#include <linux/miscdevice.h>
> #include "ishtp-dev.h"
> #include "hbm.h"
> #include "client.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c
> b/drivers/hid/intel-ish-hid/ishtp/init.c
> index ac36441..d27e035 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/init.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/init.c
> @@ -16,7 +16,6 @@
> #include <linux/export.h>
> #include <linux/slab.h>
> #include <linux/sched.h>
> -#include <linux/miscdevice.h>
> #include "ishtp-dev.h"
> #include "hbm.h"
> #include "client.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
2016-12-15 15:27 [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include Corentin Labbe
2016-12-15 16:20 ` Srinivas Pandruvada
@ 2016-12-19 10:17 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2016-12-19 10:17 UTC (permalink / raw)
To: Corentin Labbe
Cc: srinivas.pandruvada, benjamin.tissoires, linux-input, linux-kernel
On Thu, 15 Dec 2016, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-19 10:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-15 15:27 [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include Corentin Labbe
2016-12-15 16:20 ` Srinivas Pandruvada
2016-12-19 10:17 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).