From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: jeyu@redhat.com, jikos@kernel.org, pmladek@suse.com,
corbet@lwn.net, live-patching@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/livepatch: remove the limitation for schedule() patching
Date: Tue, 10 Jan 2017 11:32:12 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.20.1701101131510.28763@pobox.suse.cz> (raw)
In-Reply-To: <20170109145433.xiopfww5q37ndzdz@treble>
On Mon, 9 Jan 2017, Josh Poimboeuf wrote:
> On Mon, Jan 09, 2017 at 01:50:19PM +0100, Miroslav Benes wrote:
> > There is still one thing which I don't understand. Why __schedule()
> > (patched or the original) is not on the stack. The actual "sleep"
> > should happen in __switch_to_asm() which is C function now. And there is a
> > call to __switch_to_asm() in __schedule(). __schedule() thus should be on
> > the stack, shouldn't it? What am I missing? __switch_to_asm() pushes %rbp
> > on the stack...
>
> Ah, this is an unwinder bug. get_frame_pointer() needs to be fixed so
> that for an inactive task it returns a pointer to inactive_task_frame.bp
> rather than the value of inactive_task_frame.bp itself. Will fix it.
And it works with the fix. Thanks.
Miroslav
next prev parent reply other threads:[~2017-01-10 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 14:00 [PATCH] Documentation/livepatch: remove the limitation for schedule() patching Miroslav Benes
2017-01-06 15:01 ` Petr Mladek
2017-01-06 15:10 ` Miroslav Benes
2017-01-06 19:13 ` Josh Poimboeuf
2017-01-09 12:50 ` Miroslav Benes
2017-01-09 14:54 ` Josh Poimboeuf
2017-01-10 10:32 ` Miroslav Benes [this message]
2017-01-11 1:33 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1701101131510.28763@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=corbet@lwn.net \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).