From: Jiri Kosina <jikos@kernel.org>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: magicmouse: Set multi-touch keybits for Magic Mouse
Date: Fri, 5 May 2017 15:32:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1705051531550.26873@cbobk.fhfr.pm> (raw)
In-Reply-To: <1491552756-9933-1-git-send-email-thierry.escande@collabora.com>
On Fri, 7 Apr 2017, Thierry Escande wrote:
> From: Che-Liang Chiou <clchiou@chromium.org>
>
> The driver emits multi-touch events for Magic Trackpad as well as Magic
> Mouse, but it does not set keybits that are related to multi-touch event
> for Magic Mouse; so set these keybits.
>
> The keybits that are not set cause trouble because user programs often
> probe these keybits for self-configuration and thus they cannot operate
> properly if the keybits are not set.
>
> One of such troubles is that libevdev will not be able to emit correct
> touch count, causing gestures library failed to do fling stop.
>
> Signed-off-by: Che-Liang Chiou <clchiou@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Applied to for-4.12/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2017-05-05 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 8:12 [PATCH] HID: magicmouse: Set multi-touch keybits for Magic Mouse Thierry Escande
2017-05-05 13:32 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1705051531550.26873@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).