From: Miroslav Benes <mbenes@suse.cz>
To: Petr Mladek <pmladek@suse.com>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Jessica Yu <jeyu@redhat.com>, Jiri Kosina <jikos@kernel.org>
Subject: Re: [PATCH v2 1/2] livepatch: introduce shadow variable API
Date: Wed, 19 Jul 2017 20:50:14 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.20.1707192048460.15946@pobox.suse.cz> (raw)
In-Reply-To: <20170719151951.GL32632@pathway.suse.cz>
On Wed, 19 Jul 2017, Petr Mladek wrote:
> On Tue 2017-07-18 15:36:27, Joe Lawrence wrote:
> > Who knew naming things was so difficult :)
> >
> > There's been a bunch of feedback on terminology, so I'll just issue a
> > collective reply to Petr's last msg on the topic. These were my
> > thoughts on naming clarification:
> >
> > v1,v2 v3
> > --------------------------------------------------------------
> > obj, original data obj, parent object
> > num, numerical description of new data id, data identifier
> > new_data data
> > new_size data_size
>
> IMHO, "size" might be enough in the context when it is used.
I agree.
> >
> > Miroslav also suggested additional text explaining the id / data
> > identifier field. How about something like this:
> >
> > ---
> >
> > ================
> > Shadow Variables
> > ================
> >
> > ...
> >
> > A global, in-kernel hashtable associates parent pointers and a numeric
> > identifier with shadow variable data.
>
> I would slightly reformulate the above sentece:
>
> A global, in-kernel hashtable associates pointers to parent objects
> and a numeric identifier of the shadow data.
>
> > Specifically, the parent pointer
> > serves as the hashtable key, while the numeric id further filters
> > hashtable queries. The numeric identifier is a simple enumeration that
> > may be used to describe shadow variable versions (for stacking
> > livepatches), class or type (for multiple shadow variables per parent),
> > etc. Multiple shadow variables may attach to the same parent object,
> > but their numeric identifier distinguises between them.
s/distinguises/distinguishes/
> Sounds good to me.
Yes, thanks for the paragraph. It sounds good combined with Petr's
proposal.
Miroslav
next prev parent reply other threads:[~2017-07-19 18:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 15:37 [PATCH v2 0/2] livepatch: add shadow variable API Joe Lawrence
2017-06-28 15:37 ` [PATCH v2 1/2] livepatch: introduce " Joe Lawrence
2017-06-30 13:49 ` kbuild test robot
2017-07-07 18:05 ` Joe Lawrence
2017-07-14 0:41 ` Josh Poimboeuf
2017-07-17 15:35 ` Miroslav Benes
2017-07-18 13:00 ` Petr Mladek
2017-07-18 19:36 ` Joe Lawrence
2017-07-19 15:19 ` Petr Mladek
2017-07-19 18:50 ` Miroslav Benes [this message]
2017-07-17 15:29 ` Miroslav Benes
2017-07-18 20:21 ` Joe Lawrence
2017-07-19 2:28 ` Josh Poimboeuf
2017-07-19 19:01 ` Miroslav Benes
2017-07-20 14:45 ` Miroslav Benes
2017-07-20 15:48 ` Joe Lawrence
2017-07-20 20:23 ` Josh Poimboeuf
2017-07-21 8:42 ` Petr Mladek
2017-07-21 8:59 ` Miroslav Benes
2017-07-18 12:45 ` Petr Mladek
2017-07-20 20:30 ` Joe Lawrence
2017-07-21 9:12 ` Miroslav Benes
2017-07-21 9:27 ` Petr Mladek
2017-07-21 9:13 ` Petr Mladek
2017-07-21 13:55 ` Joe Lawrence
2017-07-24 15:04 ` Josh Poimboeuf
2017-06-28 15:37 ` [PATCH v2 2/2] livepatch: add shadow variable sample programs Joe Lawrence
2017-07-18 14:47 ` Petr Mladek
2017-07-18 19:15 ` Joe Lawrence
2017-07-19 14:44 ` Petr Mladek
2017-07-19 15:06 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.1707192048460.15946@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).