From: Finn Thain <fthain@telegraphics.com.au>
To: David Miller <davem@davemloft.net>
Cc: joe@perches.com, geert@linux-m68k.org, p_gortmaker@yahoo.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH] mac8390: change an error return code and some cleanup, take 4
Date: Tue, 1 Jun 2010 01:19:06 +1000 (EST) [thread overview]
Message-ID: <alpine.OSX.2.00.1006010115030.1536@localhost> (raw)
In-Reply-To: <20100531.081412.27799681.davem@davemloft.net>
On Mon, 31 May 2010, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 31 May 2010 08:08:13 -0700
>
> > There are many uses of KERN_DEBUG that are reasonable to have always
> > enabled.
>
> Doubtful.
>
> pr_debug() makes a ton of sense as currently implemented. It's for
> messages that we want both compile time and run-time control over.
>
> The case we have here in mac8390 seems like it should stay as pr_info().
> Because 1) it's already controlled by a run-time knob so controlling it
> even further is confusing and 2) the message is "informative", it lets
> the user know a feature cannot be enabled, thus pr_info().
If that is true in general, then ei_debug itself becomes questionable.
In the case of mac8390 at least, I'm certainly leaning toward changing the
pr_info (conditional on ei_debug) to pr_debug (unconditional).
Finn
next prev parent reply other threads:[~2010-05-31 15:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 2:34 another cleanup patch gone wrong Finn Thain
2010-04-16 3:01 ` David Miller
2010-04-16 3:45 ` [PATCH] mac8390: fix pr_info() calls, was " Finn Thain
2010-04-16 3:54 ` Joe Perches
2010-04-16 3:59 ` Finn Thain
2010-04-16 4:21 ` [PATCH] mac8390: fix pr_info() calls and change return code Finn Thain
2010-04-16 4:34 ` Joe Perches
2010-04-16 13:57 ` Finn Thain
2010-04-16 20:28 ` David Miller
2010-04-17 2:28 ` Finn Thain
2010-04-16 5:53 ` David Miller
2010-04-16 14:14 ` [PATCH] mac8390: change an error return code and some cleanup Finn Thain
2010-04-17 3:16 ` [PATCH] mac8390: change an error return code and some cleanup, take 3 Finn Thain
2010-04-21 23:30 ` David Miller
2010-04-22 1:13 ` Finn Thain
2010-05-28 17:29 ` [PATCH] mac8390: change an error return code and some cleanup, take 4 Finn Thain
2010-05-31 7:19 ` David Miller
2010-05-31 9:21 ` fthain
2010-05-31 9:58 ` Geert Uytterhoeven
2010-05-31 11:07 ` fthain
2010-05-31 11:30 ` David Miller
2010-05-31 12:55 ` Finn Thain
2010-05-31 13:02 ` David Miller
2010-06-01 12:18 ` [PATCH 1/2] mac8390: propagate error code from request_irq Finn Thain
2010-06-02 12:17 ` David Miller
2010-06-01 12:18 ` [PATCH 2/2] mac8390: raise error logging priority Finn Thain
2010-06-02 14:06 ` David Miller
2010-06-02 15:36 ` Finn Thain
2010-05-31 15:08 ` [PATCH] mac8390: change an error return code and some cleanup, take 4 Joe Perches
2010-05-31 15:14 ` David Miller
2010-05-31 15:19 ` Finn Thain [this message]
2010-05-31 11:27 ` David Miller
2010-04-16 3:11 ` another cleanup patch gone wrong Joe Perches
2010-04-16 3:21 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.1006010115030.1536@localhost \
--to=fthain@telegraphics.com.au \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).