* [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP
@ 2020-01-29 18:02 Geert Uytterhoeven
2020-01-29 21:08 ` Mat Martineau
2020-01-30 8:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-01-29 18:02 UTC (permalink / raw)
To: Paolo Abeni, Christoph Paasch, Mat Martineau, Matthieu Baerts,
David S . Miller, Jakub Kicinski
Cc: netdev, mptcp, linux-kernel, Geert Uytterhoeven
As the MPTCP HMAC test is integrated into the MPTCP code, it can be
built only when MPTCP is enabled. Hence when MPTCP is disabled, asking
the user if the test code should be enabled is futile.
Wrap the whole block of MPTCP-specific config options inside a check for
MPTCP. While at it, drop the "default n" for MPTCP_HMAC_TEST, as that
is the default anyway.
Fixes: 65492c5a6ab5df50 ("mptcp: move from sha1 (v0) to sha256 (v1)")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
net/mptcp/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig
index 5db56d2218c518c8..49f6054e7f4ebc15 100644
--- a/net/mptcp/Kconfig
+++ b/net/mptcp/Kconfig
@@ -10,17 +10,19 @@ config MPTCP
uses the TCP protocol, and TCP options carry header information for
MPTCP.
+if MPTCP
+
config MPTCP_IPV6
bool "MPTCP: IPv6 support for Multipath TCP"
- depends on MPTCP
select IPV6
default y
config MPTCP_HMAC_TEST
bool "Tests for MPTCP HMAC implementation"
- default n
help
This option enable boot time self-test for the HMAC implementation
used by the MPTCP code
Say N if you are unsure.
+
+endif
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP
2020-01-29 18:02 [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP Geert Uytterhoeven
@ 2020-01-29 21:08 ` Mat Martineau
2020-01-30 8:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Mat Martineau @ 2020-01-29 21:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Paolo Abeni, Christoph Paasch, Matthieu Baerts, David S . Miller,
Jakub Kicinski, netdev, mptcp, linux-kernel
On Wed, 29 Jan 2020, Geert Uytterhoeven wrote:
> As the MPTCP HMAC test is integrated into the MPTCP code, it can be
> built only when MPTCP is enabled. Hence when MPTCP is disabled, asking
> the user if the test code should be enabled is futile.
>
> Wrap the whole block of MPTCP-specific config options inside a check for
> MPTCP. While at it, drop the "default n" for MPTCP_HMAC_TEST, as that
> is the default anyway.
>
> Fixes: 65492c5a6ab5df50 ("mptcp: move from sha1 (v0) to sha256 (v1)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
--
Mat Martineau
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP
2020-01-29 18:02 [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP Geert Uytterhoeven
2020-01-29 21:08 ` Mat Martineau
@ 2020-01-30 8:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-01-30 8:56 UTC (permalink / raw)
To: geert
Cc: pabeni, cpaasch, mathew.j.martineau, matthieu.baerts, kuba,
netdev, mptcp, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 29 Jan 2020 19:02:24 +0100
> As the MPTCP HMAC test is integrated into the MPTCP code, it can be
> built only when MPTCP is enabled. Hence when MPTCP is disabled, asking
> the user if the test code should be enabled is futile.
>
> Wrap the whole block of MPTCP-specific config options inside a check for
> MPTCP. While at it, drop the "default n" for MPTCP_HMAC_TEST, as that
> is the default anyway.
>
> Fixes: 65492c5a6ab5df50 ("mptcp: move from sha1 (v0) to sha256 (v1)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-30 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 18:02 [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP Geert Uytterhoeven
2020-01-29 21:08 ` Mat Martineau
2020-01-30 8:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).