* [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682
@ 2020-01-02 13:52 Arnd Bergmann
2020-01-02 18:50 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-03 1:05 ` Applied "ASoC: Intel: boards: Fix compile-testing RT1011/RT5682" to the asoc tree Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-01-02 13:52 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown
Cc: Arnd Bergmann, Jaroslav Kysela, Takashi Iwai, Naveen Manohar,
Sathya Prakash M R, Kai Vehmanen, alsa-devel, linux-kernel
On non-x86, the new driver results in a build failure:
sound/soc/intel/boards/cml_rt1011_rt5682.c:14:10: fatal error: asm/cpu_device_id.h: No such file or directory
The asm/cpu_device_id.h header is not actually needed here,
so don't include it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I found this last week, but the patch still seems to be needed
as I could not find a fix in mainline or -next.
Please ignore if there is already a fix in some other tree.
sound/soc/intel/boards/cml_rt1011_rt5682.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
index a22f97234201..5f1bf6d3800c 100644
--- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
+++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
@@ -11,7 +11,6 @@
#include <linux/clk.h>
#include <linux/dmi.h>
#include <linux/slab.h>
-#include <asm/cpu_device_id.h>
#include <linux/acpi.h>
#include <sound/core.h>
#include <sound/jack.h>
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682
2020-01-02 13:52 [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682 Arnd Bergmann
@ 2020-01-02 18:50 ` Pierre-Louis Bossart
2020-01-03 1:05 ` Applied "ASoC: Intel: boards: Fix compile-testing RT1011/RT5682" to the asoc tree Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2020-01-02 18:50 UTC (permalink / raw)
To: Arnd Bergmann, Cezary Rojewski, Liam Girdwood, Jie Yang, Mark Brown
Cc: Jaroslav Kysela, Takashi Iwai, Naveen Manohar,
Sathya Prakash M R, Kai Vehmanen, alsa-devel, linux-kernel
On 1/2/20 7:52 AM, Arnd Bergmann wrote:
> On non-x86, the new driver results in a build failure:
>
> sound/soc/intel/boards/cml_rt1011_rt5682.c:14:10: fatal error: asm/cpu_device_id.h: No such file or directory
>
> The asm/cpu_device_id.h header is not actually needed here,
> so don't include it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Indeed it's not needed, thanks for spotting this.
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> I found this last week, but the patch still seems to be needed
> as I could not find a fix in mainline or -next.
>
> Please ignore if there is already a fix in some other tree.
>
>
> sound/soc/intel/boards/cml_rt1011_rt5682.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> index a22f97234201..5f1bf6d3800c 100644
> --- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
> +++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
> @@ -11,7 +11,6 @@
> #include <linux/clk.h>
> #include <linux/dmi.h>
> #include <linux/slab.h>
> -#include <asm/cpu_device_id.h>
> #include <linux/acpi.h>
> #include <sound/core.h>
> #include <sound/jack.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Applied "ASoC: Intel: boards: Fix compile-testing RT1011/RT5682" to the asoc tree
2020-01-02 13:52 [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682 Arnd Bergmann
2020-01-02 18:50 ` [alsa-devel] " Pierre-Louis Bossart
@ 2020-01-03 1:05 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-01-03 1:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: alsa-devel, Cezary Rojewski, Jaroslav Kysela, Jie Yang,
Kai Vehmanen, Liam Girdwood, linux-kernel, Mark Brown,
Naveen Manohar, Pierre-Louis Bossart, Sathya Prakash M R,
Takashi Iwai
The patch
ASoC: Intel: boards: Fix compile-testing RT1011/RT5682
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From ff3b57417012fcc963ec281f5705bed837e4b1ac Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 2 Jan 2020 14:52:55 +0100
Subject: [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682
On non-x86, the new driver results in a build failure:
sound/soc/intel/boards/cml_rt1011_rt5682.c:14:10: fatal error: asm/cpu_device_id.h: No such file or directory
The asm/cpu_device_id.h header is not actually needed here,
so don't include it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200102135322.1841053-1-arnd@arndb.de
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/cml_rt1011_rt5682.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/intel/boards/cml_rt1011_rt5682.c b/sound/soc/intel/boards/cml_rt1011_rt5682.c
index a22f97234201..5f1bf6d3800c 100644
--- a/sound/soc/intel/boards/cml_rt1011_rt5682.c
+++ b/sound/soc/intel/boards/cml_rt1011_rt5682.c
@@ -11,7 +11,6 @@
#include <linux/clk.h>
#include <linux/dmi.h>
#include <linux/slab.h>
-#include <asm/cpu_device_id.h>
#include <linux/acpi.h>
#include <sound/core.h>
#include <sound/jack.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-03 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02 13:52 [PATCH] ASoC: Intel: boards: Fix compile-testing RT1011/RT5682 Arnd Bergmann
2020-01-02 18:50 ` [alsa-devel] " Pierre-Louis Bossart
2020-01-03 1:05 ` Applied "ASoC: Intel: boards: Fix compile-testing RT1011/RT5682" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).