* [PATCH] net/mlx5: use swap() to make code cleaner
@ 2021-11-04 1:17 davidcomponentone
2021-11-04 5:26 ` Saeed Mahameed
2021-11-16 20:56 ` Saeed Mahameed
0 siblings, 2 replies; 3+ messages in thread
From: davidcomponentone @ 2021-11-04 1:17 UTC (permalink / raw)
To: saeedm
Cc: davidcomponentone, leon, davem, kuba, roid, paulb, ozsh, vladbu,
cmi, lariel, netdev, linux-rdma, linux-kernel, Yang Guang,
Zeal Robot
From: Yang Guang <yang.guang5@zte.com.cn>
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
---
drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
index c1c6e74c79c4..8ce4b6112169 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
@@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct mlx5_tc_ct_priv *ct_priv,
struct mlx5_ct_tuple rev_tuple = entry->tuple;
struct mlx5_ct_counter *shared_counter;
struct mlx5_ct_entry *rev_entry;
- __be16 tmp_port;
/* get the reversed tuple */
- tmp_port = rev_tuple.port.src;
- rev_tuple.port.src = rev_tuple.port.dst;
- rev_tuple.port.dst = tmp_port;
+ swap(rev_tuple.port.src, rev_tuple.port.dst);
if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
__be32 tmp_addr = rev_tuple.ip.src_v4;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: use swap() to make code cleaner
2021-11-04 1:17 [PATCH] net/mlx5: use swap() to make code cleaner davidcomponentone
@ 2021-11-04 5:26 ` Saeed Mahameed
2021-11-16 20:56 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2021-11-04 5:26 UTC (permalink / raw)
To: davidcomponentone
Cc: linux-rdma, zealci, davem, Roi Dayan, Ariel Levkovich,
Paul Blakey, Vlad Buslov, linux-kernel, Chris Mi, kuba, netdev,
leon, Oz Shlomo, yang.guang5
On Thu, 2021-11-04 at 09:17 +0800, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
sorry you're too late, another patch was already submitted:
https://patchwork.kernel.org/project/netdevbpf/patch/20211103062111.3286-1-hanyihao@vivo.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: use swap() to make code cleaner
2021-11-04 1:17 [PATCH] net/mlx5: use swap() to make code cleaner davidcomponentone
2021-11-04 5:26 ` Saeed Mahameed
@ 2021-11-16 20:56 ` Saeed Mahameed
1 sibling, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2021-11-16 20:56 UTC (permalink / raw)
To: davidcomponentone
Cc: linux-rdma, zealci, davem, Roi Dayan, Ariel Levkovich,
Paul Blakey, Vlad Buslov, linux-kernel, Chris Mi, kuba, netdev,
leon, Oz Shlomo, yang.guang5
On Thu, 2021-11-04 at 09:17 +0800, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> index c1c6e74c79c4..8ce4b6112169 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c
> @@ -907,12 +907,9 @@ mlx5_tc_ct_shared_counter_get(struct
> mlx5_tc_ct_priv *ct_priv,
> struct mlx5_ct_tuple rev_tuple = entry->tuple;
> struct mlx5_ct_counter *shared_counter;
> struct mlx5_ct_entry *rev_entry;
> - __be16 tmp_port;
>
> /* get the reversed tuple */
> - tmp_port = rev_tuple.port.src;
> - rev_tuple.port.src = rev_tuple.port.dst;
> - rev_tuple.port.dst = tmp_port;
> + swap(rev_tuple.port.src, rev_tuple.port.dst);
>
> if (rev_tuple.addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
> __be32 tmp_addr = rev_tuple.ip.src_v4;
An identical patch was already submitted the day before.
Thanks for the effort !
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-16 20:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 1:17 [PATCH] net/mlx5: use swap() to make code cleaner davidcomponentone
2021-11-04 5:26 ` Saeed Mahameed
2021-11-16 20:56 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).