* BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
@ 2020-11-23 11:58 syzbot
2020-11-25 13:51 ` syzbot
2020-11-25 16:03 ` Oliver Hartkopp
0 siblings, 2 replies; 5+ messages in thread
From: syzbot @ 2020-11-23 11:58 UTC (permalink / raw)
To: davem, kuba, linux-can, linux-kernel, mkl, netdev, socketcan,
syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: c2e7554e Merge tag 'gfs2-v5.10-rc4-fixes' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=117f03ba500000
kernel config: https://syzkaller.appspot.com/x/.config?x=75292221eb79ace2
dashboard link: https://syzkaller.appspot.com/bug?extid=381d06e0c8eaacb8706f
compiler: gcc (GCC) 10.1.0-syz 20200507
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
------------[ cut here ]------------
BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
WARNING: CPU: 1 PID: 12946 at net/can/af_can.c:546 can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
Modules linked in:
CPU: 1 PID: 12946 Comm: syz-executor.1 Not tainted 5.10.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
Code: 8b 7c 24 78 44 8b 64 24 68 49 c7 c5 20 ac 56 8a e8 01 6c 97 f9 44 89 f9 44 89 e2 4c 89 ee 48 c7 c7 60 ac 56 8a e8 66 af d3 00 <0f> 0b 48 8b 7c 24 28 e8 b0 25 0f 01 e9 54 fb ff ff e8 26 e0 d8 f9
RSP: 0018:ffffc90017e2fb38 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff8880147a8000 RSI: ffffffff8158f3c5 RDI: fffff52002fc5f59
RBP: 0000000000000118 R08: 0000000000000001 R09: ffff8880b9f2011b
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000002
R13: ffff8880254c0000 R14: 1ffff92002fc5f6e R15: 00000000c00007ff
FS: 0000000001ddc940(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2f121000 CR3: 00000000152c0000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
isotp_notifier+0x2a7/0x540 net/can/isotp.c:1303
call_netdevice_notifier net/core/dev.c:1735 [inline]
call_netdevice_unregister_notifiers+0x156/0x1c0 net/core/dev.c:1763
call_netdevice_unregister_net_notifiers net/core/dev.c:1791 [inline]
unregister_netdevice_notifier+0xcd/0x170 net/core/dev.c:1870
isotp_release+0x136/0x600 net/can/isotp.c:1011
__sock_release+0xcd/0x280 net/socket.c:596
sock_close+0x18/0x20 net/socket.c:1277
__fput+0x285/0x920 fs/file_table.c:281
task_work_run+0xdd/0x190 kernel/task_work.c:151
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_user_mode_loop kernel/entry/common.c:164 [inline]
exit_to_user_mode_prepare+0x17e/0x1a0 kernel/entry/common.c:191
syscall_exit_to_user_mode+0x38/0x260 kernel/entry/common.c:266
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x417811
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:000000000169fbf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000417811
RDX: 0000000000000000 RSI: 00000000000013b7 RDI: 0000000000000003
RBP: 0000000000000001 R08: 00000000acabb3b7 R09: 00000000acabb3bb
R10: 000000000169fcd0 R11: 0000000000000293 R12: 000000000118c9a0
R13: 000000000118c9a0 R14: 00000000000003e8 R15: 000000000118bf2c
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
2020-11-23 11:58 BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF syzbot
@ 2020-11-25 13:51 ` syzbot
2020-11-25 16:03 ` Oliver Hartkopp
1 sibling, 0 replies; 5+ messages in thread
From: syzbot @ 2020-11-25 13:51 UTC (permalink / raw)
To: davem, kuba, linux-can, linux-kernel, mkl, netdev, socketcan,
syzkaller-bugs
syzbot has found a reproducer for the following issue on:
HEAD commit: 470dfd80 lan743x: replace polling loop by wait_event_timeo..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=107c26a5500000
kernel config: https://syzkaller.appspot.com/x/.config?x=df65150a33f23d8c
dashboard link: https://syzkaller.appspot.com/bug?extid=381d06e0c8eaacb8706f
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12bcd669500000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17ecad3e500000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00000000004442a9
RDX: 0000000000000018 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007ffc870fdef0 R08: 0000000000000001 R09: 0000000001bbbbbb
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc870fdf00
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
------------[ cut here ]------------
BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
WARNING: CPU: 0 PID: 8713 at net/can/af_can.c:546 can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
Modules linked in:
CPU: 0 PID: 8713 Comm: syz-executor284 Not tainted 5.10.0-rc4-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
Code: 8b 7c 24 78 44 8b 64 24 68 49 c7 c5 e0 de 56 8a e8 51 d3 95 f9 44 89 f9 44 89 e2 4c 89 ee 48 c7 c7 20 df 56 8a e8 a6 76 d3 00 <0f> 0b 48 8b 7c 24 28 e8 40 e9 0e 01 e9 54 fb ff ff e8 66 db d7 f9
RSP: 0018:ffffc90001b2fb38 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff888014db8000 RSI: ffffffff8158f3c5 RDI: fffff52000365f59
RBP: 0000000000000118 R08: 0000000000000001 R09: ffff8880b9e30627
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000002
R13: ffff8880261f0000 R14: 1ffff92000365f6e R15: 00000000c00007ff
FS: 0000000000807880(0000) GS:ffff8880b9e00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000004bdfc4 CR3: 0000000014c7c000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
isotp_notifier+0x2a7/0x540 net/can/isotp.c:1303
call_netdevice_notifier net/core/dev.c:1735 [inline]
call_netdevice_unregister_notifiers+0x156/0x1c0 net/core/dev.c:1763
call_netdevice_unregister_net_notifiers net/core/dev.c:1791 [inline]
unregister_netdevice_notifier+0xcd/0x170 net/core/dev.c:1870
isotp_release+0x136/0x600 net/can/isotp.c:1011
__sock_release+0xcd/0x280 net/socket.c:596
sock_close+0x18/0x20 net/socket.c:1255
__fput+0x285/0x920 fs/file_table.c:281
task_work_run+0xdd/0x190 kernel/task_work.c:151
tracehook_notify_resume include/linux/tracehook.h:188 [inline]
exit_to_user_mode_loop kernel/entry/common.c:164 [inline]
exit_to_user_mode_prepare+0x17e/0x1a0 kernel/entry/common.c:191
syscall_exit_to_user_mode+0x38/0x260 kernel/entry/common.c:266
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x403b20
Code: 01 f0 ff ff 0f 83 40 0d 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 83 3d 6d bc 2d 00 00 75 14 b8 03 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 14 0d 00 00 c3 48 83 ec 08 e8 7a 02 00 00
RSP: 002b:00007ffc870fdee8 EFLAGS: 00000246 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000005 RCX: 0000000000403b20
RDX: 0000000000000018 RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007ffc870fdef0 R08: 0000000000000001 R09: 0000000001bbbbbb
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc870fdf00
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
2020-11-23 11:58 BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF syzbot
2020-11-25 13:51 ` syzbot
@ 2020-11-25 16:03 ` Oliver Hartkopp
2020-11-25 18:48 ` Dmitry Vyukov
1 sibling, 1 reply; 5+ messages in thread
From: Oliver Hartkopp @ 2020-11-25 16:03 UTC (permalink / raw)
To: syzbot, davem, kuba, linux-can, linux-kernel, mkl, netdev,
syzkaller-bugs
Hello all,
AFAICS the problems are caused by the WARN() statement here:
https://elixir.bootlin.com/linux/v5.10-rc4/source/net/can/af_can.c#L546
The idea was to check whether CAN protocol implementations work
correctly on their filter lists.
With the fault injection it seem like we're getting a race between
closing the socket and removing the netdevice.
This seems to be very seldom but it does not break anything.
Would removing the WARN(1) or replacing it with pr_warn() be ok to close
this issue?
Best regards,
Oliver
On 23.11.20 12:58, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: c2e7554e Merge tag 'gfs2-v5.10-rc4-fixes' of git://git.ker..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=117f03ba500000
> kernel config: https://syzkaller.appspot.com/x/.config?x=75292221eb79ace2
> dashboard link: https://syzkaller.appspot.com/bug?extid=381d06e0c8eaacb8706f
> compiler: gcc (GCC) 10.1.0-syz 20200507
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
> WARNING: CPU: 1 PID: 12946 at net/can/af_can.c:546 can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
> Modules linked in:
> CPU: 1 PID: 12946 Comm: syz-executor.1 Not tainted 5.10.0-rc4-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> RIP: 0010:can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
> Code: 8b 7c 24 78 44 8b 64 24 68 49 c7 c5 20 ac 56 8a e8 01 6c 97 f9 44 89 f9 44 89 e2 4c 89 ee 48 c7 c7 60 ac 56 8a e8 66 af d3 00 <0f> 0b 48 8b 7c 24 28 e8 b0 25 0f 01 e9 54 fb ff ff e8 26 e0 d8 f9
> RSP: 0018:ffffc90017e2fb38 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
> RDX: ffff8880147a8000 RSI: ffffffff8158f3c5 RDI: fffff52002fc5f59
> RBP: 0000000000000118 R08: 0000000000000001 R09: ffff8880b9f2011b
> R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000002
> R13: ffff8880254c0000 R14: 1ffff92002fc5f6e R15: 00000000c00007ff
> FS: 0000000001ddc940(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000001b2f121000 CR3: 00000000152c0000 CR4: 00000000001506e0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> isotp_notifier+0x2a7/0x540 net/can/isotp.c:1303
> call_netdevice_notifier net/core/dev.c:1735 [inline]
> call_netdevice_unregister_notifiers+0x156/0x1c0 net/core/dev.c:1763
> call_netdevice_unregister_net_notifiers net/core/dev.c:1791 [inline]
> unregister_netdevice_notifier+0xcd/0x170 net/core/dev.c:1870
> isotp_release+0x136/0x600 net/can/isotp.c:1011
> __sock_release+0xcd/0x280 net/socket.c:596
> sock_close+0x18/0x20 net/socket.c:1277
> __fput+0x285/0x920 fs/file_table.c:281
> task_work_run+0xdd/0x190 kernel/task_work.c:151
> tracehook_notify_resume include/linux/tracehook.h:188 [inline]
> exit_to_user_mode_loop kernel/entry/common.c:164 [inline]
> exit_to_user_mode_prepare+0x17e/0x1a0 kernel/entry/common.c:191
> syscall_exit_to_user_mode+0x38/0x260 kernel/entry/common.c:266
> entry_SYSCALL_64_after_hwframe+0x44/0xa9
> RIP: 0033:0x417811
> Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
> RSP: 002b:000000000169fbf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
> RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000417811
> RDX: 0000000000000000 RSI: 00000000000013b7 RDI: 0000000000000003
> RBP: 0000000000000001 R08: 00000000acabb3b7 R09: 00000000acabb3bb
> R10: 000000000169fcd0 R11: 0000000000000293 R12: 000000000118c9a0
> R13: 000000000118c9a0 R14: 00000000000003e8 R15: 000000000118bf2c
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@googlegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
2020-11-25 16:03 ` Oliver Hartkopp
@ 2020-11-25 18:48 ` Dmitry Vyukov
2020-11-25 20:54 ` Oliver Hartkopp
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Vyukov @ 2020-11-25 18:48 UTC (permalink / raw)
To: Oliver Hartkopp
Cc: syzbot, David Miller, Jakub Kicinski, linux-can, LKML,
Marc Kleine-Budde, netdev, syzkaller-bugs
On Wed, Nov 25, 2020 at 5:04 PM Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>
> Hello all,
>
> AFAICS the problems are caused by the WARN() statement here:
>
> https://elixir.bootlin.com/linux/v5.10-rc4/source/net/can/af_can.c#L546
>
> The idea was to check whether CAN protocol implementations work
> correctly on their filter lists.
>
> With the fault injection it seem like we're getting a race between
> closing the socket and removing the netdevice.
>
> This seems to be very seldom but it does not break anything.
>
> Would removing the WARN(1) or replacing it with pr_warn() be ok to close
> this issue?
Hi Oliver,
Yes, this is the intended way to deal with this:
https://elixir.bootlin.com/linux/v5.10-rc5/source/include/asm-generic/bug.h#L75
Maybe a good opportunity to add some explanatory comment as well
regarding how it should not happen but can.
Thanks for looking into this.
> On 23.11.20 12:58, syzbot wrote:
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit: c2e7554e Merge tag 'gfs2-v5.10-rc4-fixes' of git://git.ker..
> > git tree: upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=117f03ba500000
> > kernel config: https://syzkaller.appspot.com/x/.config?x=75292221eb79ace2
> > dashboard link: https://syzkaller.appspot.com/bug?extid=381d06e0c8eaacb8706f
> > compiler: gcc (GCC) 10.1.0-syz 20200507
> >
> > Unfortunately, I don't have any reproducer for this issue yet.
> >
> > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
> >
> > ------------[ cut here ]------------
> > BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
> > WARNING: CPU: 1 PID: 12946 at net/can/af_can.c:546 can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
> > Modules linked in:
> > CPU: 1 PID: 12946 Comm: syz-executor.1 Not tainted 5.10.0-rc4-syzkaller #0
> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> > RIP: 0010:can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
> > Code: 8b 7c 24 78 44 8b 64 24 68 49 c7 c5 20 ac 56 8a e8 01 6c 97 f9 44 89 f9 44 89 e2 4c 89 ee 48 c7 c7 60 ac 56 8a e8 66 af d3 00 <0f> 0b 48 8b 7c 24 28 e8 b0 25 0f 01 e9 54 fb ff ff e8 26 e0 d8 f9
> > RSP: 0018:ffffc90017e2fb38 EFLAGS: 00010286
> > RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
> > RDX: ffff8880147a8000 RSI: ffffffff8158f3c5 RDI: fffff52002fc5f59
> > RBP: 0000000000000118 R08: 0000000000000001 R09: ffff8880b9f2011b
> > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000002
> > R13: ffff8880254c0000 R14: 1ffff92002fc5f6e R15: 00000000c00007ff
> > FS: 0000000001ddc940(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000
> > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > CR2: 0000001b2f121000 CR3: 00000000152c0000 CR4: 00000000001506e0
> > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> > Call Trace:
> > isotp_notifier+0x2a7/0x540 net/can/isotp.c:1303
> > call_netdevice_notifier net/core/dev.c:1735 [inline]
> > call_netdevice_unregister_notifiers+0x156/0x1c0 net/core/dev.c:1763
> > call_netdevice_unregister_net_notifiers net/core/dev.c:1791 [inline]
> > unregister_netdevice_notifier+0xcd/0x170 net/core/dev.c:1870
> > isotp_release+0x136/0x600 net/can/isotp.c:1011
> > __sock_release+0xcd/0x280 net/socket.c:596
> > sock_close+0x18/0x20 net/socket.c:1277
> > __fput+0x285/0x920 fs/file_table.c:281
> > task_work_run+0xdd/0x190 kernel/task_work.c:151
> > tracehook_notify_resume include/linux/tracehook.h:188 [inline]
> > exit_to_user_mode_loop kernel/entry/common.c:164 [inline]
> > exit_to_user_mode_prepare+0x17e/0x1a0 kernel/entry/common.c:191
> > syscall_exit_to_user_mode+0x38/0x260 kernel/entry/common.c:266
> > entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > RIP: 0033:0x417811
> > Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
> > RSP: 002b:000000000169fbf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
> > RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000417811
> > RDX: 0000000000000000 RSI: 00000000000013b7 RDI: 0000000000000003
> > RBP: 0000000000000001 R08: 00000000acabb3b7 R09: 00000000acabb3bb
> > R10: 000000000169fcd0 R11: 0000000000000293 R12: 000000000118c9a0
> > R13: 000000000118c9a0 R14: 00000000000003e8 R15: 000000000118bf2c
> >
> >
> > ---
> > This report is generated by a bot. It may contain errors.
> > See https://goo.gl/tpsmEJ for more information about syzbot.
> > syzbot engineers can be reached at syzkaller@googlegroups.com.
> >
> > syzbot will keep track of this issue. See:
> > https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> >
>
> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/b134c098-2f34-15ee-cfec-2103a12da326%40hartkopp.net.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
2020-11-25 18:48 ` Dmitry Vyukov
@ 2020-11-25 20:54 ` Oliver Hartkopp
0 siblings, 0 replies; 5+ messages in thread
From: Oliver Hartkopp @ 2020-11-25 20:54 UTC (permalink / raw)
To: Dmitry Vyukov
Cc: syzbot, David Miller, Jakub Kicinski, linux-can, LKML,
Marc Kleine-Budde, netdev, syzkaller-bugs
Hi Dmitry,
On 25.11.20 19:48, Dmitry Vyukov wrote:
> On Wed, Nov 25, 2020 at 5:04 PM Oliver Hartkopp <socketcan@hartkopp.net> wrote:
>> This seems to be very seldom but it does not break anything.
>>
>> Would removing the WARN(1) or replacing it with pr_warn() be ok to close
>> this issue?
>
> Yes, this is the intended way to deal with this:
> https://elixir.bootlin.com/linux/v5.10-rc5/source/include/asm-generic/bug.h#L75
>
> Maybe a good opportunity to add some explanatory comment as well
> regarding how it should not happen but can.
I already prepared a patch for it which has indeed 90% explanatory
comment ;-)
Will send out a patch tomorrow after collecting all the three/four?
syskaller bug IDs that popped up with this issue :-D
Many thanks!
Oliver
>
>
>
>
>> On 23.11.20 12:58, syzbot wrote:
>>> Hello,
>>>
>>> syzbot found the following issue on:
>>>
>>> HEAD commit: c2e7554e Merge tag 'gfs2-v5.10-rc4-fixes' of git://git.ker..
>>> git tree: upstream
>>> console output: https://syzkaller.appspot.com/x/log.txt?x=117f03ba500000
>>> kernel config: https://syzkaller.appspot.com/x/.config?x=75292221eb79ace2
>>> dashboard link: https://syzkaller.appspot.com/bug?extid=381d06e0c8eaacb8706f
>>> compiler: gcc (GCC) 10.1.0-syz 20200507
>>>
>>> Unfortunately, I don't have any reproducer for this issue yet.
>>>
>>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>>> Reported-by: syzbot+381d06e0c8eaacb8706f@syzkaller.appspotmail.com
>>>
>>> ------------[ cut here ]------------
>>> BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF
>>> WARNING: CPU: 1 PID: 12946 at net/can/af_can.c:546 can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
>>> Modules linked in:
>>> CPU: 1 PID: 12946 Comm: syz-executor.1 Not tainted 5.10.0-rc4-syzkaller #0
>>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
>>> RIP: 0010:can_rx_unregister+0x5a4/0x700 net/can/af_can.c:546
>>> Code: 8b 7c 24 78 44 8b 64 24 68 49 c7 c5 20 ac 56 8a e8 01 6c 97 f9 44 89 f9 44 89 e2 4c 89 ee 48 c7 c7 60 ac 56 8a e8 66 af d3 00 <0f> 0b 48 8b 7c 24 28 e8 b0 25 0f 01 e9 54 fb ff ff e8 26 e0 d8 f9
>>> RSP: 0018:ffffc90017e2fb38 EFLAGS: 00010286
>>> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
>>> RDX: ffff8880147a8000 RSI: ffffffff8158f3c5 RDI: fffff52002fc5f59
>>> RBP: 0000000000000118 R08: 0000000000000001 R09: ffff8880b9f2011b
>>> R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000002
>>> R13: ffff8880254c0000 R14: 1ffff92002fc5f6e R15: 00000000c00007ff
>>> FS: 0000000001ddc940(0000) GS:ffff8880b9f00000(0000) knlGS:0000000000000000
>>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>>> CR2: 0000001b2f121000 CR3: 00000000152c0000 CR4: 00000000001506e0
>>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>>> Call Trace:
>>> isotp_notifier+0x2a7/0x540 net/can/isotp.c:1303
>>> call_netdevice_notifier net/core/dev.c:1735 [inline]
>>> call_netdevice_unregister_notifiers+0x156/0x1c0 net/core/dev.c:1763
>>> call_netdevice_unregister_net_notifiers net/core/dev.c:1791 [inline]
>>> unregister_netdevice_notifier+0xcd/0x170 net/core/dev.c:1870
>>> isotp_release+0x136/0x600 net/can/isotp.c:1011
>>> __sock_release+0xcd/0x280 net/socket.c:596
>>> sock_close+0x18/0x20 net/socket.c:1277
>>> __fput+0x285/0x920 fs/file_table.c:281
>>> task_work_run+0xdd/0x190 kernel/task_work.c:151
>>> tracehook_notify_resume include/linux/tracehook.h:188 [inline]
>>> exit_to_user_mode_loop kernel/entry/common.c:164 [inline]
>>> exit_to_user_mode_prepare+0x17e/0x1a0 kernel/entry/common.c:191
>>> syscall_exit_to_user_mode+0x38/0x260 kernel/entry/common.c:266
>>> entry_SYSCALL_64_after_hwframe+0x44/0xa9
>>> RIP: 0033:0x417811
>>> Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
>>> RSP: 002b:000000000169fbf0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
>>> RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000417811
>>> RDX: 0000000000000000 RSI: 00000000000013b7 RDI: 0000000000000003
>>> RBP: 0000000000000001 R08: 00000000acabb3b7 R09: 00000000acabb3bb
>>> R10: 000000000169fcd0 R11: 0000000000000293 R12: 000000000118c9a0
>>> R13: 000000000118c9a0 R14: 00000000000003e8 R15: 000000000118bf2c
>>>
>>>
>>> ---
>>> This report is generated by a bot. It may contain errors.
>>> See https://goo.gl/tpsmEJ for more information about syzbot.
>>> syzbot engineers can be reached at syzkaller@googlegroups.com.
>>>
>>> syzbot will keep track of this issue. See:
>>> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/b134c098-2f34-15ee-cfec-2103a12da326%40hartkopp.net.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-25 20:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 11:58 BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF syzbot
2020-11-25 13:51 ` syzbot
2020-11-25 16:03 ` Oliver Hartkopp
2020-11-25 18:48 ` Dmitry Vyukov
2020-11-25 20:54 ` Oliver Hartkopp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).