* [PATCH] newport_con: vc_color is now in state
[not found] <202007241318.wXYkumEO%lkp@intel.com>
@ 2020-07-24 6:27 ` Jiri Slaby
2020-07-24 7:58 ` Greg KH
2020-07-24 9:30 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: Jiri Slaby @ 2020-07-24 6:27 UTC (permalink / raw)
To: gregkh
Cc: linux-serial, linux-kernel, Jiri Slaby,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-mips
Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
vc->state.color. Somehow both me and 0-day bot missed this driver during
the conversion.
So fix the driver now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-mips@vger.kernel.org
---
drivers/video/console/newport_con.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index df3c52d72159..72f146d047d9 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -362,12 +362,12 @@ static void newport_clear(struct vc_data *vc, int sy, int sx, int height,
if (ystart < yend) {
newport_clear_screen(sx << 3, ystart, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
newport_clear_screen(sx << 3, ystart, xend, 1023,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
newport_clear_screen(sx << 3, 0, xend, yend,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
}
@@ -591,11 +591,11 @@ static bool newport_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
topscan = (topscan + (lines << 4)) & 0x3ff;
newport_clear_lines(vc->vc_rows - lines,
vc->vc_rows - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
} else {
topscan = (topscan + (-lines << 4)) & 0x3ff;
newport_clear_lines(0, lines - 1,
- (vc->vc_color & 0xf0) >> 4);
+ (vc->state.color & 0xf0) >> 4);
}
npregs->cset.topscan = (topscan - 1) & 0x3ff;
return false;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 6:27 ` [PATCH] newport_con: vc_color is now in state Jiri Slaby
@ 2020-07-24 7:58 ` Greg KH
2020-07-24 7:59 ` Jiri Slaby
2020-07-24 9:30 ` Sergei Shtylyov
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-07-24 7:58 UTC (permalink / raw)
To: Jiri Slaby
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
> ---
> drivers/video/console/newport_con.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
You forgot the "Reported-by:" line :(
I'll go add it, thanks for the fix.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 7:58 ` Greg KH
@ 2020-07-24 7:59 ` Jiri Slaby
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2020-07-24 7:59 UTC (permalink / raw)
To: Greg KH
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24. 07. 20, 9:58, Greg KH wrote:
> On Fri, Jul 24, 2020 at 08:27:35AM +0200, Jiri Slaby wrote:
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>> vc->state.color. Somehow both me and 0-day bot missed this driver during
>> the conversion.
>>
>> So fix the driver now.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-fbdev@vger.kernel.org
>> Cc: linux-mips@vger.kernel.org
>> ---
>> drivers/video/console/newport_con.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> You forgot the "Reported-by:" line :(
Ah, I didn't know/notice. Will do next time. Thanks.
--
js
suse labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 6:27 ` [PATCH] newport_con: vc_color is now in state Jiri Slaby
2020-07-24 7:58 ` Greg KH
@ 2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:38 ` Greg KH
2020-07-24 10:30 ` Jiri Slaby
1 sibling, 2 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2020-07-24 9:30 UTC (permalink / raw)
To: Jiri Slaby, gregkh
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24.07.2020 9:27, Jiri Slaby wrote:
> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
enclose the commit summary in (""), not just ()...
> vc->state.color. Somehow both me and 0-day bot missed this driver during
> the conversion.
>
> So fix the driver now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-mips@vger.kernel.org
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 9:30 ` Sergei Shtylyov
@ 2020-07-24 9:38 ` Greg KH
2020-07-24 10:30 ` Jiri Slaby
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-07-24 9:38 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Jiri Slaby, linux-serial, linux-kernel,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-mips
On Fri, Jul 24, 2020 at 12:30:59PM +0300, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
> > Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should
> enclose the commit summary in (""), not just ()...
I've added the proper "Fixes:" tag when committing this, no worries.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] newport_con: vc_color is now in state
2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:38 ` Greg KH
@ 2020-07-24 10:30 ` Jiri Slaby
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2020-07-24 10:30 UTC (permalink / raw)
To: Sergei Shtylyov, gregkh
Cc: linux-serial, linux-kernel, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, linux-mips
On 24. 07. 20, 11:30, Sergei Shtylyov wrote:
> On 24.07.2020 9:27, Jiri Slaby wrote:
>
>> Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as
>
> Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo).
That's because it's not in Linus' repo yet.
--
js
suse labs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-24 10:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202007241318.wXYkumEO%lkp@intel.com>
2020-07-24 6:27 ` [PATCH] newport_con: vc_color is now in state Jiri Slaby
2020-07-24 7:58 ` Greg KH
2020-07-24 7:59 ` Jiri Slaby
2020-07-24 9:30 ` Sergei Shtylyov
2020-07-24 9:38 ` Greg KH
2020-07-24 10:30 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).