linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] staging: lustre: Fix checkpatch.pl warnings.
@ 2015-03-17  1:21 Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 1/3] staging: lustre: space prohibited between function name and open parenthesis '(' Alberto Pires de Oliveira Neto
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-03-17  1:21 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh
  Cc: linux-kernel, Alberto Pires de Oliveira Neto

Changes since v1:
 - Put '}' in the next line instead of just insert a space for lproc_fld.c.

Alberto Pires de Oliveira Neto (3):
  staging: lustre: space prohibited between function name and open parenthesis '('
  staging: lustre: void function return statements are not generally useful.
  staging: lustre: space required after that close brace '}'

 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 drivers/staging/lustre/lustre/fld/fld_request.c  | 1 -
 drivers/staging/lustre/lustre/fld/lproc_fld.c    | 3 ++-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/3] staging: lustre: space prohibited between function name and open parenthesis '('
  2015-03-17  1:21 [PATCH v2 0/3] staging: lustre: Fix checkpatch.pl warnings Alberto Pires de Oliveira Neto
@ 2015-03-17  1:21 ` Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 2/3] staging: lustre: void function return statements are not generally useful Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 3/3] staging: lustre: space required after that close brace '}' Alberto Pires de Oliveira Neto
  2 siblings, 0 replies; 4+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-03-17  1:21 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh
  Cc: linux-kernel, Alberto Pires de Oliveira Neto

This patch fixes checkpatch.pl warning.
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_internal.h b/drivers/staging/lustre/lustre/fld/fld_internal.h
index 6125bbe..68bec765 100644
--- a/drivers/staging/lustre/lustre/fld/fld_internal.h
+++ b/drivers/staging/lustre/lustre/fld/fld_internal.h
@@ -142,7 +142,7 @@ extern struct lu_fld_hash fld_hash[];
 int fld_client_rpc(struct obd_export *exp,
 		   struct lu_seq_range *range, __u32 fld_op);
 
-#if defined (CONFIG_PROC_FS)
+#if defined(CONFIG_PROC_FS)
 extern struct lprocfs_vars fld_client_proc_list[];
 #endif
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/3] staging: lustre: void function return statements are not generally useful.
  2015-03-17  1:21 [PATCH v2 0/3] staging: lustre: Fix checkpatch.pl warnings Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 1/3] staging: lustre: space prohibited between function name and open parenthesis '(' Alberto Pires de Oliveira Neto
@ 2015-03-17  1:21 ` Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 3/3] staging: lustre: space required after that close brace '}' Alberto Pires de Oliveira Neto
  2 siblings, 0 replies; 4+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-03-17  1:21 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh
  Cc: linux-kernel, Alberto Pires de Oliveira Neto

This patch fixes checkpatch.pl warning.
WARNING: void function return statements are not generally useful

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/fld_request.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c
index 22e0d94..6ac225e 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -326,7 +326,6 @@ static int fld_client_proc_init(struct lu_client_fld *fld)
 
 void fld_client_proc_fini(struct lu_client_fld *fld)
 {
-	return;
 }
 #endif
 EXPORT_SYMBOL(fld_client_proc_fini);
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 3/3] staging: lustre: space required after that close brace '}'
  2015-03-17  1:21 [PATCH v2 0/3] staging: lustre: Fix checkpatch.pl warnings Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 1/3] staging: lustre: space prohibited between function name and open parenthesis '(' Alberto Pires de Oliveira Neto
  2015-03-17  1:21 ` [PATCH v2 2/3] staging: lustre: void function return statements are not generally useful Alberto Pires de Oliveira Neto
@ 2015-03-17  1:21 ` Alberto Pires de Oliveira Neto
  2 siblings, 0 replies; 4+ messages in thread
From: Alberto Pires de Oliveira Neto @ 2015-03-17  1:21 UTC (permalink / raw)
  To: oleg.drokin, andreas.dilger, gregkh
  Cc: linux-kernel, Alberto Pires de Oliveira Neto

This patch fixes checkpatch.pl warning.
WARNING: space required after that close brace '}'

Signed-off-by: Alberto Pires de Oliveira Neto <mrpenguin2005@gmail.com>
---
 drivers/staging/lustre/lustre/fld/lproc_fld.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
index 8c5a657..f53fdcf 100644
--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
+++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
@@ -168,4 +168,5 @@ struct lprocfs_vars fld_client_proc_list[] = {
 	{ "targets", &fld_proc_targets_fops },
 	{ "hash", &fld_proc_hash_fops },
 	{ "cache_flush", &fld_proc_cache_flush_fops },
-	{ NULL }};
+	{ NULL }
+};
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-17  1:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-17  1:21 [PATCH v2 0/3] staging: lustre: Fix checkpatch.pl warnings Alberto Pires de Oliveira Neto
2015-03-17  1:21 ` [PATCH v2 1/3] staging: lustre: space prohibited between function name and open parenthesis '(' Alberto Pires de Oliveira Neto
2015-03-17  1:21 ` [PATCH v2 2/3] staging: lustre: void function return statements are not generally useful Alberto Pires de Oliveira Neto
2015-03-17  1:21 ` [PATCH v2 3/3] staging: lustre: space required after that close brace '}' Alberto Pires de Oliveira Neto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).