linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm/mm_init: use helper macro BITS_PER_LONG
@ 2023-08-03 11:40 Miaohe Lin
  2023-08-03 13:08 ` David Hildenbrand
  2023-08-03 13:33 ` Mike Rapoport
  0 siblings, 2 replies; 4+ messages in thread
From: Miaohe Lin @ 2023-08-03 11:40 UTC (permalink / raw)
  To: akpm, rppt; +Cc: linux-mm, linux-kernel, linmiaohe

It's more readable to use helper macro BITS_PER_LONG. No functional
change intended.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/mm_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/mm_init.c b/mm/mm_init.c
index 66aca3f6accd..2f37dbb5ff9a 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void)
 	int shift, width;
 	unsigned long or_mask, add_mask;
 
-	shift = 8 * sizeof(unsigned long);
+	shift = BITS_PER_LONG;
 	width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH
 		- LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH;
 	mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths",
@@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l
 	usemapsize = roundup(zonesize, pageblock_nr_pages);
 	usemapsize = usemapsize >> pageblock_order;
 	usemapsize *= NR_PAGEBLOCK_BITS;
-	usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long));
+	usemapsize = roundup(usemapsize, BITS_PER_LONG);
 
 	return usemapsize / 8;
 }
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG
  2023-08-03 11:40 [PATCH] mm/mm_init: use helper macro BITS_PER_LONG Miaohe Lin
@ 2023-08-03 13:08 ` David Hildenbrand
  2023-08-03 13:33 ` Mike Rapoport
  1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2023-08-03 13:08 UTC (permalink / raw)
  To: Miaohe Lin, akpm, rppt; +Cc: linux-mm, linux-kernel

On 03.08.23 13:40, Miaohe Lin wrote:
> It's more readable to use helper macro BITS_PER_LONG. No functional
> change intended.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>   mm/mm_init.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 66aca3f6accd..2f37dbb5ff9a 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void)
>   	int shift, width;
>   	unsigned long or_mask, add_mask;
>   
> -	shift = 8 * sizeof(unsigned long);
> +	shift = BITS_PER_LONG;
>   	width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH
>   		- LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH;
>   	mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths",
> @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l
>   	usemapsize = roundup(zonesize, pageblock_nr_pages);
>   	usemapsize = usemapsize >> pageblock_order;
>   	usemapsize *= NR_PAGEBLOCK_BITS;
> -	usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long));
> +	usemapsize = roundup(usemapsize, BITS_PER_LONG);
>   
>   	return usemapsize / 8;
>   }

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG
  2023-08-03 11:40 [PATCH] mm/mm_init: use helper macro BITS_PER_LONG Miaohe Lin
  2023-08-03 13:08 ` David Hildenbrand
@ 2023-08-03 13:33 ` Mike Rapoport
  2023-08-04  1:53   ` Miaohe Lin
  1 sibling, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2023-08-03 13:33 UTC (permalink / raw)
  To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel

On Thu, Aug 03, 2023 at 07:40:51PM +0800, Miaohe Lin wrote:
> It's more readable to use helper macro BITS_PER_LONG. No functional
> change intended.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/mm_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index 66aca3f6accd..2f37dbb5ff9a 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void)
>  	int shift, width;
>  	unsigned long or_mask, add_mask;
>  
> -	shift = 8 * sizeof(unsigned long);
> +	shift = BITS_PER_LONG;
>  	width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH
>  		- LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH;
>  	mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths",
> @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l
>  	usemapsize = roundup(zonesize, pageblock_nr_pages);
>  	usemapsize = usemapsize >> pageblock_order;
>  	usemapsize *= NR_PAGEBLOCK_BITS;
> -	usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long));
> +	usemapsize = roundup(usemapsize, BITS_PER_LONG);
>  
>  	return usemapsize / 8;

BITS_PER_BYTE instead of 8 here?

>  }

-- 
Sincerely yours,
Mike.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG
  2023-08-03 13:33 ` Mike Rapoport
@ 2023-08-04  1:53   ` Miaohe Lin
  0 siblings, 0 replies; 4+ messages in thread
From: Miaohe Lin @ 2023-08-04  1:53 UTC (permalink / raw)
  To: Mike Rapoport; +Cc: akpm, linux-mm, linux-kernel

On 2023/8/3 21:33, Mike Rapoport wrote:
> On Thu, Aug 03, 2023 at 07:40:51PM +0800, Miaohe Lin wrote:
>> It's more readable to use helper macro BITS_PER_LONG. No functional
>> change intended.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>>  mm/mm_init.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/mm_init.c b/mm/mm_init.c
>> index 66aca3f6accd..2f37dbb5ff9a 100644
>> --- a/mm/mm_init.c
>> +++ b/mm/mm_init.c
>> @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void)
>>  	int shift, width;
>>  	unsigned long or_mask, add_mask;
>>  
>> -	shift = 8 * sizeof(unsigned long);
>> +	shift = BITS_PER_LONG;
>>  	width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH
>>  		- LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH;
>>  	mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths",
>> @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l
>>  	usemapsize = roundup(zonesize, pageblock_nr_pages);
>>  	usemapsize = usemapsize >> pageblock_order;
>>  	usemapsize *= NR_PAGEBLOCK_BITS;
>> -	usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long));
>> +	usemapsize = roundup(usemapsize, BITS_PER_LONG);
>>  
>>  	return usemapsize / 8;
> 
> BITS_PER_BYTE instead of 8 here?

Sure, this is even better. Will do.

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-04  1:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 11:40 [PATCH] mm/mm_init: use helper macro BITS_PER_LONG Miaohe Lin
2023-08-03 13:08 ` David Hildenbrand
2023-08-03 13:33 ` Mike Rapoport
2023-08-04  1:53   ` Miaohe Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).