linux-next: Fixes tag needs some work in the integrity tree

linux-next: Fixes tag needs some work in the integrity tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

In commit

  c594ea470f30 ("IMA: reject unknown hash algorithms in ima_get_hash_algo")

Fixes tag

  Fixes: 50f742dd9147 ("IMA: block writes of the security.ima xattr with

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split FIxes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the integrity tree

[THOBY Simon]

Hi Stephen,

On 8/24/21 12:18 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   c594ea470f30 ("IMA: reject unknown hash algorithms in ima_get_hash_algo")
> 
> Fixes tag
> 
>   Fixes: 50f742dd9147 ("IMA: block writes of the security.ima xattr with
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split FIxes tags over more than one line.
> 

It's my bad, I didn't check the line wrapping when I copy/pasted the tag :/

(btw checkpatch.pl doesn't detect this behavior, maybe this is something worth adding?)

Is there something I can do about it?
I don't suppose we can fix the commit, that would break the history of linux-next
(is it maybe acceptable considering it is a "staging area"?).

Sorry about that mistake,
Simon

Re: linux-next: Fixes tag needs some work in the integrity tree

[Mimi Zohar]

On Tue, 2021-08-24 at 07:11 +0000, THOBY Simon wrote:
> Hi Stephen,
> 
> On 8/24/21 12:18 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   c594ea470f30 ("IMA: reject unknown hash algorithms in ima_get_hash_algo")
> > 
> > Fixes tag
> > 
> >   Fixes: 50f742dd9147 ("IMA: block writes of the security.ima xattr with
> > 
> > has these problem(s):
> > 
> >   - Subject has leading but no trailing parentheses
> >   - Subject has leading but no trailing quotes
> > 
> > Please do not split FIxes tags over more than one line.
> > 
> 
> It's my bad, I didn't check the line wrapping when I copy/pasted the tag :/
> 
> (btw checkpatch.pl doesn't detect this behavior, maybe this is something worth adding?)
> 
> Is there something I can do about it?
> I don't suppose we can fix the commit, that would break the history of linux-next
> (is it maybe acceptable considering it is a "staging area"?).
> 
> Sorry about that mistake,

Hi Simon,

Sorry, along with my other suggestions, adding the "Fixes" tag was sent
as a comment, which the mailer reformatted.   As it is the top of the
branch, I've amended the commit and pushed it out to Korg.

For future reference, "git log --pretty=fixes -1 --abbrev=12 <commit
number>"  produces the proper message.  The "--abbrev" value can be set
by defining core.abbrev=12 in the git config.

thanks,

Mimi

linux-next: Fixes tag needs some work in the integrity tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hi all,

In commit

  9eea2904292c ("evm: Execute evm_inode_init_security() only when an HMAC key is loaded")

Fixes tag

  Fixes: 26ddabfe96b ("evm: enable EVM when X509 certificate is loaded")

has these problem(s):

  - SHA1 should be at least 12 digits long

Probably not worth rebasing for, but can be avoided in the future by
setting core.abbrev to 12 (or more) or (for git v2.11 or later) just
making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the integrity tree

[Mimi Zohar]

On Wed, 2021-06-02 at 08:07 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9eea2904292c ("evm: Execute evm_inode_init_security() only when an HMAC key is loaded")
> 
> Fixes tag
> 
>   Fixes: 26ddabfe96b ("evm: enable EVM when X509 certificate is loaded")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> Probably not worth rebasing for, but can be avoided in the future by
> setting core.abbrev to 12 (or more) or (for git v2.11 or later) just
> making sure it is not set (or set to "auto").

Stephen, thank you for catching the short hash.  It would be nice if
checkpatch would be updated to catch it.  I recently noticed
Documentation/process/submitting-patches.rst has directions for setting
up "--pretty=fixes".

thanks,

Mimi

linux-next: Fixes tag needs some work in the integrity tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Hi all,

In commit

  ae67dd38c193 ("evm: fix writing <securityfs>/evm overflow")

Fixes tag

  Fixes: f00d79750712 ("EVM: Allow userspace to signal an RSA key has been

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]