linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
@ 2020-02-26 18:35 Ley Foon Tan
  2020-02-27 14:48 ` Dinh Nguyen
  0 siblings, 1 reply; 3+ messages in thread
From: Ley Foon Tan @ 2020-02-26 18:35 UTC (permalink / raw)
  To: Dinh Nguyen; +Cc: linux-kernel, Chin Liang See, lftan.linux, Ley Foon Tan

Fix gmac compatible string to "altr,socfpga-stmmac-a10-s10". Gmac for
Agilex should use same compatible as Stratix 10.

Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
---
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
index e1d357eaad7c..d8c44d3ca15a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -102,7 +102,7 @@
 		};
 
 		gmac0: ethernet@ff800000 {
-			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
 			reg = <0xff800000 0x2000>;
 			interrupts = <0 90 4>;
 			interrupt-names = "macirq";
@@ -118,7 +118,7 @@
 		};
 
 		gmac1: ethernet@ff802000 {
-			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
 			reg = <0xff802000 0x2000>;
 			interrupts = <0 91 4>;
 			interrupt-names = "macirq";
@@ -134,7 +134,7 @@
 		};
 
 		gmac2: ethernet@ff804000 {
-			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
+			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
 			reg = <0xff804000 0x2000>;
 			interrupts = <0 92 4>;
 			interrupt-names = "macirq";
-- 
2.19.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
  2020-02-26 18:35 [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible Ley Foon Tan
@ 2020-02-27 14:48 ` Dinh Nguyen
  2020-02-28  0:40   ` Tan, Ley Foon
  0 siblings, 1 reply; 3+ messages in thread
From: Dinh Nguyen @ 2020-02-27 14:48 UTC (permalink / raw)
  To: Ley Foon Tan; +Cc: linux-kernel, Chin Liang See, lftan.linux

Hi Ley Foon,

Thanks for catching this. Can you resend with the Fixes tag and cc the
stable mailing list to get this backported to the stable kernels.

Thanks,
Dinh

On 2/26/20 12:35 PM, Ley Foon Tan wrote:
> Fix gmac compatible string to "altr,socfpga-stmmac-a10-s10". Gmac for
> Agilex should use same compatible as Stratix 10.
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> index e1d357eaad7c..d8c44d3ca15a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
> @@ -102,7 +102,7 @@
>  		};
>  
>  		gmac0: ethernet@ff800000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff800000 0x2000>;
>  			interrupts = <0 90 4>;
>  			interrupt-names = "macirq";
> @@ -118,7 +118,7 @@
>  		};
>  
>  		gmac1: ethernet@ff802000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff802000 0x2000>;
>  			interrupts = <0 91 4>;
>  			interrupt-names = "macirq";
> @@ -134,7 +134,7 @@
>  		};
>  
>  		gmac2: ethernet@ff804000 {
> -			compatible = "altr,socfpga-stmmac", "snps,dwmac-3.74a", "snps,dwmac";
> +			compatible = "altr,socfpga-stmmac-a10-s10", "snps,dwmac-3.74a", "snps,dwmac";
>  			reg = <0xff804000 0x2000>;
>  			interrupts = <0 92 4>;
>  			interrupt-names = "macirq";
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
  2020-02-27 14:48 ` Dinh Nguyen
@ 2020-02-28  0:40   ` Tan, Ley Foon
  0 siblings, 0 replies; 3+ messages in thread
From: Tan, Ley Foon @ 2020-02-28  0:40 UTC (permalink / raw)
  To: Dinh Nguyen; +Cc: linux-kernel, See, Chin Liang, lftan.linux



> -----Original Message-----
> From: Dinh Nguyen <dinguyen@kernel.org>
> Sent: Thursday, February 27, 2020 10:49 PM
> To: Tan, Ley Foon <ley.foon.tan@intel.com>
> Cc: linux-kernel@vger.kernel.org; See, Chin Liang
> <chin.liang.see@intel.com>; lftan.linux@gmail.com
> Subject: Re: [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible
> 
> Hi Ley Foon,
> 
> Thanks for catching this. Can you resend with the Fixes tag and cc the stable
> mailing list to get this backported to the stable kernels.
> 
> Thanks,
> Dinh

Okay.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-28  0:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 18:35 [PATCH] arm64: dts: socfpga: agilex: Fix gmac compatible Ley Foon Tan
2020-02-27 14:48 ` Dinh Nguyen
2020-02-28  0:40   ` Tan, Ley Foon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).