From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jisheng Zhang <jszhang@marvell.com>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections
Date: Fri, 12 Aug 2016 13:40:18 -0500 [thread overview]
Message-ID: <b2e1495f-b172-45e5-7329-016687623f3a@mentor.com> (raw)
In-Reply-To: <CAGXu5jL9=R7mASn7JJnODOUbxQ-yDi9eV-92bZHvEep38ezbdQ@mail.gmail.com>
On 08/12/2016 01:06 PM, Kees Cook wrote:
> On Fri, Aug 12, 2016 at 1:12 AM, Jisheng Zhang <jszhang@marvell.com> wrote:
>> vdso_data_mapping is never modified, so mark it as const.
>>
>> vdso_total_pages, vdso_data_page, vdso_text_mapping and cntvct_ok are
>> initialized by vdso_init(), thereafter are read only.
>>
>> The fact that they are read only after init makes them candidates for
>> __ro_after_init declarations.
>>
>> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
>
> Looks great; thanks for keeping __ro_after_init in mind. :)
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Looks fine and nothing goes wrong with my vdso tests. Please send it
through Russell.
Acked-by: Nathan Lynch <nathan_lynch@mentor.com>
prev parent reply other threads:[~2016-08-12 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 8:12 [PATCH v3] ARM: VDSO: put RO and RO after init objects into proper sections Jisheng Zhang
2016-08-12 18:06 ` Kees Cook
2016-08-12 18:40 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2e1495f-b172-45e5-7329-016687623f3a@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=arnd@arndb.de \
--cc=jszhang@marvell.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).