From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>,
Mark Brown <broonie@kernel.org>
Cc: jack.yu@realtek.com, alsa-devel@alsa-project.org,
Sunil-kumar.Dommati@amd.com, kent_chen@realtek.com,
Arnd Bergmann <arnd@arndb.de>, Tzung-Bi Shih <tzungbi@google.com>,
open list <linux-kernel@vger.kernel.org>,
Basavaraj.Hiregoudar@amd.com, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Alexander.Deucher@amd.com, shumingf@realtek.com,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
flove@realtek.com, Akshu Agrawal <akshu.agrawal@amd.com>
Subject: Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver
Date: Mon, 5 Apr 2021 11:24:22 -0500 [thread overview]
Message-ID: <b330ca5e-1162-29c9-d846-fbfbd9db638f@linux.intel.com> (raw)
In-Reply-To: <972d38d8-39c8-66d7-292d-37c1f0e027bd@amd.com>
>>>>>> static const struct acpi_device_id acp3x_audio_acpi_match[] = {
>>>>>> { "AMDI5682", (unsigned long)&acp3x_5682},
>>>>>> { "AMDI1015", (unsigned long)&acp3x_1015},
>>>>>> + { "AMDP1015", (unsigned long)&acp3x_1015p},
>>>
>>>>> This isn't a valid ACPI ID. AMDP does not exist in
>>>
>>> ...
>>>
>>>>> There was a similar issue with Intel platforms using this part, we had
>>>>> to use a different HID.
>>>
>>>> Is it okay if i use "AMDI1016" for ALC1015P?
>>>
>>> That's valid, though obviously you might regret that later on if someone
>>> releases a CODEC with a 1016 name (equally well ACPI being what it is
>>> there's no good options for naming).
>>
>> wish granted, the 1016 already exists :-)
>> you may want to align with what we did for Intel and use the same HID:
>> RTL1015
>
> As per RTK team inputs, "RTL1015" ACPI HID is in use for RT1015p codec
> driver.
> RTK team suggested us to use "RTL1015A" as ACPI HID.
> Let us know, if we can use "RTL1015A" as an ACPI HID?
Not if you want to be compliant. The part ID remains pegged to 4 hex
digits, no matter what the vendor ID representation is.
The only solution I can suggest is using the PCI ID 0x1002, ie.
AMDI1015 -> AMD platform with RT1015
10021015 -> AMD platform with RT1015p
Note that it's not only ACPI's fault, other standards also only allow
for 16 bits for part IDs, we'd have the same issue with SoundWire.
next prev parent reply other threads:[~2021-04-05 19:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 9:13 [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver Vijendar Mukunda
2021-03-30 14:22 ` Pierre-Louis Bossart
2021-03-30 15:42 ` Mukunda,Vijendar
2021-03-30 15:35 ` Mark Brown
2021-03-30 16:27 ` Pierre-Louis Bossart
2021-04-05 11:26 ` Mukunda,Vijendar
2021-04-05 16:24 ` Pierre-Louis Bossart [this message]
2021-04-06 18:20 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b330ca5e-1162-29c9-d846-fbfbd9db638f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kent_chen@realtek.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).