From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
"Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, shumingf@realtek.com,
flove@realtek.com, kent_chen@realtek.com, jack.yu@realtek.com,
Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
Arnd Bergmann <arnd@arndb.de>,
Akshu Agrawal <akshu.agrawal@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Tzung-Bi Shih <tzungbi@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver
Date: Tue, 30 Mar 2021 11:27:33 -0500 [thread overview]
Message-ID: <cd0d87e0-caa5-b671-9c91-1c5f35c2f017@linux.intel.com> (raw)
In-Reply-To: <20210330153534.GF4976@sirena.org.uk>
On 3/30/21 10:35 AM, Mark Brown wrote:
> On Tue, Mar 30, 2021 at 09:12:11PM +0530, Mukunda,Vijendar wrote:
>> On 3/30/21 7:52 PM, Pierre-Louis Bossart wrote:
>
>>>> static const struct acpi_device_id acp3x_audio_acpi_match[] = {
>>>> { "AMDI5682", (unsigned long)&acp3x_5682},
>>>> { "AMDI1015", (unsigned long)&acp3x_1015},
>>>> + { "AMDP1015", (unsigned long)&acp3x_1015p},
>
>>> This isn't a valid ACPI ID. AMDP does not exist in
>
> ...
>
>>> There was a similar issue with Intel platforms using this part, we had
>>> to use a different HID.
>
>> Is it okay if i use "AMDI1016" for ALC1015P?
>
> That's valid, though obviously you might regret that later on if someone
> releases a CODEC with a 1016 name (equally well ACPI being what it is
> there's no good options for naming).
wish granted, the 1016 already exists :-)
you may want to align with what we did for Intel and use the same HID:
RTL1015
next prev parent reply other threads:[~2021-03-30 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 9:13 [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver Vijendar Mukunda
2021-03-30 14:22 ` Pierre-Louis Bossart
2021-03-30 15:42 ` Mukunda,Vijendar
2021-03-30 15:35 ` Mark Brown
2021-03-30 16:27 ` Pierre-Louis Bossart [this message]
2021-04-05 11:26 ` Mukunda,Vijendar
2021-04-05 16:24 ` Pierre-Louis Bossart
2021-04-06 18:20 ` Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0d87e0-caa5-b671-9c91-1c5f35c2f017@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kent_chen@realtek.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
--cc=vijendar.mukunda@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).