From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
linux-clk@vger.kernel.org
Cc: linux-mips@vger.kernel.org, tsbogend@alpha.franken.de,
john@phrozen.org, linux-kernel@vger.kernel.org,
p.zabel@pengutronix.de, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation
Date: Tue, 21 Mar 2023 07:34:14 +0100 [thread overview]
Message-ID: <b3365947-5567-2fd7-1bb7-34052c40e5f6@linaro.org> (raw)
In-Reply-To: <6a8989c5-f12d-a4cb-9b20-29049dee016e@arinc9.com>
On 20/03/2023 19:23, Arınç ÜNAL wrote:
> On 20.03.2023 21:11, Krzysztof Kozlowski wrote:
>> On 20/03/2023 19:07, Arınç ÜNAL wrote:
>>> On 20.03.2023 21:01, Krzysztof Kozlowski wrote:
>>>> On 20/03/2023 17:18, Sergio Paracuellos wrote:
>>>>> +properties:
>>>>> + compatible:
>>>>> + items:
>>>>> + - enum:
>>>>> + - ralink,rt2880-sysc
>>>>> + - ralink,rt3050-sysc
>>>>> + - ralink,rt3052-sysc
>>>>> + - ralink,rt3352-sysc
>>>>> + - ralink,rt3883-sysc
>>>>> + - ralink,rt5350-sysc
>>>>> + - ralink,mt7620-sysc
>>>>> + - ralink,mt7620a-sysc
>>>>> + - ralink,mt7628-sysc
>>>>> + - ralink,mt7688-sysc
>>>>
>>>> One more comment - this and maybe other compatibles - have wrong vendor
>>>> prefix. This is mediatek, not ralink.
>>>
>>> This platform was acquired from Ralink by MediaTek. I couldn't change
>>> some existing ralink compatible strings to mediatek as Rob explained on
>>> my pinctrl patch series that we don't do that. The compatible strings on
>>> this patch series here are new but I'd rather keep the compatible
>>> strings ralink to keep things consistent.
>>
>> The comment that you cannot change existing compatibles does not apply
>> to these, because these are new. However indeed some SoCs have already
>> compatibles with ralink, so it's fine for these. mt7620 and mt7628 are
>> already used with mediatek, so these should be rather corrected to new
>> prefix.
>
> If you're talking about the pinctrl schemas for MT7620 and MT7628, it's
> just the name of the yaml files that have mediatek. The compatible
> string is still ralink so it should be kept ralink here as well.
No, I am talking about compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-21 6:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 16:18 [PATCH 00/10] mips: ralink: add complete clock and reset driver for mtmips SoCs Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 01/10] dt: bindings: clock: add mtmips SoCs clock device tree binding documentation Sergio Paracuellos
2023-03-20 16:36 ` Krzysztof Kozlowski
2023-03-20 16:43 ` Arınç ÜNAL
2023-03-20 16:50 ` Krzysztof Kozlowski
2023-03-20 17:24 ` Sergio Paracuellos
2023-03-20 17:36 ` Krzysztof Kozlowski
2023-03-20 17:57 ` Arınç ÜNAL
2023-03-20 18:02 ` Krzysztof Kozlowski
2023-03-20 18:09 ` Arınç ÜNAL
2023-03-20 18:15 ` Krzysztof Kozlowski
2023-03-21 4:34 ` Sergio Paracuellos
2023-03-21 6:32 ` Krzysztof Kozlowski
2023-03-21 6:38 ` Arınç ÜNAL
2023-03-21 6:43 ` Krzysztof Kozlowski
2023-03-21 6:56 ` Sergio Paracuellos
2023-03-21 7:19 ` Krzysztof Kozlowski
2023-03-21 7:27 ` Sergio Paracuellos
2023-03-21 7:39 ` Arınç ÜNAL
2023-03-21 8:04 ` Krzysztof Kozlowski
2023-03-21 8:24 ` Arınç ÜNAL
2023-03-21 8:27 ` Krzysztof Kozlowski
2023-03-21 8:33 ` Arınç ÜNAL
2023-03-21 8:39 ` Krzysztof Kozlowski
2023-03-21 8:53 ` Arınç ÜNAL
2023-03-21 9:01 ` Krzysztof Kozlowski
2023-03-21 9:02 ` Arınç ÜNAL
2023-03-24 22:10 ` Rob Herring
2023-03-24 23:15 ` Arınç ÜNAL
2023-03-24 22:13 ` Rob Herring
2023-03-21 4:29 ` Sergio Paracuellos
2023-03-20 18:01 ` Krzysztof Kozlowski
2023-03-20 18:07 ` Arınç ÜNAL
2023-03-20 18:11 ` Krzysztof Kozlowski
2023-03-20 18:23 ` Arınç ÜNAL
2023-03-21 6:34 ` Krzysztof Kozlowski [this message]
2023-03-20 16:18 ` [PATCH 02/10] clk: ralink: add clock and reset driver for MTMIPS SoCs Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 03/10] mips: ralink: rt288x: remove clock related code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 04/10] mips: ralink: rt305x: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 05/10] mips: ralink: rt3883: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 06/10] mips: ralink: mt7620: " Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 07/10] mips: ralink: remove clock related function prototypes Sergio Paracuellos
2023-03-20 19:38 ` Stephen Boyd
2023-03-20 20:17 ` Sergio Paracuellos
2023-03-20 21:21 ` Stephen Boyd
2023-03-21 4:23 ` Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 08/10] mips: ralink: remove reset related code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 09/10] mips: ralink: get cpu rate from new driver code Sergio Paracuellos
2023-03-20 16:18 ` [PATCH 10/10] MAINTAINERS: add Mediatek MTMIPS Clock maintainer Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3365947-5567-2fd7-1bb7-34052c40e5f6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).