* [PATCH] mfd: cros_ec: Only register a positive IRQ number
@ 2019-03-21 21:03 egranata
2019-03-22 19:44 ` Enric Balletbo i Serra
2019-03-22 21:15 ` Benson Leung
0 siblings, 2 replies; 3+ messages in thread
From: egranata @ 2019-03-21 21:03 UTC (permalink / raw)
To: lee.jones, bleung, enric.balletbo, groeck, linux-kernel
Cc: gwendal, amstan, egranata
From: Enrico Granata <egranata@chromium.org>
Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.
Signed-off-by: Enrico Granata <egranata@chromium.org>
---
drivers/mfd/cros_ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index 6acfe036d5222..ff8984a2b8c21 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
return err;
}
- if (ec_dev->irq) {
+ if (ec_dev->irq > 0) {
err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"chromeos-ec", ec_dev);
--
2.21.0.225.g810b269d1ac-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: cros_ec: Only register a positive IRQ number
2019-03-21 21:03 [PATCH] mfd: cros_ec: Only register a positive IRQ number egranata
@ 2019-03-22 19:44 ` Enric Balletbo i Serra
2019-03-22 21:15 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2019-03-22 19:44 UTC (permalink / raw)
To: egranata, lee.jones, bleung, groeck, linux-kernel; +Cc: gwendal, amstan
Hi Enrico,
On 21/3/19 22:03, egranata@chromium.org wrote:
> From: Enrico Granata <egranata@chromium.org>
>
> Add a layer of sanity checking to cros_ec_register against attempting to
> register IRQ values that are not strictly greater than 0.
>
> Signed-off-by: Enrico Granata <egranata@chromium.org>
> ---
> drivers/mfd/cros_ec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 6acfe036d5222..ff8984a2b8c21 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
> return err;
> }
>
> - if (ec_dev->irq) {
> + if (ec_dev->irq > 0) {
> err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
> ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> "chromeos-ec", ec_dev);
>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks,
Enric
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: cros_ec: Only register a positive IRQ number
2019-03-21 21:03 [PATCH] mfd: cros_ec: Only register a positive IRQ number egranata
2019-03-22 19:44 ` Enric Balletbo i Serra
@ 2019-03-22 21:15 ` Benson Leung
1 sibling, 0 replies; 3+ messages in thread
From: Benson Leung @ 2019-03-22 21:15 UTC (permalink / raw)
To: egranata
Cc: lee.jones, bleung, enric.balletbo, groeck, linux-kernel, gwendal, amstan
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
Hi Enrico,
On Thu, Mar 21, 2019 at 02:03:47PM -0700, egranata@chromium.org wrote:
> From: Enrico Granata <egranata@chromium.org>
>
> Add a layer of sanity checking to cros_ec_register against attempting to
> register IRQ values that are not strictly greater than 0.
>
> Signed-off-by: Enrico Granata <egranata@chromium.org>
Acked-By: Benson Leung <bleung@chromium.org>
> ---
> drivers/mfd/cros_ec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> index 6acfe036d5222..ff8984a2b8c21 100644
> --- a/drivers/mfd/cros_ec.c
> +++ b/drivers/mfd/cros_ec.c
> @@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
> return err;
> }
>
> - if (ec_dev->irq) {
> + if (ec_dev->irq > 0) {
> err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
> ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> "chromeos-ec", ec_dev);
> --
> 2.21.0.225.g810b269d1ac-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-22 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 21:03 [PATCH] mfd: cros_ec: Only register a positive IRQ number egranata
2019-03-22 19:44 ` Enric Balletbo i Serra
2019-03-22 21:15 ` Benson Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).