* [PATCH] usb: gadget: fix langid kernel-doc warning in usbstring.c
@ 2020-06-29 3:08 Randy Dunlap
2020-06-29 23:37 ` Tao Ren
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-06-29 3:08 UTC (permalink / raw)
To: LKML, USB list, Greg Kroah-Hartman, Tao Ren, Felipe Balbi
From: Randy Dunlap <rdunlap@infradead.org>
Fix spelling of the 'langid' function argument in the kernel-doc
notation to quieten a kernel-doc warning.
../drivers/usb/gadget/usbstring.c:77: warning: Function parameter or member 'langid' not described in 'usb_validate_langid'
../drivers/usb/gadget/usbstring.c:77: warning: Excess function parameter 'lang' description in 'usb_validate_langid'
Fixes: 17309a6a4356 ("usb: gadget: add "usb_validate_langid" function")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Tao Ren <rentao.bupt@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>
---
drivers/usb/gadget/usbstring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20200626.orig/drivers/usb/gadget/usbstring.c
+++ linux-next-20200626/drivers/usb/gadget/usbstring.c
@@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string)
/**
* usb_validate_langid - validate usb language identifiers
- * @lang: usb language identifier
+ * @langid: usb language identifier
*
* Returns true for valid language identifier, otherwise false.
*/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: fix langid kernel-doc warning in usbstring.c
2020-06-29 3:08 [PATCH] usb: gadget: fix langid kernel-doc warning in usbstring.c Randy Dunlap
@ 2020-06-29 23:37 ` Tao Ren
0 siblings, 0 replies; 2+ messages in thread
From: Tao Ren @ 2020-06-29 23:37 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, USB list, Greg Kroah-Hartman, Felipe Balbi
On Sun, Jun 28, 2020 at 08:08:03PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix spelling of the 'langid' function argument in the kernel-doc
> notation to quieten a kernel-doc warning.
>
> ../drivers/usb/gadget/usbstring.c:77: warning: Function parameter or member 'langid' not described in 'usb_validate_langid'
> ../drivers/usb/gadget/usbstring.c:77: warning: Excess function parameter 'lang' description in 'usb_validate_langid'
>
> Fixes: 17309a6a4356 ("usb: gadget: add "usb_validate_langid" function")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Tao Ren <rentao.bupt@gmail.com>
> Cc: Felipe Balbi <balbi@kernel.org>
Thanks for the fix, Randy!
Reviewed-by: Tao Ren <rentao.bupt@gmail.com>
> ---
> drivers/usb/gadget/usbstring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200626.orig/drivers/usb/gadget/usbstring.c
> +++ linux-next-20200626/drivers/usb/gadget/usbstring.c
> @@ -68,7 +68,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_get_string)
>
> /**
> * usb_validate_langid - validate usb language identifiers
> - * @lang: usb language identifier
> + * @langid: usb language identifier
> *
> * Returns true for valid language identifier, otherwise false.
> */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-29 23:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 3:08 [PATCH] usb: gadget: fix langid kernel-doc warning in usbstring.c Randy Dunlap
2020-06-29 23:37 ` Tao Ren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).