From: Luis Oliveira <Luis.Oliveira@synopsys.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Luis Oliveira <Luis.Oliveira@synopsys.com>, <wsa@the-dreams.de>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<andriy.shevchenko@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <Ramiro.Oliveira@synopsys.com>, <Joao.Pinto@synopsys.com>,
<CARLOS.PALMINHA@synopsys.com>
Subject: Re: [PATCH v8 5/6] i2c: designware: add SLAVE mode functions
Date: Thu, 20 Apr 2017 15:17:08 +0100 [thread overview]
Message-ID: <b523039c-0120-2861-d9a8-4a8288ffe527@synopsys.com> (raw)
In-Reply-To: <47b60352-183b-0cf6-b8a6-7aea2fd2d111@linux.intel.com>
On 20-Apr-17 13:50, Jarkko Nikula wrote:
> On 04/12/2017 07:47 PM, Luis Oliveira wrote:
>> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
>> - Slave functions added to core library file
>> - Slave abort sources added to common source file
>> - New driver: i2c-designware-slave added
>> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>> when supported by the architecture.
>>
>> All the SLAVE flow is added but it is not enabled via platform
>> driver.
>>
>> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
>> ---
>> v7-v8
>> - no changes
>>
>> drivers/i2c/busses/Kconfig | 14 +-
>> drivers/i2c/busses/Makefile | 1 +
>> drivers/i2c/busses/i2c-designware-common.c | 6 +
>> drivers/i2c/busses/i2c-designware-core.h | 2 +
>> drivers/i2c/busses/i2c-designware-slave.c | 403 +++++++++++++++++++++++++++++
>> 5 files changed, 425 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/i2c/busses/i2c-designware-slave.c
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 144cbadc7c72..84efa57f90b3 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -474,11 +474,23 @@ config I2C_DESIGNWARE_PLATFORM
>> depends on (ACPI && COMMON_CLK) || !ACPI
>> help
>> If you say yes to this option, support will be included for the
>> - Synopsys DesignWare I2C adapter. Only master mode is supported.
>> + Synopsys DesignWare I2C adapter.
>>
>> This driver can also be built as a module. If so, the module
>> will be called i2c-designware-platform.
>>
>> +config I2C_DESIGNWARE_SLAVE
>> + bool "Synopsys DesignWare Slave"
>> + select I2C_SLAVE
>> + select I2C_SLAVE_EEPROM
>
> I didn't notice this before - is there reason to select I2C_SLAVE_EEPROM?
>
Yeah, this is in the wrong place. I need it to test it, but it shouldn't be
here. I will remove it.
next prev parent reply other threads:[~2017-04-20 14:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 16:47 [PATCH v8 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-04-20 12:49 ` Jarkko Nikula
2017-04-12 16:47 ` [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-04-20 12:49 ` Jarkko Nikula
2017-04-12 16:47 ` [PATCH v8 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-04-20 12:50 ` Jarkko Nikula
2017-04-20 14:17 ` Luis Oliveira [this message]
2017-04-12 16:47 ` [PATCH v8 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-04-21 11:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b523039c-0120-2861-d9a8-4a8288ffe527@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).