From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions
Date: Thu, 20 Apr 2017 15:49:12 +0300 [thread overview]
Message-ID: <fe61a6b8-fd6e-0f90-be31-852b252ddf33@linux.intel.com> (raw)
In-Reply-To: <d04556720066de26b6c7f979d0a1ab9bdf36e8fe.1492014220.git.lolivei@synopsys.com>
On 04/12/2017 07:47 PM, Luis Oliveira wrote:
> - Definitions were added to core library
> - A example was added to designware-core.txt Documentation that shows
> how the slave can be setup using DTS
>
> SLAVE related definitions were added to the core of the controller.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> v7-v8
> - no changes
...
> +#define DW_IC_RX_ABRT_SLAVE_RD_INTX (1UL << ABRT_SLAVE_RD_INTX)
> +#define DW_IC_RX_ABRT_SLAVE_ARBLOST (1UL << ABRT_SLAVE_ARBLOST)
> +#define DW_IC_RX_ABRT_SLAVE_FLUSH_TXFIFO (1UL << ABRT_SLAVE_FLUSH_TXFIFO)
>
> #define DW_IC_TX_ABRT_NOACK (DW_IC_TX_ABRT_7B_ADDR_NOACK | \
> DW_IC_TX_ABRT_10ADDR1_NOACK | \
> @@ -212,6 +237,7 @@ struct dw_i2c_dev {
> struct completion cmd_complete;
> struct clk *clk;
> struct reset_control *rst;
> + struct i2c_client *slave;
> u32 (*get_clk_rate_khz) (struct dw_i2c_dev *dev);
> struct dw_pci_controller *controller;
> int cmd_err;
> @@ -231,6 +257,7 @@ struct dw_i2c_dev {
> struct i2c_adapter adapter;
> u32 functionality;
> u32 master_cfg;
> + u32 slave_cfg;
> unsigned int tx_fifo_depth;
> unsigned int rx_fifo_depth;
> int rx_outstanding;
You forgot to add comments here.
--
Jarkko
next prev parent reply other threads:[~2017-04-20 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 16:47 [PATCH v8 0/6] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 1/6] i2c: designware: Cleaning and comment style fixes Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 2/6] i2c: designware: refactoring of the i2c-designware Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 3/6] i2c: designware: MASTER mode as separated driver Luis Oliveira
2017-04-20 12:49 ` Jarkko Nikula
2017-04-12 16:47 ` [PATCH v8 4/6] i2c: designware: introducing I2C_SLAVE definitions Luis Oliveira
2017-04-20 12:49 ` Jarkko Nikula [this message]
2017-04-12 16:47 ` [PATCH v8 5/6] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-04-20 12:50 ` Jarkko Nikula
2017-04-20 14:17 ` Luis Oliveira
2017-04-12 16:47 ` [PATCH v8 6/6] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-04-21 11:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe61a6b8-fd6e-0f90-be31-852b252ddf33@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).