From: "Noralf Trønnes" <noralf@tronnes.org>
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: sam@ravnborg.org, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v3 5/5] drm/cirrus: rewrite and modernize driver.
Date: Fri, 5 Apr 2019 16:43:04 +0200 [thread overview]
Message-ID: <b52ffab7-bc9d-9ce1-4c46-d6fd9b9aefe9@tronnes.org> (raw)
In-Reply-To: <20190405095219.9231-6-kraxel@redhat.com>
Den 05.04.2019 11.52, skrev Gerd Hoffmann:
> Time to kill some bad sample code people are copying from ;)
>
> This is a complete rewrite of the cirrus driver. The cirrus_mode_set()
> function is pretty much the only function which is carried over largely
> unmodified. Everything else is upside down.
>
> It is a single monster patch. But given that it does some pretty
> fundamental changes to the drivers workflow and also reduces the code
> size by roughly 70% I think it'll still be alot easier to review than a
> longish baby-step patch series.
>
> Changes summary:
> - Given the small amout of video memory (4 MB) the cirrus device has
> the rewritten driver doesn't try to manage buffers there. Instead
> it will blit (memcpy) the active framebuffer to video memory.
> - All gem objects are stored in main memory and are manged using the
> new shmem helpers. ttm is out.
> - It supports RG16, RG24 and XR24 formats. XR24 gets converted to RG24
> or RG16 at blit time if needed, to avoid the pitch becoming larger
> than what the cirrus hardware can handle.
> - The simple display pipeline is used.
> - The generic fbdev emulation is used.
> - It's a atomic driver now.
> - It runs wayland.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
Acked-by: Noralf Trønnes <noralf@tronnes.org>
prev parent reply other threads:[~2019-04-05 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190405095219.9231-1-kraxel@redhat.com>
2019-04-05 9:52 ` [PATCH v3 1/5] drm: move tinydrm format conversion helpers to new drm_format_helper.c Gerd Hoffmann
2019-04-05 13:46 ` Noralf Trønnes
2019-04-15 9:31 ` Daniel Vetter
2019-04-05 9:52 ` [PATCH v3 2/5] drm: add drm_fb_memcpy_dstclip() helper Gerd Hoffmann
2019-04-05 13:51 ` Noralf Trønnes
2019-04-05 9:52 ` [PATCH v3 3/5] drm: add drm_fb_xrgb8888_to_rgb565_dstclip() Gerd Hoffmann
2019-04-05 13:57 ` Noralf Trønnes
2019-04-05 9:52 ` [PATCH v3 4/5] drm: add drm_fb_xrgb8888_to_rgb888_dstclip() Gerd Hoffmann
2019-04-05 13:59 ` Noralf Trønnes
2019-04-05 9:52 ` [PATCH v3 5/5] drm/cirrus: rewrite and modernize driver Gerd Hoffmann
2019-04-05 14:43 ` Noralf Trønnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52ffab7-bc9d-9ce1-4c46-d6fd9b9aefe9@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).