linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: r8188eu: remove some unused enums
@ 2022-09-08  7:28 Michael Straube
  2022-09-08 19:15 ` Philipp Hortmann
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Straube @ 2022-09-08  7:28 UTC (permalink / raw)
  To: gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel, Michael Straube

Remove some unused enums to clean up the driver code.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
---
 drivers/staging/r8188eu/include/rtl8188e_xmit.h |  6 ------
 drivers/staging/r8188eu/include/rtw_mlme.h      | 11 -----------
 drivers/staging/r8188eu/include/wlan_bssdef.h   |  4 ----
 3 files changed, 21 deletions(-)

diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
index c69fed23ded9..6db7fabebea9 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
@@ -83,12 +83,6 @@
 /* OFFSET 20 */
 #define	RTY_LMT_EN		BIT(17)
 
-enum TXDESC_SC {
-	SC_DONT_CARE = 0x00,
-	SC_UPPER = 0x01,
-	SC_LOWER = 0x02,
-	SC_DUPLICATE = 0x03
-};
 /* OFFSET 20 */
 #define SGI			BIT(6)
 #define USB_TXAGG_NUM_SHT	24
diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h
index 5dc2fe74b7b7..a959e2100c3f 100644
--- a/drivers/staging/r8188eu/include/rtw_mlme.h
+++ b/drivers/staging/r8188eu/include/rtw_mlme.h
@@ -63,17 +63,6 @@ enum rt_scan_type {
 	SCAN_MIX,
 };
 
-enum SCAN_RESULT_TYPE {
-	SCAN_RESULT_P2P_ONLY = 0,	/* Will return all the P2P devices. */
-	SCAN_RESULT_ALL = 1,		/* Will return all the scanned device,
-					 * include AP. */
-	SCAN_RESULT_WFD_TYPE = 2	/* Will just return the correct WFD
-					 * device. */
-					/* If this device is Miracast sink
-					 * device, it will just return all the
-					 * Miracast source devices. */
-};
-
 /*
 there are several "locks" in mlme_priv,
 since mlme_priv is a shared resource between many threads,
diff --git a/drivers/staging/r8188eu/include/wlan_bssdef.h b/drivers/staging/r8188eu/include/wlan_bssdef.h
index 9d1c9e763287..81bda91a4136 100644
--- a/drivers/staging/r8188eu/include/wlan_bssdef.h
+++ b/drivers/staging/r8188eu/include/wlan_bssdef.h
@@ -133,10 +133,6 @@ struct ndis_802_11_assoc_info {
 	u32  OffsetResponseIEs;
 };
 
-enum ndis_802_11_reload_def {
-	Ndis802_11ReloadWEPKeys
-};
-
 /*  Key mapping keys require a BSSID */
 struct ndis_802_11_key {
 	u32           Length;             /*  Length of this structure */
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: r8188eu: remove some unused enums
  2022-09-08  7:28 [PATCH] staging: r8188eu: remove some unused enums Michael Straube
@ 2022-09-08 19:15 ` Philipp Hortmann
  0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2022-09-08 19:15 UTC (permalink / raw)
  To: Michael Straube, gregkh; +Cc: Larry.Finger, phil, linux-staging, linux-kernel

On 9/8/22 09:28, Michael Straube wrote:
> Remove some unused enums to clean up the driver code.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>   drivers/staging/r8188eu/include/rtl8188e_xmit.h |  6 ------
>   drivers/staging/r8188eu/include/rtw_mlme.h      | 11 -----------
>   drivers/staging/r8188eu/include/wlan_bssdef.h   |  4 ----
>   3 files changed, 21 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_xmit.h b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> index c69fed23ded9..6db7fabebea9 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_xmit.h
> @@ -83,12 +83,6 @@
>   /* OFFSET 20 */
>   #define	RTY_LMT_EN		BIT(17)
>   
> -enum TXDESC_SC {
> -	SC_DONT_CARE = 0x00,
> -	SC_UPPER = 0x01,
> -	SC_LOWER = 0x02,
> -	SC_DUPLICATE = 0x03
> -};
>   /* OFFSET 20 */
>   #define SGI			BIT(6)
>   #define USB_TXAGG_NUM_SHT	24
> diff --git a/drivers/staging/r8188eu/include/rtw_mlme.h b/drivers/staging/r8188eu/include/rtw_mlme.h
> index 5dc2fe74b7b7..a959e2100c3f 100644
> --- a/drivers/staging/r8188eu/include/rtw_mlme.h
> +++ b/drivers/staging/r8188eu/include/rtw_mlme.h
> @@ -63,17 +63,6 @@ enum rt_scan_type {
>   	SCAN_MIX,
>   };
>   
> -enum SCAN_RESULT_TYPE {
> -	SCAN_RESULT_P2P_ONLY = 0,	/* Will return all the P2P devices. */
> -	SCAN_RESULT_ALL = 1,		/* Will return all the scanned device,
> -					 * include AP. */
> -	SCAN_RESULT_WFD_TYPE = 2	/* Will just return the correct WFD
> -					 * device. */
> -					/* If this device is Miracast sink
> -					 * device, it will just return all the
> -					 * Miracast source devices. */
> -};
> -
>   /*
>   there are several "locks" in mlme_priv,
>   since mlme_priv is a shared resource between many threads,
> diff --git a/drivers/staging/r8188eu/include/wlan_bssdef.h b/drivers/staging/r8188eu/include/wlan_bssdef.h
> index 9d1c9e763287..81bda91a4136 100644
> --- a/drivers/staging/r8188eu/include/wlan_bssdef.h
> +++ b/drivers/staging/r8188eu/include/wlan_bssdef.h
> @@ -133,10 +133,6 @@ struct ndis_802_11_assoc_info {
>   	u32  OffsetResponseIEs;
>   };
>   
> -enum ndis_802_11_reload_def {
> -	Ndis802_11ReloadWEPKeys
> -};
> -
>   /*  Key mapping keys require a BSSID */
>   struct ndis_802_11_key {
>   	u32           Length;             /*  Length of this structure */

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-08 19:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-08  7:28 [PATCH] staging: r8188eu: remove some unused enums Michael Straube
2022-09-08 19:15 ` Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).