* [PATCH] ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs
@ 2022-01-27 12:19 Corentin Labbe
2022-01-27 13:17 ` Andrei Kartashev
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2022-01-27 12:19 UTC (permalink / raw)
To: a.kartashev, andrew, joel, robh+dt
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Corentin Labbe
fttmr010,pwm-outputs is not handled by its timer driver, so this
property is useless.
Fixes: 67ac01d03862 ("ARM: dts: aspeed: add device tree for YADRO VEGMAN BMC")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
arch/arm/boot/dts/aspeed-bmc-vegman.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi b/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
index 1a5b25b2ea29..43af63910571 100644
--- a/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
+++ b/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
@@ -166,7 +166,6 @@ &sdhci1 {
};
&timer {
- fttmr010,pwm-outputs = <5>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_timer5_default>;
#pwm-cells = <3>;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs
2022-01-27 12:19 [PATCH] ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs Corentin Labbe
@ 2022-01-27 13:17 ` Andrei Kartashev
0 siblings, 0 replies; 2+ messages in thread
From: Andrei Kartashev @ 2022-01-27 13:17 UTC (permalink / raw)
To: Corentin Labbe, andrew, joel, robh+dt
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Hello,
Good catch! I miss this on porting DTS from local tree, based on
Intel's one. Since there is no such driver in upstream kernel
(https://github.com/Intel-BMC/linux/blob/dev-5.15-intel/drivers/pwm/pwm-fttmr010.c
), both this and beeper sections could be completely removed.
I will send another patch with cleanup.
Thank you.
On Thu, 2022-01-27 at 12:19 +0000, Corentin Labbe wrote:
> fttmr010,pwm-outputs is not handled by its timer driver, so this
> property is useless.
> Fixes: 67ac01d03862 ("ARM: dts: aspeed: add device tree for YADRO
> VEGMAN BMC")
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-vegman.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
> b/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
> index 1a5b25b2ea29..43af63910571 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
> +++ b/arch/arm/boot/dts/aspeed-bmc-vegman.dtsi
> @@ -166,7 +166,6 @@ &sdhci1 {
> };
>
> &timer {
> - fttmr010,pwm-outputs = <5>;
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_timer5_default>;
> #pwm-cells = <3>;
--
Best regards,
Andrei Kartashev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-27 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 12:19 [PATCH] ARM: dts: aspeed: remove unhandled fttmr010,pwm-outputs Corentin Labbe
2022-01-27 13:17 ` Andrei Kartashev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).