From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
"Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Jiri Kosina <jkosina@suse.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Chris von Recklinghausen <crecklin@redhat.com>,
Jason Baron <jbaron@akamai.com>, Scott Wood <swood@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Clark Williams <williams@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH V5 4/7] jump_label: Sort entries of the same key by the code
Date: Mon, 15 Apr 2019 13:33:49 +0200 [thread overview]
Message-ID: <b6e3350b-8d27-bac6-f3b3-2d98638bada1@redhat.com> (raw)
In-Reply-To: <20190415105529.GJ11158@hirez.programming.kicks-ass.net>
On 4/15/19 12:55 PM, Peter Zijlstra wrote:
> On Mon, Apr 01, 2019 at 10:58:16AM +0200, Daniel Bristot de Oliveira wrote:
>> In the batching mode, entries with the same key should also be sorted by the
>> code, enabling a bsearch() of a code/addr when updating a key.
>
> Might be good to explain *why*.
>
> We can see what the code does, explaining why we do things is what we
> have Changelogs for.
Ack! I will explain why,
>> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Borislav Petkov <bp@alien8.de>
>> Cc: "H. Peter Anvin" <hpa@zytor.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Masami Hiramatsu <mhiramat@kernel.org>
>> Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>> Cc: Jiri Kosina <jkosina@suse.cz>
>> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
>> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
>> Cc: Chris von Recklinghausen <crecklin@redhat.com>
>> Cc: Jason Baron <jbaron@akamai.com>
>> Cc: Scott Wood <swood@redhat.com>
>> Cc: Marcelo Tosatti <mtosatti@redhat.com>
>> Cc: Clark Williams <williams@redhat.com>
>> Cc: x86@kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> kernel/jump_label.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/kernel/jump_label.c b/kernel/jump_label.c
>> index e666a4d6642a..8b7bfbba4cef 100644
>> --- a/kernel/jump_label.c
>> +++ b/kernel/jump_label.c
>> @@ -36,12 +36,28 @@ static int jump_label_cmp(const void *a, const void *b)
>> const struct jump_entry *jea = a;
>> const struct jump_entry *jeb = b;
>>
>> + /*
>> + * Entrires are sorted by key.
>> + */
and this the typo above (just noticed),
>> if (jump_entry_key(jea) < jump_entry_key(jeb))
>> return -1;
>>
>> if (jump_entry_key(jea) > jump_entry_key(jeb))
>> return 1;
>>
>> +#ifdef HAVE_JUMP_LABEL_BATCH
>> + /*
>> + * In the batching mode, entries should also be sorted by the code
>> + * inside the already sorted list of entries, enabling a bsearch in
>> + * the vector.
>> + */
>> + if (jump_entry_code(jea) < jump_entry_code(jeb))
>> + return -1;
>> +
>> + if (jump_entry_code(jea) > jump_entry_code(jeb))
>> + return 1;
>> +#endif
>> +
>> return 0;
>> }
>
> The secondary sort order doesn't hurt, so we could leave the #ifdef out,
> not sure.
and remove the #ifdef, unless someone else things we need to keep it.
-- Daniel
next prev parent reply other threads:[~2019-04-15 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 8:58 [PATCH V5 0/7] x86/jump_label: Bound IPIs sent when updating a static key Daniel Bristot de Oliveira
2019-04-01 8:58 ` [PATCH V5 1/7] jump_label: Add for_each_label_entry helper Daniel Bristot de Oliveira
2019-04-15 10:51 ` Peter Zijlstra
2019-04-15 11:29 ` Daniel Bristot de Oliveira
2019-04-01 8:58 ` [PATCH V5 2/7] jump_label: Add a jump_label_can_update() helper Daniel Bristot de Oliveira
2019-04-01 8:58 ` [PATCH V5 3/7] x86/jump_label: Add a __jump_label_set_jump_code() helper Daniel Bristot de Oliveira
2019-04-01 8:58 ` [PATCH V5 4/7] jump_label: Sort entries of the same key by the code Daniel Bristot de Oliveira
2019-04-15 10:55 ` Peter Zijlstra
2019-04-15 11:33 ` Daniel Bristot de Oliveira [this message]
2019-04-01 8:58 ` [PATCH V5 5/7] x86/alternative: Batch of patch operations Daniel Bristot de Oliveira
2019-04-15 11:35 ` Peter Zijlstra
2019-04-01 8:58 ` [PATCH V5 6/7] jump_label: Batch updates if arch supports it Daniel Bristot de Oliveira
2019-04-15 11:50 ` Peter Zijlstra
2019-04-01 8:58 ` [PATCH V5 7/7] x86/jump_label: Batch jump label updates Daniel Bristot de Oliveira
2019-04-15 11:54 ` Peter Zijlstra
2019-04-15 12:15 ` Daniel Bristot de Oliveira
2019-05-02 20:18 ` Daniel Bristot de Oliveira
2019-04-15 9:52 ` [PATCH V5 0/7] x86/jump_label: Bound IPIs sent when updating a static key Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e3350b-8d27-bac6-f3b3-2d98638bada1@redhat.com \
--to=bristot@redhat.com \
--cc=bp@alien8.de \
--cc=crecklin@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).