* [PATCH v2] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
@ 2017-09-06 13:56 Keerthy
2017-09-08 5:05 ` Keerthy
0 siblings, 1 reply; 2+ messages in thread
From: Keerthy @ 2017-09-06 13:56 UTC (permalink / raw)
To: kishon, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci, j-keerthy
Add shutdown handler to cleanly turn off clocks.
Signed-off-by: Keerthy <j-keerthy@ti.com>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
---
Changes in v2:
* used a local dev pointer instead of dereferencing dev at multiple places.
* dra7xx_pcie_stop_link before disabling clks in the shutdown path.
drivers/pci/dwc/pci-dra7xx.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
index 0f9adf2..0d8307a 100644
--- a/drivers/pci/dwc/pci-dra7xx.c
+++ b/drivers/pci/dwc/pci-dra7xx.c
@@ -779,6 +779,22 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
return 0;
}
+void dra7xx_pcie_shutdown(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
+ int ret;
+
+ dra7xx_pcie_stop_link(dra7xx->pci);
+
+ ret = pm_runtime_put_sync(dev);
+ if (ret < 0)
+ dev_dbg(dev, "pm_runtime_put_sync failed\n");
+
+ pm_runtime_disable(dev);
+ dra7xx_pcie_disable_phy(dra7xx);
+}
+
static int dra7xx_pcie_resume_noirq(struct device *dev)
{
struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
@@ -807,5 +823,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
.suppress_bind_attrs = true,
.pm = &dra7xx_pcie_pm_ops,
},
+ .shutdown = dra7xx_pcie_shutdown,
};
builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks
2017-09-06 13:56 [PATCH v2] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks Keerthy
@ 2017-09-08 5:05 ` Keerthy
0 siblings, 0 replies; 2+ messages in thread
From: Keerthy @ 2017-09-08 5:05 UTC (permalink / raw)
To: kishon, bhelgaas; +Cc: t-kristo, linux-kernel, linux-omap, linux-pci
On Wednesday 06 September 2017 07:26 PM, Keerthy wrote:
> Add shutdown handler to cleanly turn off clocks.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>
> Changes in v2:
>
> * used a local dev pointer instead of dereferencing dev at multiple places.
> * dra7xx_pcie_stop_link before disabling clks in the shutdown path.
>
> drivers/pci/dwc/pci-dra7xx.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index 0f9adf2..0d8307a 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -779,6 +779,22 @@ static int dra7xx_pcie_suspend_noirq(struct device *dev)
> return 0;
> }
>
> +void dra7xx_pcie_shutdown(struct platform_device *pdev)
This is currently under #ifdef CONFIG_PM_SLEEP. I need to push this
function out of that. So i will post a v3.
> +{
> + struct device *dev = &pdev->dev;
> + struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> + int ret;
> +
> + dra7xx_pcie_stop_link(dra7xx->pci);
> +
> + ret = pm_runtime_put_sync(dev);
> + if (ret < 0)
> + dev_dbg(dev, "pm_runtime_put_sync failed\n");
> +
> + pm_runtime_disable(dev);
> + dra7xx_pcie_disable_phy(dra7xx);
> +}
> +
> static int dra7xx_pcie_resume_noirq(struct device *dev)
> {
> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
> @@ -807,5 +823,6 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
> .suppress_bind_attrs = true,
> .pm = &dra7xx_pcie_pm_ops,
> },
> + .shutdown = dra7xx_pcie_shutdown,
> };
> builtin_platform_driver_probe(dra7xx_pcie_driver, dra7xx_pcie_probe);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-08 5:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-06 13:56 [PATCH v2] pci: dwc: dra7xx: Add shutdown handler to cleanly turn off clocks Keerthy
2017-09-08 5:05 ` Keerthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).