* [PATCH] nvme: One function call less in nvme_update_disk_info()
@ 2019-07-05 19:15 Markus Elfring
2019-07-05 19:35 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-07-05 19:15 UTC (permalink / raw)
To: linux-nvme, Christoph Hellwig, Jens Axboe, Keith Busch, Sagi Grimberg
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 Jul 2019 21:08:12 +0200
Avoid an extra function call by using a ternary operator instead of
a conditional statement.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/nvme/host/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b2dd4e391f5c..73888195bdb2 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1650,10 +1650,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
nvme_config_discard(disk, ns);
nvme_config_write_zeroes(disk, ns);
- if (id->nsattr & (1 << 0))
- set_disk_ro(disk, true);
- else
- set_disk_ro(disk, false);
+ set_disk_ro(disk, id->nsattr & (1 << 0) ? true : false);
blk_mq_unfreeze_queue(disk->queue);
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme: One function call less in nvme_update_disk_info()
2019-07-05 19:15 [PATCH] nvme: One function call less in nvme_update_disk_info() Markus Elfring
@ 2019-07-05 19:35 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-07-05 19:35 UTC (permalink / raw)
To: Markus Elfring, linux-nvme, Christoph Hellwig, Keith Busch,
Sagi Grimberg
Cc: kernel-janitors, LKML
On 7/5/19 1:15 PM, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 5 Jul 2019 21:08:12 +0200
>
> Avoid an extra function call by using a ternary operator instead of
> a conditional statement.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/nvme/host/core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index b2dd4e391f5c..73888195bdb2 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1650,10 +1650,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
> nvme_config_discard(disk, ns);
> nvme_config_write_zeroes(disk, ns);
>
> - if (id->nsattr & (1 << 0))
> - set_disk_ro(disk, true);
> - else
> - set_disk_ro(disk, false);
> + set_disk_ro(disk, id->nsattr & (1 << 0) ? true : false);
Let's please not, the original is much more readable.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-05 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-05 19:15 [PATCH] nvme: One function call less in nvme_update_disk_info() Markus Elfring
2019-07-05 19:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).