* [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name
@ 2019-01-23 9:07 YueHaibing
2019-01-23 9:09 ` YueHaibing
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-01-23 9:07 UTC (permalink / raw)
To: robert.jarzmik, dwmw2, computersforpeace, bbrezillon,
marek.vasut, richard
Cc: linux-kernel, linux-mtd, YueHaibing
In case DOC_CHIPID_G3, mtd->name is not freed in err handling path,
which is alloced by kasprintf(). Fix this by using devm_kasprintf().
Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: use devm_kasprintf
---
drivers/mtd/devices/docg3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
index 4c94fc0..af824d3 100644
--- a/drivers/mtd/devices/docg3.c
+++ b/drivers/mtd/devices/docg3.c
@@ -1767,8 +1767,8 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
switch (chip_id) {
case DOC_CHIPID_G3:
- mtd->name = kasprintf(GFP_KERNEL, "docg3.%d",
- docg3->device_id);
+ mtd->name = devm_kasprintf(GFP_KERNEL, "docg3.%d",
+ docg3->device_id);
if (!mtd->name)
return -ENOMEM;
docg3->max_block = 2047;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name
2019-01-23 9:07 [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name YueHaibing
@ 2019-01-23 9:09 ` YueHaibing
0 siblings, 0 replies; 2+ messages in thread
From: YueHaibing @ 2019-01-23 9:09 UTC (permalink / raw)
To: robert.jarzmik, dwmw2, computersforpeace, bbrezillon,
marek.vasut, richard
Cc: linux-kernel, linux-mtd
Pls ignore this err patch.
On 2019/1/23 17:07, YueHaibing wrote:
> In case DOC_CHIPID_G3, mtd->name is not freed in err handling path,
> which is alloced by kasprintf(). Fix this by using devm_kasprintf().
>
> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: use devm_kasprintf
> ---
> drivers/mtd/devices/docg3.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> index 4c94fc0..af824d3 100644
> --- a/drivers/mtd/devices/docg3.c
> +++ b/drivers/mtd/devices/docg3.c
> @@ -1767,8 +1767,8 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd)
>
> switch (chip_id) {
> case DOC_CHIPID_G3:
> - mtd->name = kasprintf(GFP_KERNEL, "docg3.%d",
> - docg3->device_id);
> + mtd->name = devm_kasprintf(GFP_KERNEL, "docg3.%d",
> + docg3->device_id);
> if (!mtd->name)
> return -ENOMEM;
> docg3->max_block = 2047;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-23 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-23 9:07 [PATCH v2 -next] mtd: docg3: Fix a possible memory leak of mtd->name YueHaibing
2019-01-23 9:09 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).