* [PATCH 1/5] staging: rtl8192e: rename variable HTIOTActDetermineRaFunc
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
@ 2023-12-11 0:13 ` Gary Rookard
2023-12-11 0:13 ` [PATCH 2/5] staging: rtl8192e: rename variable HTResetIOTSetting Gary Rookard
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-12-11 0:13 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTIOTActDetermineRaFunc -> ht_iot_act_determine_ra_function
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 99626be899fd..e155a292f6b1 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -227,7 +227,7 @@ static u8 ht_iot_act_is_ccd_fsync(struct rtllib_device *ieee)
return retValue;
}
-static void HTIOTActDetermineRaFunc(struct rtllib_device *ieee, bool bPeerRx2ss)
+static void ht_iot_act_determine_ra_func(struct rtllib_device *ieee, bool bPeerRx2ss)
{
struct rt_hi_throughput *ht_info = ieee->ht_info;
@@ -536,7 +536,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee)
if (pPeerHTCap->MCS[0] == 0)
pPeerHTCap->MCS[0] = 0xff;
- HTIOTActDetermineRaFunc(ieee, ((pPeerHTCap->MCS[1]) != 0));
+ ht_iot_act_determine_ra_func(ieee, ((pPeerHTCap->MCS[1]) != 0));
HTFilterMCSRate(ieee, pPeerHTCap->MCS, ieee->dot11ht_oper_rate_set);
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/5] staging: rtl8192e: rename variable HTResetIOTSetting
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
2023-12-11 0:13 ` [PATCH 1/5] staging: rtl8192e: rename variable HTIOTActDetermineRaFunc Gary Rookard
@ 2023-12-11 0:13 ` Gary Rookard
2023-12-11 0:13 ` [PATCH 3/5] staging: rtl8192e: rename variable HTConstructCapabilityElement Gary Rookard
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-12-11 0:13 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTResetIOTSetting -> ht_reset_iot_setting
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index e155a292f6b1..2a3cb6434100 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -240,7 +240,7 @@ static void ht_iot_act_determine_ra_func(struct rtllib_device *ieee, bool bPeerR
ht_info->iot_ra_func |= HT_IOT_RAFUNC_TX_AMSDU;
}
-void HTResetIOTSetting(struct rt_hi_throughput *ht_info)
+void ht_reset_iot_setting(struct rt_hi_throughput *ht_info)
{
ht_info->iot_action = 0;
ht_info->iot_peer = HT_IOT_PEER_UNKNOWN;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 51dcea57a329..e8c795faf4f9 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1772,7 +1772,7 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *pMCSRateSet,
extern u8 MCS_FILTER_ALL[];
extern u16 MCS_DATA_RATE[2][2][77];
u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
-void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
+void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 5c89744b2bbe..296c2ca643e8 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -1215,7 +1215,7 @@ inline void rtllib_softmac_new_net(struct rtllib_device *ieee,
!(ieee->softmac_features & IEEE_SOFTMAC_SCAN))
rtllib_stop_scan_syncro(ieee);
- HTResetIOTSetting(ieee->ht_info);
+ ht_reset_iot_setting(ieee->ht_info);
ieee->wmm_acm = 0;
if (ieee->iw_mode == IW_MODE_INFRA) {
/* Join the network for the first time */
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/5] staging: rtl8192e: rename variable HTConstructCapabilityElement
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
2023-12-11 0:13 ` [PATCH 1/5] staging: rtl8192e: rename variable HTIOTActDetermineRaFunc Gary Rookard
2023-12-11 0:13 ` [PATCH 2/5] staging: rtl8192e: rename variable HTResetIOTSetting Gary Rookard
@ 2023-12-11 0:13 ` Gary Rookard
2023-12-11 0:13 ` [PATCH 4/5] staging: rtl8192e: rename variable HTConstructRT2RTAggElement Gary Rookard
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-12-11 0:13 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTConstructCapabilityElement -> ht_construct_capability_element
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 2a3cb6434100..c2c7fc316f62 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -247,7 +247,7 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_info)
ht_info->iot_ra_func = 0;
}
-void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
+void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHTCap,
u8 *len, u8 IsEncrypt, bool bAssoc)
{
struct rt_hi_throughput *pHT = ieee->ht_info;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index e8c795faf4f9..ff3ba9bca023 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1755,7 +1755,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee,
enum ht_channel_width bandwidth,
enum ht_extchnl_offset Offset);
void ht_update_default_setting(struct rtllib_device *ieee);
-void HTConstructCapabilityElement(struct rtllib_device *ieee,
+void ht_construct_capability_element(struct rtllib_device *ieee,
u8 *posHTCap, u8 *len,
u8 isEncrypt, bool bAssoc);
void HTConstructRT2RTAggElement(struct rtllib_device *ieee,
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 296c2ca643e8..9e9725ed8fa0 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -733,7 +733,7 @@ rtllib_association_req(struct rtllib_network *beacon,
if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht) {
ht_cap_buf = (u8 *)&(ieee->ht_info->SelfHTCap);
ht_cap_len = sizeof(ieee->ht_info->SelfHTCap);
- HTConstructCapabilityElement(ieee, ht_cap_buf, &ht_cap_len,
+ ht_construct_capability_element(ieee, ht_cap_buf, &ht_cap_len,
encrypt, true);
if (ieee->ht_info->current_rt2rt_aggregation) {
realtek_ie_buf = ieee->ht_info->sz_rt2rt_agg_buf;
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/5] staging: rtl8192e: rename variable HTConstructRT2RTAggElement
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
` (2 preceding siblings ...)
2023-12-11 0:13 ` [PATCH 3/5] staging: rtl8192e: rename variable HTConstructCapabilityElement Gary Rookard
@ 2023-12-11 0:13 ` Gary Rookard
2023-12-11 0:13 ` [PATCH 5/5] staging: rtl8192e: rename variable HT_PickMCSRate Gary Rookard
2023-12-11 18:54 ` [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Philipp Hortmann
5 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-12-11 0:13 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HTConstructRT2RTAggElement -> ht_construct_rt2rt_agg_element
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index c2c7fc316f62..a374f4c9f17e 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -328,7 +328,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHTCap,
}
}
-void HTConstructRT2RTAggElement(struct rtllib_device *ieee, u8 *posRT2RTAgg,
+void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg,
u8 *len)
{
if (!posRT2RTAgg) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ff3ba9bca023..0d6144548c34 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1758,7 +1758,7 @@ void ht_update_default_setting(struct rtllib_device *ieee);
void ht_construct_capability_element(struct rtllib_device *ieee,
u8 *posHTCap, u8 *len,
u8 isEncrypt, bool bAssoc);
-void HTConstructRT2RTAggElement(struct rtllib_device *ieee,
+void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
u8 *posRT2RTAgg, u8 *len);
void HTOnAssocRsp(struct rtllib_device *ieee);
void HTInitializeHTInfo(struct rtllib_device *ieee);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 9e9725ed8fa0..31a072e2a6d7 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -739,7 +739,7 @@ rtllib_association_req(struct rtllib_network *beacon,
realtek_ie_buf = ieee->ht_info->sz_rt2rt_agg_buf;
realtek_ie_len =
sizeof(ieee->ht_info->sz_rt2rt_agg_buf);
- HTConstructRT2RTAggElement(ieee, realtek_ie_buf,
+ ht_construct_rt2rt_agg_element(ieee, realtek_ie_buf,
&realtek_ie_len);
}
}
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 5/5] staging: rtl8192e: rename variable HT_PickMCSRate
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
` (3 preceding siblings ...)
2023-12-11 0:13 ` [PATCH 4/5] staging: rtl8192e: rename variable HTConstructRT2RTAggElement Gary Rookard
@ 2023-12-11 0:13 ` Gary Rookard
2023-12-11 18:54 ` [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Philipp Hortmann
5 siblings, 0 replies; 7+ messages in thread
From: Gary Rookard @ 2023-12-11 0:13 UTC (permalink / raw)
To: gregkh, philipp.g.hortmann; +Cc: linux-staging, linux-kernel, Gary Rookard
Coding style issue, checkpatch Avoid CamelCase,
rename it. HT_PickMCSRate -> ht_pick_mcs_rate
Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index a374f4c9f17e..14e25f87c1bf 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -350,7 +350,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg,
*len = 6 + 2;
}
-static u8 HT_PickMCSRate(struct rtllib_device *ieee, u8 *pOperateMCS)
+static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
{
u8 i;
@@ -426,7 +426,7 @@ static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS,
pOperateMCS[i] = ieee->reg_dot11tx_ht_oper_rate_set[i] &
pSupportMCS[i];
- HT_PickMCSRate(ieee, pOperateMCS);
+ ht_pick_mcs_rate(ieee, pOperateMCS);
if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
pOperateMCS[1] = 0;
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other
2023-12-11 0:13 [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other Gary Rookard
` (4 preceding siblings ...)
2023-12-11 0:13 ` [PATCH 5/5] staging: rtl8192e: rename variable HT_PickMCSRate Gary Rookard
@ 2023-12-11 18:54 ` Philipp Hortmann
5 siblings, 0 replies; 7+ messages in thread
From: Philipp Hortmann @ 2023-12-11 18:54 UTC (permalink / raw)
To: Gary Rookard, gregkh; +Cc: linux-staging, linux-kernel
On 12/11/23 01:13, Gary Rookard wrote:
> Hi,
>
> This patch series renames (5) different variables with
> the checkpatch coding style issue, Avoid CamelCase.
>
> Patch 1/5) rename variable HTIOTActDetermineRaFunc
> Patch 2/5) rename variable HTResetIOTSetting
> Patch 3/5) rename variable HTConstructCapabilityElement
> Patch 4/5) rename variable HTConstructRT2RTAggElement
> Patch 5/5) rename variable HT_PickMCSRate
>
> Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
>
> Gary Rookard (5):
> staging: rtl8192e: rename variable HTIOTActDetermineRaFunc
> staging: rtl8192e: rename variable HTResetIOTSetting
> staging: rtl8192e: rename variable HTConstructCapabilityElement
> staging: rtl8192e: rename variable HTConstructRT2RTAggElement
> staging: rtl8192e: rename variable HT_PickMCSRate
>
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++-------
> drivers/staging/rtl8192e/rtllib.h | 6 +++---
> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
> 3 files changed, 13 insertions(+), 13 deletions(-)
>
Compiled and tested on hardware -> OK
^ permalink raw reply [flat|nested] 7+ messages in thread