* [PATCH 0/3] Add support for proxy interconnect bandwidth votes @ 2022-02-14 4:34 Sibi Sankar 2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar ` (3 more replies) 0 siblings, 4 replies; 10+ messages in thread From: Sibi Sankar @ 2022-02-14 4:34 UTC (permalink / raw) To: bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski, Sibi Sankar Add support for proxy interconnect bandwidth votes during modem bootup on SC7280 SoCs. Sibi Sankar (3): dt-bindings: remoteproc: qcom: Add interconnects property remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 23 ++++++ arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 + drivers/remoteproc/qcom_q6v5_mss.c | 95 +++++++++++++++++++++- 3 files changed, 119 insertions(+), 1 deletion(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property 2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar @ 2022-02-14 4:34 ` Sibi Sankar 2022-02-14 7:28 ` Krzysztof Kozlowski 2022-02-14 4:34 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting Sibi Sankar ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: Sibi Sankar @ 2022-02-14 4:34 UTC (permalink / raw) To: bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski, Sibi Sankar Add interconnects property to support the bandwidth requirements during modem bootup on SC7280 SoCs. Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt index 8f1507052afd..a533dfa7d62c 100644 --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt @@ -183,6 +183,29 @@ For the compatible string below the following supplies are required: qcom,sdm845-mss-pil: must be "cx", "mx", "mss" +- interconnects: + Usage: required + Value type: <phandle> + Definition: reference to the source and destination nodes of the interconnect paths + that match the interconnect-names. See also interconnect/interconnect.txt + +- interconnect-names: + Usage: required + Value type: <stringlist> + Definition: The interconnects needed depend on the compatible string: + qcom,ipq8074-wcss-pil: + qcom,qcs404-wcss-pil: + qcom,q6v5-pil: + qcom,msm8916-mss-pil: + qcom,msm8974-mss-pil: + qcom,msm8996-mss-pil: + qcom,msm8998-mss-pil: + qcom,sc7180-mss-pil: + qcom,sdm845-mss-pil: + no interconnect names required + qcom,sc7280-mss-pil: + must be "imem" + - qcom,qmp: Usage: optional Value type: <phandle> -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property 2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar @ 2022-02-14 7:28 ` Krzysztof Kozlowski 0 siblings, 0 replies; 10+ messages in thread From: Krzysztof Kozlowski @ 2022-02-14 7:28 UTC (permalink / raw) To: Sibi Sankar, bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka On 14/02/2022 05:34, Sibi Sankar wrote: > Add interconnects property to support the bandwidth requirements > during modem bootup on SC7280 SoCs. > > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > There were several properties added within last months, so in total you changed these bindings quite a lot. Please convert them to YAML. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting 2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar 2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar @ 2022-02-14 4:34 ` Sibi Sankar 2022-02-22 18:33 ` Bjorn Andersson 2022-02-14 4:34 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar 2022-04-04 23:17 ` [PATCH 0/3] Add support for proxy interconnect bandwidth votes Stephen Boyd 3 siblings, 1 reply; 10+ messages in thread From: Sibi Sankar @ 2022-02-14 4:34 UTC (permalink / raw) To: bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski, Sibi Sankar Add support for proxy interconnect bandwidth votes during modem bootup on SC7280 SoCs. Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- drivers/remoteproc/qcom_q6v5_mss.c | 95 +++++++++++++++++++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c index a2c231a17b2b..5a37628311c6 100644 --- a/drivers/remoteproc/qcom_q6v5_mss.c +++ b/drivers/remoteproc/qcom_q6v5_mss.c @@ -12,6 +12,7 @@ #include <linux/devcoredump.h> #include <linux/dma-mapping.h> #include <linux/interrupt.h> +#include <linux/interconnect.h> #include <linux/kernel.h> #include <linux/mfd/syscon.h> #include <linux/module.h> @@ -125,6 +126,18 @@ #define QDSP6SS_BOOT_CMD 0x404 #define BOOT_FSM_TIMEOUT 10000 +struct interconnect_info { + struct icc_path *path; + u32 average_bandwidth; + u32 peak_bandwidth; +}; + +struct qcom_mss_icc_res { + const char *name; + u32 average_bandwidth; + u32 peak_bandwidth; +}; + struct reg_info { struct regulator *reg; int uV; @@ -142,6 +155,7 @@ struct rproc_hexagon_res { struct qcom_mss_reg_res *proxy_supply; struct qcom_mss_reg_res *fallback_proxy_supply; struct qcom_mss_reg_res *active_supply; + struct qcom_mss_icc_res *proxy_path; char **proxy_clk_names; char **reset_clk_names; char **active_clk_names; @@ -202,6 +216,9 @@ struct q6v5 { int proxy_reg_count; int fallback_proxy_reg_count; + struct interconnect_info interconnect[1]; + int proxy_path_count; + bool dump_mba_loaded; size_t current_dump_size; size_t total_dump_size; @@ -267,6 +284,29 @@ static int q6v5_regulator_init(struct device *dev, struct reg_info *regs, return i; } +static int q6v5_interconnect_init(struct device *dev, struct interconnect_info *interconnect, + const struct qcom_mss_icc_res *icc_res) +{ + struct icc_path *path; + int i; + + for (i = 0; icc_res[i].name; i++) { + path = devm_of_icc_get(dev, icc_res[i].name); + if (IS_ERR(path)) { + int ret = PTR_ERR(path); + + dev_err_probe(dev, ret, "Failed to get %s interconnect\n", icc_res[i].name); + return ret; + } + + interconnect[i].path = path; + interconnect[i].average_bandwidth = icc_res[i].average_bandwidth; + interconnect[i].peak_bandwidth = icc_res[i].peak_bandwidth; + } + + return i; +} + static int q6v5_regulator_enable(struct q6v5 *qproc, struct reg_info *regs, int count) { @@ -364,6 +404,36 @@ static void q6v5_clk_disable(struct device *dev, clk_disable_unprepare(clks[i]); } +static int q6v5_icc_enable(struct device *dev, struct interconnect_info *interconnect, int count) +{ + int ret; + int i; + + for (i = 0; i < count; i++) { + ret = icc_set_bw(interconnect[i].path, interconnect[i].average_bandwidth, + interconnect[i].peak_bandwidth); + if (ret) + dev_err(dev, "Failed enabling %s interconnect\n", + icc_get_name(interconnect[i].path)); + goto err; + } + + return 0; +err: + for (i--; i >= 0; i--) + icc_set_bw(interconnect[i].path, 0, 0); + + return ret; +} + +static void q6v5_icc_disable(struct device *dev, struct interconnect_info *interconnect, int count) +{ + int i; + + for (i = 0; i < count; i++) + icc_set_bw(interconnect[i].path, 0, 0); +} + static int q6v5_pds_enable(struct q6v5 *qproc, struct device **pds, size_t pd_count) { @@ -1011,10 +1081,14 @@ static int q6v5_mba_load(struct q6v5 *qproc) if (ret) return ret; + ret = q6v5_icc_enable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); + if (ret) + goto disable_irqs; + ret = q6v5_pds_enable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); if (ret < 0) { dev_err(qproc->dev, "failed to enable proxy power domains\n"); - goto disable_irqs; + goto disable_path; } ret = q6v5_regulator_enable(qproc, qproc->fallback_proxy_regs, @@ -1158,6 +1232,8 @@ static int q6v5_mba_load(struct q6v5 *qproc) qproc->fallback_proxy_reg_count); disable_proxy_pds: q6v5_pds_disable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); +disable_path: + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); disable_irqs: qcom_q6v5_unprepare(&qproc->q6v5); @@ -1232,6 +1308,7 @@ static void q6v5_mba_reclaim(struct q6v5 *qproc) qproc->fallback_proxy_reg_count); q6v5_regulator_disable(qproc, qproc->proxy_regs, qproc->proxy_reg_count); + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); } } @@ -1611,6 +1688,7 @@ static void qcom_msa_handover(struct qcom_q6v5 *q6v5) q6v5_regulator_disable(qproc, qproc->fallback_proxy_regs, qproc->fallback_proxy_reg_count); q6v5_pds_disable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); } static int q6v5_init_mem(struct q6v5 *qproc, struct platform_device *pdev) @@ -1942,6 +2020,13 @@ static int q6v5_probe(struct platform_device *pdev) } qproc->active_reg_count = ret; + ret = q6v5_interconnect_init(&pdev->dev, qproc->interconnect, desc->proxy_path); + if (ret < 0) { + dev_err(&pdev->dev, "Failed to get proxy interconnects.\n"); + goto free_rproc; + } + qproc->proxy_path_count = ret; + ret = q6v5_pds_attach(&pdev->dev, qproc->proxy_pds, desc->proxy_pd_names); /* Fallback to regulators for old device trees */ @@ -2077,6 +2162,14 @@ static const struct rproc_hexagon_res sc7280_mss = { "mss", NULL }, + .proxy_path = (struct qcom_mss_icc_res[]) { + { + .name = "imem", + .average_bandwidth = 0, + .peak_bandwidth = 8532000, + }, + {} + }, .need_mem_protection = true, .has_alt_reset = false, .has_mba_logs = true, -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting 2022-02-14 4:34 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting Sibi Sankar @ 2022-02-22 18:33 ` Bjorn Andersson 0 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2022-02-22 18:33 UTC (permalink / raw) To: Sibi Sankar Cc: robh+dt, ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski On Sun 13 Feb 20:34 PST 2022, Sibi Sankar wrote: > Add support for proxy interconnect bandwidth votes during modem bootup on > SC7280 SoCs. > > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > drivers/remoteproc/qcom_q6v5_mss.c | 95 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 94 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > index a2c231a17b2b..5a37628311c6 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > @@ -12,6 +12,7 @@ > #include <linux/devcoredump.h> > #include <linux/dma-mapping.h> > #include <linux/interrupt.h> > +#include <linux/interconnect.h> > #include <linux/kernel.h> > #include <linux/mfd/syscon.h> > #include <linux/module.h> > @@ -125,6 +126,18 @@ > #define QDSP6SS_BOOT_CMD 0x404 > #define BOOT_FSM_TIMEOUT 10000 > > +struct interconnect_info { This is a rather generic name. > + struct icc_path *path; > + u32 average_bandwidth; > + u32 peak_bandwidth; > +}; > + > +struct qcom_mss_icc_res { > + const char *name; > + u32 average_bandwidth; > + u32 peak_bandwidth; > +}; > + > struct reg_info { > struct regulator *reg; > int uV; > @@ -142,6 +155,7 @@ struct rproc_hexagon_res { > struct qcom_mss_reg_res *proxy_supply; > struct qcom_mss_reg_res *fallback_proxy_supply; > struct qcom_mss_reg_res *active_supply; > + struct qcom_mss_icc_res *proxy_path; > char **proxy_clk_names; > char **reset_clk_names; > char **active_clk_names; > @@ -202,6 +216,9 @@ struct q6v5 { > int proxy_reg_count; > int fallback_proxy_reg_count; > > + struct interconnect_info interconnect[1]; If there is only one, then I think it's perfectly fine that we postpone the introduction of an array and the loops etc. But if you see a reason to support multiple paths, I think we should utilize the icc bulk API. > + int proxy_path_count; > + > bool dump_mba_loaded; > size_t current_dump_size; > size_t total_dump_size; > @@ -267,6 +284,29 @@ static int q6v5_regulator_init(struct device *dev, struct reg_info *regs, > return i; > } > > +static int q6v5_interconnect_init(struct device *dev, struct interconnect_info *interconnect, > + const struct qcom_mss_icc_res *icc_res) > +{ > + struct icc_path *path; > + int i; > + > + for (i = 0; icc_res[i].name; i++) { > + path = devm_of_icc_get(dev, icc_res[i].name); > + if (IS_ERR(path)) { > + int ret = PTR_ERR(path); > + > + dev_err_probe(dev, ret, "Failed to get %s interconnect\n", icc_res[i].name); > + return ret; > + } > + > + interconnect[i].path = path; > + interconnect[i].average_bandwidth = icc_res[i].average_bandwidth; > + interconnect[i].peak_bandwidth = icc_res[i].peak_bandwidth; > + } > + > + return i; > +} > + > static int q6v5_regulator_enable(struct q6v5 *qproc, > struct reg_info *regs, int count) > { > @@ -364,6 +404,36 @@ static void q6v5_clk_disable(struct device *dev, > clk_disable_unprepare(clks[i]); > } > > +static int q6v5_icc_enable(struct device *dev, struct interconnect_info *interconnect, int count) > +{ > + int ret; > + int i; > + > + for (i = 0; i < count; i++) { > + ret = icc_set_bw(interconnect[i].path, interconnect[i].average_bandwidth, > + interconnect[i].peak_bandwidth); > + if (ret) > + dev_err(dev, "Failed enabling %s interconnect\n", > + icc_get_name(interconnect[i].path)); > + goto err; > + } > + > + return 0; > +err: > + for (i--; i >= 0; i--) > + icc_set_bw(interconnect[i].path, 0, 0); devm_of_icc_get() will return an "enabled" path, but from that point we can use icc_enable() and icc_disable() to toggle if our vote should be taking part in the aggregation. By using that we should be able to just icc_set_bw() in q6v5_interconnect_init(), call icc_disable() and from there on we can wrap our proxy vote in icc_enable() and icc_disable(). That way you don't need to copy average_bandwidth and peak_bandwidth into the interconnect_info. Regards, Bjorn > + > + return ret; > +} > + > +static void q6v5_icc_disable(struct device *dev, struct interconnect_info *interconnect, int count) > +{ > + int i; > + > + for (i = 0; i < count; i++) > + icc_set_bw(interconnect[i].path, 0, 0); > +} > + > static int q6v5_pds_enable(struct q6v5 *qproc, struct device **pds, > size_t pd_count) > { > @@ -1011,10 +1081,14 @@ static int q6v5_mba_load(struct q6v5 *qproc) > if (ret) > return ret; > > + ret = q6v5_icc_enable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); > + if (ret) > + goto disable_irqs; > + > ret = q6v5_pds_enable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); > if (ret < 0) { > dev_err(qproc->dev, "failed to enable proxy power domains\n"); > - goto disable_irqs; > + goto disable_path; > } > > ret = q6v5_regulator_enable(qproc, qproc->fallback_proxy_regs, > @@ -1158,6 +1232,8 @@ static int q6v5_mba_load(struct q6v5 *qproc) > qproc->fallback_proxy_reg_count); > disable_proxy_pds: > q6v5_pds_disable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); > +disable_path: > + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); > disable_irqs: > qcom_q6v5_unprepare(&qproc->q6v5); > > @@ -1232,6 +1308,7 @@ static void q6v5_mba_reclaim(struct q6v5 *qproc) > qproc->fallback_proxy_reg_count); > q6v5_regulator_disable(qproc, qproc->proxy_regs, > qproc->proxy_reg_count); > + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); > } > } > > @@ -1611,6 +1688,7 @@ static void qcom_msa_handover(struct qcom_q6v5 *q6v5) > q6v5_regulator_disable(qproc, qproc->fallback_proxy_regs, > qproc->fallback_proxy_reg_count); > q6v5_pds_disable(qproc, qproc->proxy_pds, qproc->proxy_pd_count); > + q6v5_icc_disable(qproc->dev, qproc->interconnect, qproc->proxy_path_count); > } > > static int q6v5_init_mem(struct q6v5 *qproc, struct platform_device *pdev) > @@ -1942,6 +2020,13 @@ static int q6v5_probe(struct platform_device *pdev) > } > qproc->active_reg_count = ret; > > + ret = q6v5_interconnect_init(&pdev->dev, qproc->interconnect, desc->proxy_path); > + if (ret < 0) { > + dev_err(&pdev->dev, "Failed to get proxy interconnects.\n"); > + goto free_rproc; > + } > + qproc->proxy_path_count = ret; > + > ret = q6v5_pds_attach(&pdev->dev, qproc->proxy_pds, > desc->proxy_pd_names); > /* Fallback to regulators for old device trees */ > @@ -2077,6 +2162,14 @@ static const struct rproc_hexagon_res sc7280_mss = { > "mss", > NULL > }, > + .proxy_path = (struct qcom_mss_icc_res[]) { > + { > + .name = "imem", > + .average_bandwidth = 0, > + .peak_bandwidth = 8532000, > + }, > + {} > + }, > .need_mem_protection = true, > .has_alt_reset = false, > .has_mba_logs = true, > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem 2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar 2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar 2022-02-14 4:34 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting Sibi Sankar @ 2022-02-14 4:34 ` Sibi Sankar 2022-02-24 19:59 ` Bjorn Andersson 2022-04-04 23:17 ` [PATCH 0/3] Add support for proxy interconnect bandwidth votes Stephen Boyd 3 siblings, 1 reply; 10+ messages in thread From: Sibi Sankar @ 2022-02-14 4:34 UTC (permalink / raw) To: bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski, Sibi Sankar Add interconnects that are required to be proxy voted upon during modem bootup on SC7280 SoCs. Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi index 9f4a9c263c35..1969f4cf59fe 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi @@ -89,6 +89,8 @@ compatible = "qcom,sc7280-mss-pil"; iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; memory-region = <&mba_mem>, <&mpss_mem>; + interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; + interconnect-names = "imem"; }; /* Increase the size from 2.5MB to 8MB */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem 2022-02-14 4:34 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar @ 2022-02-24 19:59 ` Bjorn Andersson 0 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2022-02-24 19:59 UTC (permalink / raw) To: Sibi Sankar Cc: robh+dt, ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, swboyd, mka, krzysztof.kozlowski On Sun 13 Feb 22:34 CST 2022, Sibi Sankar wrote: > Add interconnects that are required to be proxy voted upon during modem > bootup on SC7280 SoCs. > Looked at this again, and it makes me wonder why do we need to vote on the path LLCC -> EBI1 and why do we call that path "imem"? Regards, Bjorn > Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > index 9f4a9c263c35..1969f4cf59fe 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi > @@ -89,6 +89,8 @@ > compatible = "qcom,sc7280-mss-pil"; > iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; > memory-region = <&mba_mem>, <&mpss_mem>; > + interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; > + interconnect-names = "imem"; > }; > > /* Increase the size from 2.5MB to 8MB */ > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add support for proxy interconnect bandwidth votes 2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar ` (2 preceding siblings ...) 2022-02-14 4:34 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar @ 2022-04-04 23:17 ` Stephen Boyd 2022-05-10 10:59 ` Sibi Sankar 3 siblings, 1 reply; 10+ messages in thread From: Stephen Boyd @ 2022-04-04 23:17 UTC (permalink / raw) To: Sibi Sankar, bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, mka, krzysztof.kozlowski Quoting Sibi Sankar (2022-02-13 20:34:09) > Add support for proxy interconnect bandwidth votes during modem bootup on > SC7280 SoCs. > > Sibi Sankar (3): > dt-bindings: remoteproc: qcom: Add interconnects property > remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth > voting > arm64: dts: qcom: sc7280: Add proxy interconnect requirements for > modem Is this patch series going to be resent? Does it need to be applied to sc7180 as well? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add support for proxy interconnect bandwidth votes 2022-04-04 23:17 ` [PATCH 0/3] Add support for proxy interconnect bandwidth votes Stephen Boyd @ 2022-05-10 10:59 ` Sibi Sankar 2022-05-10 11:03 ` Sibi Sankar 0 siblings, 1 reply; 10+ messages in thread From: Sibi Sankar @ 2022-05-10 10:59 UTC (permalink / raw) To: Stephen Boyd, bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, mka, krzysztof.kozlowski On 4/5/22 4:47 AM, Stephen Boyd wrote: > Quoting Sibi Sankar (2022-02-13 20:34:09) >> Add support for proxy interconnect bandwidth votes during modem bootup on >> SC7280 SoCs. >> >> Sibi Sankar (3): >> dt-bindings: remoteproc: qcom: Add interconnects property >> remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth >> voting >> arm64: dts: qcom: sc7280: Add proxy interconnect requirements for >> modem > > Is this patch series going to be resent? Does it need to be applied to > sc7180 as well? Stephen, The proxy votes are needed on SC7180. -Sibi > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add support for proxy interconnect bandwidth votes 2022-05-10 10:59 ` Sibi Sankar @ 2022-05-10 11:03 ` Sibi Sankar 0 siblings, 0 replies; 10+ messages in thread From: Sibi Sankar @ 2022-05-10 11:03 UTC (permalink / raw) To: Stephen Boyd, bjorn.andersson, robh+dt Cc: ohad, agross, mathieu.poirier, linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, evgreen, dianders, mka, krzysztof.kozlowski On 5/10/22 4:29 PM, Sibi Sankar wrote: > On 4/5/22 4:47 AM, Stephen Boyd wrote: >> Quoting Sibi Sankar (2022-02-13 20:34:09) >>> Add support for proxy interconnect bandwidth votes during modem >>> bootup on >>> SC7280 SoCs. >>> >>> Sibi Sankar (3): >>> dt-bindings: remoteproc: qcom: Add interconnects property >>> remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth >>> voting >>> arm64: dts: qcom: sc7280: Add proxy interconnect requirements for >>> modem >> >> Is this patch series going to be resent? Does it need to be applied to >> sc7180 as well? > > Stephen, > The proxy votes are needed on SC7180. Sorry I meant to say they aren't needed on SC7180. > > -Sibi >> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-05-10 11:03 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-14 4:34 [PATCH 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar 2022-02-14 4:34 ` [PATCH 1/3] dt-bindings: remoteproc: qcom: Add interconnects property Sibi Sankar 2022-02-14 7:28 ` Krzysztof Kozlowski 2022-02-14 4:34 ` [PATCH 2/3] remoteproc: qcom_q6v5_mss: Add support for interconnect bandwidth voting Sibi Sankar 2022-02-22 18:33 ` Bjorn Andersson 2022-02-14 4:34 ` [PATCH 3/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar 2022-02-24 19:59 ` Bjorn Andersson 2022-04-04 23:17 ` [PATCH 0/3] Add support for proxy interconnect bandwidth votes Stephen Boyd 2022-05-10 10:59 ` Sibi Sankar 2022-05-10 11:03 ` Sibi Sankar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).