* [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()
@ 2019-09-27 3:50 Baolin Wang
2019-09-27 3:50 ` [PATCH 2/2] clk: sprd: Change to use devm_platform_ioremap_resource() Baolin Wang
2019-09-27 18:45 ` [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2019-09-27 3:50 UTC (permalink / raw)
To: mturquette, sboyd
Cc: orsonzhai, baolin.wang, zhang.lyra, linux-clk, linux-kernel
The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/clk/sprd/common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
index 9d56eac..7ad5ba2 100644
--- a/drivers/clk/sprd/common.c
+++ b/drivers/clk/sprd/common.c
@@ -46,7 +46,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
if (of_find_property(node, "sprd,syscon", NULL)) {
regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
- if (IS_ERR_OR_NULL(regmap)) {
+ if (IS_ERR(regmap)) {
pr_err("%s: failed to get syscon regmap\n", __func__);
return PTR_ERR(regmap);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] clk: sprd: Change to use devm_platform_ioremap_resource()
2019-09-27 3:50 [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Baolin Wang
@ 2019-09-27 3:50 ` Baolin Wang
2019-09-27 18:45 ` [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Baolin Wang @ 2019-09-27 3:50 UTC (permalink / raw)
To: mturquette, sboyd
Cc: orsonzhai, baolin.wang, zhang.lyra, linux-clk, linux-kernel
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together, which can simpify the code.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/clk/sprd/common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
index 7ad5ba2..c0af477 100644
--- a/drivers/clk/sprd/common.c
+++ b/drivers/clk/sprd/common.c
@@ -42,7 +42,6 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
void __iomem *base;
struct device_node *node = pdev->dev.of_node;
struct regmap *regmap;
- struct resource *res;
if (of_find_property(node, "sprd,syscon", NULL)) {
regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
@@ -51,8 +50,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
return PTR_ERR(regmap);
}
} else {
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()
2019-09-27 3:50 [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Baolin Wang
2019-09-27 3:50 ` [PATCH 2/2] clk: sprd: Change to use devm_platform_ioremap_resource() Baolin Wang
@ 2019-09-27 18:45 ` Stephen Boyd
2019-09-29 2:30 ` Baolin Wang
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Boyd @ 2019-09-27 18:45 UTC (permalink / raw)
To: Baolin Wang, mturquette
Cc: orsonzhai, baolin.wang, zhang.lyra, linux-clk, linux-kernel
Quoting Baolin Wang (2019-09-26 20:50:53)
> The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
> IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> drivers/clk/sprd/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Fixes tag?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()
2019-09-27 18:45 ` [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Stephen Boyd
@ 2019-09-29 2:30 ` Baolin Wang
0 siblings, 0 replies; 4+ messages in thread
From: Baolin Wang @ 2019-09-29 2:30 UTC (permalink / raw)
To: Stephen Boyd
Cc: Michael Turquette, Orson Zhai, Chunyan Zhang, linux-clk, LKML
Hi Stephen,
On Sat, 28 Sep 2019 at 02:45, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Baolin Wang (2019-09-26 20:50:53)
> > The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
> > IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().
> >
> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> > ---
> > drivers/clk/sprd/common.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixes tag?
Yes, the fixes tag should be:
Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure")
Do I need to resend this patch with adding the fixes tag?
--
Baolin Wang
Best Regards
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-29 2:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 3:50 [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Baolin Wang
2019-09-27 3:50 ` [PATCH 2/2] clk: sprd: Change to use devm_platform_ioremap_resource() Baolin Wang
2019-09-27 18:45 ` [PATCH 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() Stephen Boyd
2019-09-29 2:30 ` Baolin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).