From: David Laight <David.Laight@ACULAB.COM>
To: 'Huacai Chen' <chenhuacai@loongson.cn>,
Huacai Chen <chenhuacai@kernel.org>
Cc: "loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
Xuefeng Li <lixuefeng@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>, Guo Ren <guoren@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2] LoongArch: Add unaligned access support
Date: Mon, 17 Oct 2022 12:58:25 +0000 [thread overview]
Message-ID: <b8792b1a71754d6eb88debe4d6c2c419@AcuMS.aculab.com> (raw)
In-Reply-To: <20221017022330.2383060-1-chenhuacai@loongson.cn>
From: Huacai Chen
> Sent: 17 October 2022 03:24
>
> Loongson-2 series (Loongson-2K500, Loongson-2K1000) don't support
> unaligned access in hardware, while Loongson-3 series (Loongson-3A5000,
> Loongson-3C5000) are configurable whether support unaligned access in
> hardware. This patch add unaligned access emulation for those LoongArch
> processors without hardware support.
>
...
> + /*
> + * This load never faults.
> + */
> + __get_inst(&insn.word, pc, user);
On what basis does it never fault?
Any user access can fault.
If nothing else another thread of the process can unmap
the page.
> + if (user && !access_ok(addr, 8))
> + goto sigbus;
Surely that is technically wrong - a two or four byte
access is valid right at the end of valid user addreeses.
> +
> + if (insn.reg2i12_format.opcode == ldd_op ||
> + insn.reg2i14_format.opcode == ldptrd_op ||
> + insn.reg3_format.opcode == ldxd_op) {
> + res = unaligned_read(addr, &value, 8, 1);
That is the most horrid indentation of long lines I've
ever seen.
I'd also guess you can common up some of this code
by looking at the instruction field that include the
transfer width.
The long elsif list will generate horrid code.
But maybe since you've just taken a fault it really
doesn't matter.
Indeed just emulating in C using byte accesses
it probably fine.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-10-17 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 2:23 [PATCH V2] LoongArch: Add unaligned access support Huacai Chen
2022-10-17 4:22 ` Jinyang He
2022-10-17 7:37 ` Huacai Chen
2022-10-17 6:07 ` WANG Xuerui
2022-10-17 7:40 ` Huacai Chen
2022-10-17 8:59 ` Rui Wang
2022-10-17 9:03 ` Huacai Chen
2022-10-17 9:19 ` WANG Xuerui
2022-10-17 12:58 ` David Laight [this message]
2022-10-18 2:24 ` Huacai Chen
2022-10-18 3:29 ` WANG Xuerui
2022-10-18 7:32 ` Huacai Chen
2022-10-18 7:48 ` David Laight
2022-10-18 8:09 ` WANG Xuerui
2022-10-18 9:36 ` Huacai Chen
2022-10-17 14:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8792b1a71754d6eb88debe4d6c2c419@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=guoren@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).