From: Michal Kubecek <mkubecek@suse.cz>
To: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/7] ethtool: fix kernel-doc descriptions
Date: Sun, 26 Jan 2020 23:11:01 +0100 (CET) [thread overview]
Message-ID: <b9210583c01f2ea1689feb64aa2595394082d57f.1580075977.git.mkubecek@suse.cz> (raw)
In-Reply-To: <cover.1580075977.git.mkubecek@suse.cz>
Fix missing or incorrect function argument and struct member descriptions.
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
net/ethtool/netlink.c | 26 ++++++++++++++------------
net/ethtool/strset.c | 1 +
2 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index 86b79f9bc08d..0af43bbdb9b2 100644
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -134,11 +134,12 @@ int ethnl_fill_reply_header(struct sk_buff *skb, struct net_device *dev,
/**
* ethnl_reply_init() - Create skb for a reply and fill device identification
- * @payload: payload length (without netlink and genetlink header)
- * @dev: device the reply is about (may be null)
- * @cmd: ETHTOOL_MSG_* message type for reply
- * @info: genetlink info of the received packet we respond to
- * @ehdrp: place to store payload pointer returned by genlmsg_new()
+ * @payload: payload length (without netlink and genetlink header)
+ * @dev: device the reply is about (may be null)
+ * @cmd: ETHTOOL_MSG_* message type for reply
+ * @hdr_attrtype: attribute type for common header
+ * @info: genetlink info of the received packet we respond to
+ * @ehdrp: place to store payload pointer returned by genlmsg_new()
*
* Return: pointer to allocated skb on success, NULL on error
*/
@@ -188,10 +189,11 @@ static int ethnl_multicast(struct sk_buff *skb, struct net_device *dev)
/**
* struct ethnl_dump_ctx - context structure for generic dumpit() callback
- * @ops: request ops of currently processed message type
- * @req_info: parsed request header of processed request
- * @pos_hash: saved iteration position - hashbucket
- * @pos_idx: saved iteration position - index
+ * @ops: request ops of currently processed message type
+ * @req_info: parsed request header of processed request
+ * @reply_data: data needed to compose the reply
+ * @pos_hash: saved iteration position - hashbucket
+ * @pos_idx: saved iteration position - index
*
* These parameters are kept in struct netlink_callback as context preserved
* between iterations. They are initialized by ethnl_default_start() and used
@@ -268,9 +270,9 @@ static int ethnl_default_parse(struct ethnl_req_info *req_info,
/**
* ethnl_init_reply_data() - Initialize reply data for GET request
- * @req_info: pointer to embedded struct ethnl_req_info
- * @ops: instance of struct ethnl_request_ops describing the layout
- * @dev: network device to initialize the reply for
+ * @reply_data: pointer to embedded struct ethnl_reply_data
+ * @ops: instance of struct ethnl_request_ops describing the layout
+ * @dev: network device to initialize the reply for
*
* Fills the reply data part with zeros and sets the dev member. Must be called
* before calling the ->fill_reply() callback (for each iteration when handling
diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c
index 82a059c13c1c..948d967f1eca 100644
--- a/net/ethtool/strset.c
+++ b/net/ethtool/strset.c
@@ -85,6 +85,7 @@ get_stringset_policy[ETHTOOL_A_STRINGSET_MAX + 1] = {
/**
* strset_include() - test if a string set should be included in reply
+ * @info: parsed client request
* @data: pointer to request data structure
* @id: id of string set to check (ETH_SS_* constants)
*/
--
2.25.0
next prev parent reply other threads:[~2020-01-26 22:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:10 [PATCH net-next 0/7] ethtool netlink interface, part 2 Michal Kubecek
2020-01-26 22:11 ` Michal Kubecek [this message]
2020-01-26 22:11 ` [PATCH net-next 2/7] ethtool: provide message mask with DEBUG_GET request Michal Kubecek
2020-01-26 23:52 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 3/7] ethtool: set message mask with DEBUG_SET request Michal Kubecek
2020-01-27 0:22 ` Andrew Lunn
2020-01-27 6:23 ` Michal Kubecek
2020-01-27 1:04 ` Andrew Lunn
2020-01-27 6:24 ` Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 4/7] ethtool: add DEBUG_NTF notification Michal Kubecek
2020-01-27 1:17 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 5/7] ethtool: provide WoL settings with WOL_GET request Michal Kubecek
2020-01-27 2:11 ` Andrew Lunn
2020-01-26 22:11 ` [PATCH net-next 6/7] ethtool: set wake-on-lan settings with WOL_SET request Michal Kubecek
2020-01-26 22:11 ` [PATCH net-next 7/7] ethtool: add WOL_NTF notification Michal Kubecek
2020-01-26 23:34 ` [PATCH net-next 0/7] ethtool netlink interface, part 2 Andrew Lunn
2020-01-27 7:30 ` Michal Kubecek
2020-01-27 9:40 ` David Miller
2020-01-27 9:57 ` Michal Kubecek
2020-01-27 10:27 ` David Miller
2020-01-27 10:32 ` David Miller
2020-01-27 13:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9210583c01f2ea1689feb64aa2595394082d57f.1580075977.git.mkubecek@suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).