* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue
[not found] <1546573819-23530-1-git-send-email-rayagonda.kokatanur@broadcom.com>
@ 2019-01-04 18:45 ` Ray Jui
2019-01-04 18:46 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Ray Jui @ 2019-01-04 18:45 UTC (permalink / raw)
To: Rayagonda Kokatanur, Jassi Brar; +Cc: linux-kernel, bcm-kernel-feedback-list
On 1/3/2019 7:50 PM, Rayagonda Kokatanur wrote:
> RING_CONTROL reg was not written due to wrong address, hence all
> the subsequent ring flush was timing out.
>
> Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence")
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Tested-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index d7a8ed7..57cd729 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1396,9 +1396,9 @@ static void flexrm_shutdown(struct mbox_chan *chan)
>
> /* Clear ring flush state */
> timeout = 1000; /* timeout of 1s */
> - writel_relaxed(0x0, ring + RING_CONTROL);
> + writel_relaxed(0x0, ring->regs + RING_CONTROL);
> do {
> - if (!(readl_relaxed(ring + RING_FLUSH_DONE) &
> + if (!(readl_relaxed(ring->regs + RING_FLUSH_DONE) &
> FLUSH_DONE_MASK))
> break;
> mdelay(1);
>
Looks good to me. Thanks.
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue
[not found] <1546573819-23530-1-git-send-email-rayagonda.kokatanur@broadcom.com>
2019-01-04 18:45 ` [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue Ray Jui
@ 2019-01-04 18:46 ` Florian Fainelli
1 sibling, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2019-01-04 18:46 UTC (permalink / raw)
To: Rayagonda Kokatanur, Jassi Brar; +Cc: linux-kernel, bcm-kernel-feedback-list
On 1/3/19 7:50 PM, Rayagonda Kokatanur wrote:
> RING_CONTROL reg was not written due to wrong address, hence all
> the subsequent ring flush was timing out.
>
> Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence")
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Tested-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue
2019-02-04 19:22 ` Scott Branden
@ 2019-02-14 18:00 ` Ray Jui
0 siblings, 0 replies; 5+ messages in thread
From: Ray Jui @ 2019-02-14 18:00 UTC (permalink / raw)
To: Scott Branden, Jassi Brar
Cc: linux-kernel, bcm-kernel-feedback-list, Rayagonda Kokatanur
Hi Jassi,
Have you had a chance to review this fix? This is a critical fix for a
crash during driver shutdown.
Regards,
Ray
On 2/4/2019 11:22 AM, Scott Branden wrote:
> Fix looks good.
>
> On 2019-02-04 11:21 a.m., Ray Jui wrote:
>> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>>
>> RING_CONTROL reg was not written due to wrong address, hence all
>> the subsequent ring flush was timing out.
>>
>> Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring
>> flush sequence")
>>
>> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>> drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c
>> b/drivers/mailbox/bcm-flexrm-mailbox.c
>> index d713271ebf7c..a64116586b4c 100644
>> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
>> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
>> @@ -1396,9 +1396,9 @@ static void flexrm_shutdown(struct mbox_chan *chan)
>> /* Clear ring flush state */
>> timeout = 1000; /* timeout of 1s */
>> - writel_relaxed(0x0, ring + RING_CONTROL);
>> + writel_relaxed(0x0, ring->regs + RING_CONTROL);
>> do {
>> - if (!(readl_relaxed(ring + RING_FLUSH_DONE) &
>> + if (!(readl_relaxed(ring->regs + RING_FLUSH_DONE) &
>> FLUSH_DONE_MASK))
>> break;
>> mdelay(1);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue
2019-02-04 19:21 Ray Jui
@ 2019-02-04 19:22 ` Scott Branden
2019-02-14 18:00 ` Ray Jui
0 siblings, 1 reply; 5+ messages in thread
From: Scott Branden @ 2019-02-04 19:22 UTC (permalink / raw)
To: Ray Jui, Jassi Brar
Cc: linux-kernel, bcm-kernel-feedback-list, Rayagonda Kokatanur
Fix looks good.
On 2019-02-04 11:21 a.m., Ray Jui wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>
> RING_CONTROL reg was not written due to wrong address, hence all
> the subsequent ring flush was timing out.
>
> Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence")
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> ---
> drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
> index d713271ebf7c..a64116586b4c 100644
> --- a/drivers/mailbox/bcm-flexrm-mailbox.c
> +++ b/drivers/mailbox/bcm-flexrm-mailbox.c
> @@ -1396,9 +1396,9 @@ static void flexrm_shutdown(struct mbox_chan *chan)
>
> /* Clear ring flush state */
> timeout = 1000; /* timeout of 1s */
> - writel_relaxed(0x0, ring + RING_CONTROL);
> + writel_relaxed(0x0, ring->regs + RING_CONTROL);
> do {
> - if (!(readl_relaxed(ring + RING_FLUSH_DONE) &
> + if (!(readl_relaxed(ring->regs + RING_FLUSH_DONE) &
> FLUSH_DONE_MASK))
> break;
> mdelay(1);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue
@ 2019-02-04 19:21 Ray Jui
2019-02-04 19:22 ` Scott Branden
0 siblings, 1 reply; 5+ messages in thread
From: Ray Jui @ 2019-02-04 19:21 UTC (permalink / raw)
To: Jassi Brar
Cc: linux-kernel, bcm-kernel-feedback-list, Rayagonda Kokatanur, Ray Jui
From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
RING_CONTROL reg was not written due to wrong address, hence all
the subsequent ring flush was timing out.
Fixes: a371c10ea4b3 ("mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence")
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
drivers/mailbox/bcm-flexrm-mailbox.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index d713271ebf7c..a64116586b4c 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -1396,9 +1396,9 @@ static void flexrm_shutdown(struct mbox_chan *chan)
/* Clear ring flush state */
timeout = 1000; /* timeout of 1s */
- writel_relaxed(0x0, ring + RING_CONTROL);
+ writel_relaxed(0x0, ring->regs + RING_CONTROL);
do {
- if (!(readl_relaxed(ring + RING_FLUSH_DONE) &
+ if (!(readl_relaxed(ring->regs + RING_FLUSH_DONE) &
FLUSH_DONE_MASK))
break;
mdelay(1);
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-14 18:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1546573819-23530-1-git-send-email-rayagonda.kokatanur@broadcom.com>
2019-01-04 18:45 ` [PATCH] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush timeout issue Ray Jui
2019-01-04 18:46 ` Florian Fainelli
2019-02-04 19:21 Ray Jui
2019-02-04 19:22 ` Scott Branden
2019-02-14 18:00 ` Ray Jui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).