[PATCH] Staging: clocking-wizard: Added a blank line after declaration

[PATCH] Staging: clocking-wizard: Added a blank line after declaration

[Mohammad Jamal]

Fix the coding style issue by adding blank line after declaration

Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
---
 .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
index 471d087..ea8d561 100644
--- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
+++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
@@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
 	/* register div per output */
 	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
 		const char *clkout_name;
+
 		if (of_property_read_string_index(np, "clock-output-names", i,
 						  &clkout_name)) {
 			dev_err(&pdev->dev,
-- 
1.7.9.5

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

[Sören Brinkmann]

Hi Mohammad,

On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote:
> Fix the coding style issue by adding blank line after declaration
> 
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
> ---
>  .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> index 471d087..ea8d561 100644
> --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> @@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
>  	/* register div per output */
>  	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
>  		const char *clkout_name;
> +
>  		if (of_property_read_string_index(np, "clock-output-names", i,
>  						  &clkout_name)) {
>  			dev_err(&pdev->dev,

I think the same patch had already been sent to the list by somebody
else. Not sure whether Greg picked it up yet.
Either way, feel free to add my
Acked-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

	Sören

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

[Greg KH]

On Sat, Dec 20, 2014 at 10:11:56PM -0800, Sören Brinkmann wrote:
> Hi Mohammad,
> 
> On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote:
> > Fix the coding style issue by adding blank line after declaration
> > 
> > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
> > ---
> >  .../clocking-wizard/clk-xlnx-clock-wizard.c        |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> > index 471d087..ea8d561 100644
> > --- a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> > +++ b/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c
> > @@ -239,6 +239,7 @@ static int clk_wzrd_probe(struct platform_device *pdev)
> >  	/* register div per output */
> >  	for (i = WZRD_NUM_OUTPUTS - 1; i >= 0 ; i--) {
> >  		const char *clkout_name;
> > +
> >  		if (of_property_read_string_index(np, "clock-output-names", i,
> >  						  &clkout_name)) {
> >  			dev_err(&pdev->dev,
> 
> I think the same patch had already been sent to the list by somebody
> else. Not sure whether Greg picked it up yet.
> Either way, feel free to add my
> Acked-by: Soren Brinkmann <soren.brinkmann@xilinx.com>

I now have, so this one will not apply :(