From: David Ahern <dsahern@gmail.com>
To: Song Liu <songliubraving@fb.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net,
peterz@infradead.org, acme@kernel.org
Subject: Re: [RFC perf,bpf 5/5] perf util: generate bpf_prog_info_event for short living bpf programs
Date: Tue, 6 Nov 2018 14:54:09 -0700 [thread overview]
Message-ID: <b984776a-ce69-ab16-ed87-1cea89c9d79a@gmail.com> (raw)
In-Reply-To: <20181106205246.567448-6-songliubraving@fb.com>
On 11/6/18 1:52 PM, Song Liu wrote:
> +
> static int record__mmap_read_all(struct record *rec)
> {
> int err;
>
> + err = record__mmap_process_vip_events(rec);
> + if (err)
> + return err;
> +
> err = record__mmap_read_evlist(rec, rec->evlist, false);
> if (err)
> return err;
Seems to me that is going to increase the overhead of perf on any system
doing BPF updates. The BPF events cause a wakeup every load and unload,
and perf processes not only the VIP events but then walks all of the
other maps.
> @@ -1686,6 +1734,8 @@ static struct option __record_options[] = {
> "signal"),
> OPT_BOOLEAN(0, "dry-run", &dry_run,
> "Parse options then exit"),
> + OPT_BOOLEAN(0, "no-bpf-event", &record.no_bpf_event,
> + "do not record event on bpf program load/unload"),
Why should this default on? If am recording FIB events, I don't care
about BPF events.
next prev parent reply other threads:[~2018-11-06 21:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 20:52 [RFC perf,bpf 0/5] reveal invisible bpf programs Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 1/5] perf, bpf: Introduce PERF_RECORD_BPF_EVENT Song Liu
2018-11-07 8:40 ` Peter Zijlstra
2018-11-07 18:25 ` Song Liu
2018-11-08 15:00 ` Peter Zijlstra
2018-11-08 18:04 ` Song Liu
2018-11-08 18:26 ` David Ahern
2018-11-08 18:49 ` Song Liu
2018-11-09 17:08 ` David Ahern
2018-11-09 18:49 ` Song Liu
2018-11-09 19:14 ` Alexei Starovoitov
2018-11-06 20:52 ` [RFC perf,bpf 2/5] perf: sync tools/include/uapi/linux/perf_event.h Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 3/5] perf util: basic handling of PERF_RECORD_BPF_EVENT Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 4/5] perf util: introduce bpf_prog_info_event Song Liu
2018-11-06 21:11 ` Alexei Starovoitov
2018-11-06 20:52 ` [RFC perf,bpf 5/5] perf util: generate bpf_prog_info_event for short living bpf programs Song Liu
2018-11-06 21:54 ` David Ahern [this message]
2018-11-06 23:17 ` Song Liu
2018-11-06 23:29 ` Alexei Starovoitov
2018-11-06 23:36 ` David Miller
2018-11-07 0:13 ` Alexei Starovoitov
2018-11-07 0:23 ` David Ahern
2018-11-07 0:26 ` Alexei Starovoitov
2018-11-07 0:44 ` David Ahern
2018-11-07 1:09 ` Alexei Starovoitov
2018-11-07 18:12 ` David Ahern
2018-11-07 18:28 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b984776a-ce69-ab16-ed87-1cea89c9d79a@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).