From: Alexei Starovoitov <ast@fb.com>
To: Song Liu <songliubraving@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Kernel Team <Kernel-team@fb.com>,
"ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"peterz@infradead.org" <peterz@infradead.org>,
"acme@kernel.org" <acme@kernel.org>
Subject: Re: [RFC perf,bpf 4/5] perf util: introduce bpf_prog_info_event
Date: Tue, 6 Nov 2018 21:11:19 +0000 [thread overview]
Message-ID: <e6003688-8a9e-5845-97d4-c4c59b53815d@fb.com> (raw)
In-Reply-To: <20181106205246.567448-5-songliubraving@fb.com>
On 11/6/18 12:52 PM, Song Liu wrote:
> + /* fill in fake symbol name for now, add real name after BTF */
> + if (info.nr_jited_func_lens == 1 && info.name) { /* only main prog */
> + size_t l;
> +
> + assert(info.nr_jited_ksyms == 1);
> + l = snprintf(ptr, KSYM_NAME_LEN, "bpf_prog_%s", info.name);
please include the prog tag here. Just like kernel kallsyms do.
Other than this small nit the patch set looks great to me.
next prev parent reply other threads:[~2018-11-06 21:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 20:52 [RFC perf,bpf 0/5] reveal invisible bpf programs Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 1/5] perf, bpf: Introduce PERF_RECORD_BPF_EVENT Song Liu
2018-11-07 8:40 ` Peter Zijlstra
2018-11-07 18:25 ` Song Liu
2018-11-08 15:00 ` Peter Zijlstra
2018-11-08 18:04 ` Song Liu
2018-11-08 18:26 ` David Ahern
2018-11-08 18:49 ` Song Liu
2018-11-09 17:08 ` David Ahern
2018-11-09 18:49 ` Song Liu
2018-11-09 19:14 ` Alexei Starovoitov
2018-11-06 20:52 ` [RFC perf,bpf 2/5] perf: sync tools/include/uapi/linux/perf_event.h Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 3/5] perf util: basic handling of PERF_RECORD_BPF_EVENT Song Liu
2018-11-06 20:52 ` [RFC perf,bpf 4/5] perf util: introduce bpf_prog_info_event Song Liu
2018-11-06 21:11 ` Alexei Starovoitov [this message]
2018-11-06 20:52 ` [RFC perf,bpf 5/5] perf util: generate bpf_prog_info_event for short living bpf programs Song Liu
2018-11-06 21:54 ` David Ahern
2018-11-06 23:17 ` Song Liu
2018-11-06 23:29 ` Alexei Starovoitov
2018-11-06 23:36 ` David Miller
2018-11-07 0:13 ` Alexei Starovoitov
2018-11-07 0:23 ` David Ahern
2018-11-07 0:26 ` Alexei Starovoitov
2018-11-07 0:44 ` David Ahern
2018-11-07 1:09 ` Alexei Starovoitov
2018-11-07 18:12 ` David Ahern
2018-11-07 18:28 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6003688-8a9e-5845-97d4-c4c59b53815d@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=acme@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).