* [PATCH] nvmem: lpc18xx_eeprom: fix compile warning
@ 2018-10-05 7:03 Gustavo A. R. Silva
2018-10-05 8:06 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-05 7:03 UTC (permalink / raw)
To: Srinivas Kandagatla, Joachim Eastwood
Cc: linux-arm-kernel, linux-kernel, Gustavo A. R. Silva
Fix the following warning by removing unused variable ret:
drivers/nvmem/lpc18xx_eeprom.c: In function ‘lpc18xx_eeprom_remove’:
drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ‘ret’
[-Wunused-variable]
int ret;
^~~
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/nvmem/lpc18xx_eeprom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index b42dbad..66cff1e 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
static int lpc18xx_eeprom_remove(struct platform_device *pdev)
{
struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
- int ret;
clk_disable_unprepare(eeprom->clk);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: lpc18xx_eeprom: fix compile warning
2018-10-05 7:03 [PATCH] nvmem: lpc18xx_eeprom: fix compile warning Gustavo A. R. Silva
@ 2018-10-05 8:06 ` Srinivas Kandagatla
2018-10-05 8:12 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Kandagatla @ 2018-10-05 8:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Joachim Eastwood; +Cc: linux-arm-kernel, linux-kernel
On 05/10/18 08:03, Gustavo A. R. Silva wrote:
> Fix the following warning by removing unused variable ret:
>
> drivers/nvmem/lpc18xx_eeprom.c: In function ‘lpc18xx_eeprom_remove’:
> drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ‘ret’
> [-Wunused-variable]
> int ret;
> ^~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
There is already a patch submitted fix this
https://lore.kernel.org/patchwork/patch/995032/
-srini
> ---
> drivers/nvmem/lpc18xx_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
> index b42dbad..66cff1e 100644
> --- a/drivers/nvmem/lpc18xx_eeprom.c
> +++ b/drivers/nvmem/lpc18xx_eeprom.c
> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
> static int lpc18xx_eeprom_remove(struct platform_device *pdev)
> {
> struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
> - int ret;
>
> clk_disable_unprepare(eeprom->clk);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvmem: lpc18xx_eeprom: fix compile warning
2018-10-05 8:06 ` Srinivas Kandagatla
@ 2018-10-05 8:12 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-05 8:12 UTC (permalink / raw)
To: Srinivas Kandagatla, Joachim Eastwood; +Cc: linux-arm-kernel, linux-kernel
On 10/5/18 10:06 AM, Srinivas Kandagatla wrote:
>
>
> On 05/10/18 08:03, Gustavo A. R. Silva wrote:
>> Fix the following warning by removing unused variable ret:
>>
>> drivers/nvmem/lpc18xx_eeprom.c: In function ‘lpc18xx_eeprom_remove’:
>> drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ‘ret’
>> [-Wunused-variable]
>> int ret;
>> ^~~
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> There is already a patch submitted fix this
>
> https://lore.kernel.org/patchwork/patch/995032/
>
Oh, good to know.
Thanks, Srini.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-05 8:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 7:03 [PATCH] nvmem: lpc18xx_eeprom: fix compile warning Gustavo A. R. Silva
2018-10-05 8:06 ` Srinivas Kandagatla
2018-10-05 8:12 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).