From: Jonathan Cameron <jic23@kernel.org>
To: Eugen Hristev <eugen.hristev@microchip.com>,
nicolas.ferre@microchip.com,
alexandre.belloni@free-electrons.com, linux-iio@vger.kernel.org,
lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ludovic.desroches@microchip.com
Subject: Re: [PATCH 3/3] iio: tools: generic_buffer: increase trigger length
Date: Thu, 27 Apr 2017 06:19:35 +0100 [thread overview]
Message-ID: <b9f248a1-b65a-5e23-421c-4b8256cdddd6@kernel.org> (raw)
In-Reply-To: <1492590045-17329-4-git-send-email-eugen.hristev@microchip.com>
On 19/04/17 09:20, Eugen Hristev wrote:
> Increased trigger length to 50 in order to cope with trigger names like
> fc030000.adc-dev0-external-rising
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
This is fine (though I'd go bigger as Daniel suggested)
I'll pick it up with the revised series.
thanks,
Jonathan
> ---
> tools/iio/iio_utils.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/iio/iio_utils.h b/tools/iio/iio_utils.h
> index 780f201..9d59771 100644
> --- a/tools/iio/iio_utils.h
> +++ b/tools/iio/iio_utils.h
> @@ -13,7 +13,7 @@
> #include <stdint.h>
>
> /* Made up value to limit allocation sizes */
> -#define IIO_MAX_NAME_LENGTH 30
> +#define IIO_MAX_NAME_LENGTH 50
>
> #define FORMAT_SCAN_ELEMENTS_DIR "%s/scan_elements"
> #define FORMAT_TYPE_FILE "%s_type"
>
prev parent reply other threads:[~2017-04-27 5:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 8:20 [PATCH 0/3] iio: adc: sama5d2_adc hw triggers and buffers Eugen Hristev
2017-04-19 8:20 ` [PATCH 1/3] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin Eugen Hristev
2017-04-24 9:04 ` Ludovic Desroches
2017-04-19 8:20 ` [PATCH 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support Eugen Hristev
2017-04-24 9:06 ` Ludovic Desroches
2017-04-27 5:18 ` Jonathan Cameron
2017-04-19 8:20 ` [PATCH 3/3] iio: tools: generic_buffer: increase trigger length Eugen Hristev
2017-04-20 16:06 ` Daniel Baluta
2017-04-27 5:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f248a1-b65a-5e23-421c-4b8256cdddd6@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).