From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mathieu Malaterre <malat@debian.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] signal: annotate implicit fall through
Date: Mon, 1 Apr 2019 14:51:47 -0500 [thread overview]
Message-ID: <ba0a1ec8-b3d7-7214-ffcb-031304d463ee@embeddedor.com> (raw)
In-Reply-To: <CA+7wUswdVU=JuHPAVo9gxZJ8BYWhThnsLggVM5t9h--=AhCPPQ@mail.gmail.com>
[+cc Andrew]
On 3/13/19 3:27 PM, Mathieu Malaterre wrote:
> ping ?
>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Maybe Andrew can take this?
Thanks
--
Gustavo
> On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>>
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> this place in the code produced a warning (W=1).
>>
>> This commit remove the following warning:
>>
>> kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> kernel/signal.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index e1d7ad8e6ab1..aa7a507757d7 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>> */
>> if (!sid || sid == task_session(current))
>> break;
>> + /* fall through */
>> default:
>> return -EPERM;
>> }
>> --
>> 2.19.2
>>
prev parent reply other threads:[~2019-04-01 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:35 [PATCH] signal: annotate implicit fall through Mathieu Malaterre
2019-03-13 20:27 ` Mathieu Malaterre
2019-04-01 19:51 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0a1ec8-b3d7-7214-ffcb-031304d463ee@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).