* [PATCH] signal: annotate implicit fall through
@ 2019-01-14 20:35 Mathieu Malaterre
2019-03-13 20:27 ` Mathieu Malaterre
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2019-01-14 20:35 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: Mathieu Malaterre, linux-kernel
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warning (W=1).
This commit remove the following warning:
kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/signal.c b/kernel/signal.c
index e1d7ad8e6ab1..aa7a507757d7 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
*/
if (!sid || sid == task_session(current))
break;
+ /* fall through */
default:
return -EPERM;
}
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] signal: annotate implicit fall through
2019-01-14 20:35 [PATCH] signal: annotate implicit fall through Mathieu Malaterre
@ 2019-03-13 20:27 ` Mathieu Malaterre
2019-04-01 19:51 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Malaterre @ 2019-03-13 20:27 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: LKML, Gustavo A. R. Silva
ping ?
On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> kernel/signal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index e1d7ad8e6ab1..aa7a507757d7 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
> */
> if (!sid || sid == task_session(current))
> break;
> + /* fall through */
> default:
> return -EPERM;
> }
> --
> 2.19.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] signal: annotate implicit fall through
2019-03-13 20:27 ` Mathieu Malaterre
@ 2019-04-01 19:51 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-01 19:51 UTC (permalink / raw)
To: Mathieu Malaterre, Eric W. Biederman; +Cc: LKML, Andrew Morton
[+cc Andrew]
On 3/13/19 3:27 PM, Mathieu Malaterre wrote:
> ping ?
>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Maybe Andrew can take this?
Thanks
--
Gustavo
> On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre <malat@debian.org> wrote:
>>
>> There is a plan to build the kernel with -Wimplicit-fallthrough and
>> this place in the code produced a warning (W=1).
>>
>> This commit remove the following warning:
>>
>> kernel/signal.c:795:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> kernel/signal.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index e1d7ad8e6ab1..aa7a507757d7 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -794,6 +794,7 @@ static int check_kill_permission(int sig, struct kernel_siginfo *info,
>> */
>> if (!sid || sid == task_session(current))
>> break;
>> + /* fall through */
>> default:
>> return -EPERM;
>> }
>> --
>> 2.19.2
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 20:35 [PATCH] signal: annotate implicit fall through Mathieu Malaterre
2019-03-13 20:27 ` Mathieu Malaterre
2019-04-01 19:51 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).