From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Eugen.Hristev@microchip.com, Sergiu.Moga@microchip.com,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com,
alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com,
radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com,
mturquette@baylibre.com, sboyd@kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
admin@hifiphile.com, Kavyasree.Kotagiri@microchip.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-clk@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema
Date: Mon, 5 Sep 2022 12:10:18 +0200 [thread overview]
Message-ID: <baa9c80a-bc81-03a9-680f-883a54cb4e63@linaro.org> (raw)
In-Reply-To: <f2fdaf34-ad66-9e6d-2f11-34171fb7aaa9@microchip.com>
On 01/09/2022 13:31, Eugen.Hristev@microchip.com wrote:
>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..cf15d73fa1e8
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,at91-usart.yaml
>>>>> One more thing - I think this should be in serial directory, not mfd,
>>>>> even though it includes SPI. MFD is just a Linux naming/wrapper device.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> I would rather keep it in this directory, since its corresponding driver
>>>> is also in the mfd directory.
>>>
>>> Sorry, but that's poor argument. Driver subsystems match Linux
>>> convention, not necessarily hardware type/naming. Bindings directories
>>> match hardware. MFD bindings are only for MFD wrapper drivers and this
>>> is a serial interface. Not a MFD. You even do not add MFD devices in the
>>> driver but add *always one* device depending on serial feature you want.
>>> This is not even MFD device but regular platform device with children.
>>>
>>> You put it in SoC, though, because all other SoCs store it there...
>>
>> The last one should be:
>>
>> You could put it in SoC, though, because all other SoCs store it there...
>
> Hi,
>
> If it this is only a conversion to yaml, why do you want it moved to
> another dir ?
> Perhaps if you consider SoC or serial as a better place, it should be
> done through a different patch.
>
> Also, disputing whether this is really a MFD or not, is not in the scope
> of this patch.
>
Because you are converting - thus renaming - the bindings, so this is
the place to put them in proper place. The conversion to DT Schema comes
pretty often with small fixups, so proper location is one of them.
That's quite common case.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-05 10:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 7:55 [PATCH 0/5] Make atmel serial driver aware of GCLK Sergiu Moga
2022-08-17 7:55 ` [PATCH 1/5] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Sergiu Moga
2022-08-18 8:31 ` Krzysztof Kozlowski
2022-08-17 7:55 ` [PATCH 2/5] dt-bindings: mfd: atmel,at91-usart: convert to json-schema Sergiu Moga
2022-08-18 8:38 ` Krzysztof Kozlowski
2022-08-19 8:37 ` Sergiu.Moga
2022-08-19 8:41 ` Krzysztof Kozlowski
2022-08-19 9:25 ` Sergiu.Moga
2022-08-19 12:06 ` Krzysztof Kozlowski
2022-08-18 8:39 ` Krzysztof Kozlowski
2022-08-19 8:38 ` Sergiu.Moga
2022-08-19 8:47 ` Krzysztof Kozlowski
2022-08-19 9:05 ` Krzysztof Kozlowski
2022-09-01 11:31 ` Eugen.Hristev
2022-09-05 10:10 ` Krzysztof Kozlowski [this message]
2022-09-05 14:37 ` Lee Jones
2022-09-05 15:22 ` Sergiu.Moga
2022-09-05 16:12 ` Krzysztof Kozlowski
2022-09-06 15:49 ` Lee Jones
2022-08-17 7:55 ` [PATCH 3/5] dt-bindings: mfd: atmel,sama5d2-flexcom: Add USART child node ref binding Sergiu Moga
2022-08-17 7:55 ` [PATCH 4/5] clk: at91: sama5d2: Add Generic Clocks for UART/USART Sergiu Moga
2022-08-26 7:03 ` Claudiu.Beznea
2022-08-30 22:23 ` Stephen Boyd
2022-08-31 14:47 ` Claudiu.Beznea
2022-08-17 7:55 ` [PATCH 5/5] tty: serial: atmel: Make the driver aware of the existence of GCLK Sergiu Moga
2022-08-30 17:29 ` Richard Genoud
2022-08-31 8:49 ` Sergiu.Moga
2022-08-31 9:46 ` Claudiu.Beznea
2022-08-31 11:32 ` Sergiu.Moga
2022-09-01 6:36 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa9c80a-bc81-03a9-680f-883a54cb4e63@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=Kavyasree.Kotagiri@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=Sergiu.Moga@microchip.com \
--cc=admin@hifiphile.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=radu_nicolae.pirea@upb.ro \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).