* [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand
@ 2019-05-01 19:22 Kamal Dasu
2019-05-02 2:29 ` Florian Fainelli
2019-06-03 8:05 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Kamal Dasu @ 2019-05-01 19:22 UTC (permalink / raw)
To: linux-mtd
Cc: bcm-kernel-feedback-list, linux-kernel, Kamal Dasu, Brian Norris,
Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Marek Vasut
The oobregion->offset for large page nand parts was wrong, change
fixes this error in calculation.
Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 482c6f0..3eefea7 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -939,7 +939,7 @@ static int brcmnand_bch_ooblayout_ecc(struct mtd_info *mtd, int section,
if (section >= sectors)
return -ERANGE;
- oobregion->offset = (section * (sas + 1)) - chip->ecc.bytes;
+ oobregion->offset = ((section + 1) * sas) - chip->ecc.bytes;
oobregion->length = chip->ecc.bytes;
return 0;
--
1.9.0.138.g2de3478
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand
2019-05-01 19:22 [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand Kamal Dasu
@ 2019-05-02 2:29 ` Florian Fainelli
2019-06-03 8:05 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-05-02 2:29 UTC (permalink / raw)
To: Kamal Dasu, linux-mtd
Cc: bcm-kernel-feedback-list, linux-kernel, Brian Norris,
Boris Brezillon, Miquel Raynal, Richard Weinberger,
David Woodhouse, Marek Vasut
On 5/1/2019 12:22 PM, Kamal Dasu wrote:
> The oobregion->offset for large page nand parts was wrong, change
> fixes this error in calculation.
>
> Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand
2019-05-01 19:22 [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand Kamal Dasu
2019-05-02 2:29 ` Florian Fainelli
@ 2019-06-03 8:05 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2019-06-03 8:05 UTC (permalink / raw)
To: Kamal Dasu, linux-mtd
Cc: Miquel Raynal, Boris Brezillon, Richard Weinberger, linux-kernel,
Marek Vasut, bcm-kernel-feedback-list, Brian Norris,
David Woodhouse
On Wed, 2019-05-01 at 19:22:14 UTC, Kamal Dasu wrote:
> The oobregion->offset for large page nand parts was wrong, change
> fixes this error in calculation.
>
> Fixes: ef5eeea6e911 ("mtd: nand: brcm: switch to mtd_ooblayout_ops")
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-03 8:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-01 19:22 [PATCH v2] mtd: rawnand: brcmnand: fix bch ecc layout for large page nand Kamal Dasu
2019-05-02 2:29 ` Florian Fainelli
2019-06-03 8:05 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).