From: Lukasz Luba <l.luba@partner.samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org
Cc: tjakobi@math.uni-bielefeld.de, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, rjw@rjwysocki.net,
len.brown@intel.com, pavel@ucw.cz, gregkh@linuxfoundation.org,
keescook@chromium.org, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com, robh+dt@kernel.org, mark.rutland@arm.com,
kgene@kernel.org, krzk@kernel.org, m.szyprowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH v2 3/5] devfreq: add devfreq_suspend/resume() functions
Date: Tue, 4 Dec 2018 10:44:46 +0100 [thread overview]
Message-ID: <bb7c2fd1-69e2-fdc6-ecb9-83ee22c2601e@partner.samsung.com> (raw)
In-Reply-To: <5C061C74.808@samsung.com>
Hi Chanwoo,
On 12/4/18 7:19 AM, Chanwoo Choi wrote:
> Hi Lukasz,
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
>> This patch adds implementation for global suspend/resume for
>> devfreq framework. System suspend will next use these functions.
>>
>> The patch is based on earlier work by Tobias Jakobi.
>
> Please remove it from each patch description.
OK
>
>>
>> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> Suggested-by: Chanwoo Choi <cw00.choi@samsung.com>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>> drivers/devfreq/devfreq.c | 42 ++++++++++++++++++++++++++++++++++++++++++
>> include/linux/devfreq.h | 6 ++++++
>> 2 files changed, 48 insertions(+)
>>
>> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
>> index 36bed24..7d60423 100644
>> --- a/drivers/devfreq/devfreq.c
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -935,6 +935,48 @@ int devfreq_resume_device(struct devfreq *devfreq)
>> EXPORT_SYMBOL(devfreq_resume_device);
>>
>> /**
>> + * devfreq_suspend() - Suspend devfreq governors and devices
>> + *
>> + * Called during system wide Suspend/Hibernate cycles for suspending governors
>> + * and devices preserving the state for resume. On some platforms the devfreq
>> + * device must have precise state (frequency) after resume in order to provide
>> + * fully operating setup.
>> + */
>> +void devfreq_suspend(void)
>> +{
>> + struct devfreq *devfreq;
>> + int ret;
>> +
>> + mutex_lock(&devfreq_list_lock);
>> + list_for_each_entry(devfreq, &devfreq_list, node) {
>> + ret = devfreq_suspend_device(devfreq);
>> + if (ret)
>> + dev_warn(&devfreq->dev, "device suspend failed\n");
>
> When I checked the cpufreq_suspend(), cpufreq_suspend() prints message as 'err' level.
> I think that dev_err is more proper than dev_warn.
>
> I'm not sure what is more correct log.
> But, 'devfreq->dev' device has the separate suspend/resume function.
> So, I think that devfreq_suspend() should print error log containing
> that it is error by devfreq framework.
>
> "device suspend failed"
> -> "failed to suspend devfreq device"
OK, changed in next v3 patch set.
>
>> + }
>> + mutex_unlock(&devfreq_list_lock);
>> +}
>> +
>> +/**
>> + * devfreq_resume() - Resume devfreq governors and devices
>> + *
>> + * Called during system wide Suspend/Hibernate cycle for resuming governors and
>> + * devices that are suspended with devfreq_suspend().
>> + */
>> +void devfreq_resume(void)
>> +{
>> + struct devfreq *devfreq;
>> + int ret;
>> +
>> + mutex_lock(&devfreq_list_lock);
>> + list_for_each_entry(devfreq, &devfreq_list, node) {
>> + ret = devfreq_resume_device(devfreq);
>> + if (ret)
>> + dev_warn(&devfreq->dev, "device resume failed\n");
>
> ditto.
>
> "device resume failed"
> -> "failed to resume devfreq device"
>
ACK
Regards,
Lukasz
>
>> + }
>> + mutex_unlock(&devfreq_list_lock);
>> +}
>> +
>> +/**
>> * devfreq_add_governor() - Add devfreq governor
>> * @governor: the devfreq governor to be added
>> */
>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
>> index d985199..fbffa74 100644
>> --- a/include/linux/devfreq.h
>> +++ b/include/linux/devfreq.h
>> @@ -205,6 +205,9 @@ extern void devm_devfreq_remove_device(struct device *dev,
>> extern int devfreq_suspend_device(struct devfreq *devfreq);
>> extern int devfreq_resume_device(struct devfreq *devfreq);
>>
>> +extern void devfreq_suspend(void);
>> +extern void devfreq_resume(void);
>> +
>> /**
>> * update_devfreq() - Reevaluate the device and configure frequency
>> * @devfreq: the devfreq device
>> @@ -331,6 +334,9 @@ static inline int devfreq_resume_device(struct devfreq *devfreq)
>> return 0;
>> }
>>
>> +static inline void devfreq_suspend(void) {}
>> +static inline void devfreq_resume(void) {}
>> +
>> static inline struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
>> unsigned long *freq, u32 flags)
>> {
>>
>
next prev parent reply other threads:[~2018-12-04 9:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181203143127eucas1p2604fc066139a32fdffe996212b42b40e@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 0/5] devfreq: handle suspend/resume Lukasz Luba
[not found] ` <CGME20181203143129eucas1p2955b6becc60ee57110cbc52f6e4f60c5@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 1/5] devfreq: refactor set_target frequency function Lukasz Luba
2018-12-04 4:39 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 9:36 ` Lukasz Luba
[not found] ` <CGME20181203143131eucas1p217f22ac6d19682a54a57658a06980914@eucas1p2.samsung.com>
2018-12-03 14:31 ` [PATCH v2 2/5] devfreq: add support for suspend/resume of a devfreq device Lukasz Luba
2018-12-04 5:36 ` Chanwoo Choi
2018-12-04 5:43 ` Chanwoo Choi
2018-12-04 6:10 ` Chanwoo Choi
2018-12-04 9:53 ` Lukasz Luba
2018-12-05 0:09 ` Chanwoo Choi
2018-12-05 11:07 ` Lukasz Luba
2018-12-04 9:39 ` Lukasz Luba
2018-12-09 9:00 ` Pavel Machek
[not found] ` <CGME20181203143132eucas1p128c029a7c7461e1127924a08e4a71811@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 3/5] devfreq: add devfreq_suspend/resume() functions Lukasz Luba
2018-12-04 6:19 ` Chanwoo Choi
2018-12-04 9:44 ` Lukasz Luba [this message]
[not found] ` <CGME20181203143134eucas1p1edd70b0f4dca115f6f154555d8829427@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 4/5] drivers: power: suspend: call devfreq suspend/resume Lukasz Luba
[not found] ` <CGME20181203143135eucas1p165fe6183ae90de7906f9683cb41ff4c1@eucas1p1.samsung.com>
2018-12-03 14:31 ` [PATCH v2 5/5] arm: dts: exynos4: opp-suspend in DMC and leftbus Lukasz Luba
2018-12-03 17:22 ` Krzysztof Kozlowski
2018-12-03 17:48 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb7c2fd1-69e2-fdc6-ecb9-83ee22c2601e@partner.samsung.com \
--to=l.luba@partner.samsung.com \
--cc=anton@enomsg.org \
--cc=b.zolnierkie@samsung.com \
--cc=ccross@android.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).