* [PATCH] staging: r8188eu :os_dep: remove condition with no effect
@ 2021-08-28 9:31 Saurav Girepunje
2021-08-28 10:19 ` Michael Straube
0 siblings, 1 reply; 3+ messages in thread
From: Saurav Girepunje @ 2021-08-28 9:31 UTC (permalink / raw)
To: Larry.Finger, phil, gregkh, straube.linux, nathan, linux-kernel
Cc: saurav.girepunje
Remove the condition with no effect (if == else) in usb_intf.c
file.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
index bb85ab77fd26..849563b54727 100644
--- a/drivers/staging/r8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
@@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
int ret = 0;
- if (pwrpriv->bInternalAutoSuspend)
- ret = rtw_resume_process(padapter);
- else
- ret = rtw_resume_process(padapter);
+ ret = rtw_resume_process(padapter);
+
return ret;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect
2021-08-28 9:31 [PATCH] staging: r8188eu :os_dep: remove condition with no effect Saurav Girepunje
@ 2021-08-28 10:19 ` Michael Straube
2021-08-28 12:45 ` SAURAV GIREPUNJE
0 siblings, 1 reply; 3+ messages in thread
From: Michael Straube @ 2021-08-28 10:19 UTC (permalink / raw)
To: Saurav Girepunje, Larry.Finger, phil, gregkh, nathan, linux-kernel
Cc: saurav.girepunje
On 8/28/21 11:31, Saurav Girepunje wrote:
> Remove the condition with no effect (if == else) in usb_intf.c
> file.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> index bb85ab77fd26..849563b54727 100644
> --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> int ret = 0;
>
> - if (pwrpriv->bInternalAutoSuspend)
> - ret =
> - else
> - ret = rtw_resume_process(padapter);
> + ret = rtw_resume_process(padapter);
> +
> return ret;
> }
Thanks for your patch. Perhaps this could be further simplified to:
int ret = rtw_resume_process(padapter);
return ret;
or even:
return rtw_resume_process(padapter);
Best regards,
Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: r8188eu :os_dep: remove condition with no effect
2021-08-28 10:19 ` Michael Straube
@ 2021-08-28 12:45 ` SAURAV GIREPUNJE
0 siblings, 0 replies; 3+ messages in thread
From: SAURAV GIREPUNJE @ 2021-08-28 12:45 UTC (permalink / raw)
To: Michael Straube
Cc: Larry.Finger, phil, gregkh, nathan, linux-kernel, saurav.girepunje
On 28 Aug 2021 12:19, Michael Straube wrote:
> On 8/28/21 11:31, Saurav Girepunje wrote:
> > Remove the condition with no effect (if == else) in usb_intf.c
> > file.
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > ---
> > drivers/staging/r8188eu/os_dep/usb_intf.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > index bb85ab77fd26..849563b54727 100644
> > --- a/drivers/staging/r8188eu/os_dep/usb_intf.c
> > +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c
> > @@ -496,10 +496,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> > struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> > int ret = 0;
> >
> > - if (pwrpriv->bInternalAutoSuspend)
> > - ret = - else
> > - ret = rtw_resume_process(padapter);
> > + ret = rtw_resume_process(padapter);
> > +
> > return ret;
> > }
>
> Thanks for your patch. Perhaps this could be further simplified to:
>
> int ret = rtw_resume_process(padapter);
>
> return ret;
>
> or even:
>
> return rtw_resume_process(padapter);
>
> Best regards,
> Michael
Yes, Thanks Michael. I will make it more simple and send v2.
Regards,
Saurav
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-28 12:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-28 9:31 [PATCH] staging: r8188eu :os_dep: remove condition with no effect Saurav Girepunje
2021-08-28 10:19 ` Michael Straube
2021-08-28 12:45 ` SAURAV GIREPUNJE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).