* [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops'
@ 2021-11-29 6:33 Cai Huoqing
2021-11-29 11:13 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-11-29 6:33 UTC (permalink / raw)
To: caihuoqing
Cc: Jyri Sarha, Tomi Valkeinen, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Mark 'tidss_pm_ops' as __maybe_unused to avoid
the warning: unused variable 'tidss_pm_ops'
Fixes: 6e120594631f ("drm/tidss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
index 4366b5c798e0..7c784e90e40e 100644
--- a/drivers/gpu/drm/tidss/tidss_drv.c
+++ b/drivers/gpu/drm/tidss/tidss_drv.c
@@ -88,7 +88,7 @@ static int __maybe_unused tidss_resume(struct device *dev)
return drm_mode_config_helper_resume(&tidss->ddev);
}
-static const struct dev_pm_ops tidss_pm_ops = {
+static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
SET_RUNTIME_PM_OPS(tidss_pm_runtime_suspend, tidss_pm_runtime_resume, NULL)
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops'
2021-11-29 6:33 [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops' Cai Huoqing
@ 2021-11-29 11:13 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2021-11-29 11:13 UTC (permalink / raw)
To: Cai Huoqing
Cc: Jyri Sarha, David Airlie, Daniel Vetter, dri-devel, linux-kernel
On 29/11/2021 08:33, Cai Huoqing wrote:
> Mark 'tidss_pm_ops' as __maybe_unused to avoid
> the warning: unused variable 'tidss_pm_ops'
>
> Fixes: 6e120594631f ("drm/tidss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index 4366b5c798e0..7c784e90e40e 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -88,7 +88,7 @@ static int __maybe_unused tidss_resume(struct device *dev)
> return drm_mode_config_helper_resume(&tidss->ddev);
> }
>
> -static const struct dev_pm_ops tidss_pm_ops = {
> +static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
> SET_RUNTIME_PM_OPS(tidss_pm_runtime_suspend, tidss_pm_runtime_resume, NULL)
> };
Thanks, I'll push to drm-misc-next.
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-29 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 6:33 [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops' Cai Huoqing
2021-11-29 11:13 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).