* [PATCH] staging: wfx: fixed misspelled word in comment
@ 2020-08-04 14:58 Aditya Bansal
2020-08-04 12:47 ` [PATCH v2] " Aditya Bansal
2020-08-04 15:24 ` [PATCH] " Randy Dunlap
0 siblings, 2 replies; 7+ messages in thread
From: Aditya Bansal @ 2020-08-04 14:58 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
From: Aditya Bansal <adbansal99@gmail.com>
Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file
Correct the spelling of function
Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
---
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index 5110f9b93762..6a485fa5b72b 100644
--- a/drivers/staging/wfx/hif_tx.c
+++ b/drivers/staging/wfx/hif_tx.c
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
// This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
// request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// carefull to only call this function during device unregister.
int hif_shutdown(struct wfx_dev *wdev)
{
int ret;
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] staging: wfx: fixed misspelled word in comment
2020-08-04 14:58 [PATCH] staging: wfx: fixed misspelled word in comment Aditya Bansal
@ 2020-08-04 12:47 ` Aditya Bansal
2020-08-18 13:58 ` Greg KH
2020-08-04 15:24 ` [PATCH] " Randy Dunlap
1 sibling, 1 reply; 7+ messages in thread
From: Aditya Bansal @ 2020-08-04 12:47 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
From: Aditya Bansal <adbansal99@gmail.com>
Subject: [PATCH v2] fixed typo in driver/staging/wfx/hif_tx.c file
Correct the spelling of word function and careful
Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
---
diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
index 5110f9b93762..fc12f9dcefce 100644
--- a/drivers/staging/wfx/hif_tx.c
+++ b/drivers/staging/wfx/hif_tx.c
@@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
// This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
// request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
-// carefull to only call this funcion during device unregister.
+// careful to only call this function during device unregister.
int hif_shutdown(struct wfx_dev *wdev)
{
int ret;
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] staging: wfx: fixed misspelled word in comment
2020-08-04 12:47 ` [PATCH v2] " Aditya Bansal
@ 2020-08-18 13:58 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2020-08-18 13:58 UTC (permalink / raw)
To: Aditya Bansal; +Cc: devel, linux-kernel
On Tue, Aug 04, 2020 at 06:17:47PM +0530, Aditya Bansal wrote:
> From: Aditya Bansal <adbansal99@gmail.com>
>
> Subject: [PATCH v2] fixed typo in driver/staging/wfx/hif_tx.c file
>
> Correct the spelling of word function and careful
>
> Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
> ---
>
> diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
> index 5110f9b93762..fc12f9dcefce 100644
> --- a/drivers/staging/wfx/hif_tx.c
> +++ b/drivers/staging/wfx/hif_tx.c
> @@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
>
> // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
> // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
> -// carefull to only call this funcion during device unregister.
> +// careful to only call this function during device unregister.
> int hif_shutdown(struct wfx_dev *wdev)
> {
> int ret;
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Does not apply to my tree, can you please refresh and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: wfx: fixed misspelled word in comment
2020-08-04 14:58 [PATCH] staging: wfx: fixed misspelled word in comment Aditya Bansal
2020-08-04 12:47 ` [PATCH v2] " Aditya Bansal
@ 2020-08-04 15:24 ` Randy Dunlap
2020-08-04 15:43 ` Joe Perches
1 sibling, 1 reply; 7+ messages in thread
From: Randy Dunlap @ 2020-08-04 15:24 UTC (permalink / raw)
To: Aditya Bansal, gregkh; +Cc: devel, linux-kernel
On 8/4/20 7:58 AM, Aditya Bansal wrote:
> From: Aditya Bansal <adbansal99@gmail.com>
>
> Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file
>
> Correct the spelling of function
>
> Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
> ---
>
> diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
> index 5110f9b93762..6a485fa5b72b 100644
> --- a/drivers/staging/wfx/hif_tx.c
> +++ b/drivers/staging/wfx/hif_tx.c
> @@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
>
> // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
> // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
> -// carefull to only call this funcion during device unregister.
> +// carefull to only call this function during device unregister.
careful
> int hif_shutdown(struct wfx_dev *wdev)
> {
> int ret;
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] staging: wfx: fixed misspelled word in comment
2020-08-04 15:24 ` [PATCH] " Randy Dunlap
@ 2020-08-04 15:43 ` Joe Perches
2020-08-04 10:37 ` Aditya Bansal
0 siblings, 1 reply; 7+ messages in thread
From: Joe Perches @ 2020-08-04 15:43 UTC (permalink / raw)
To: Randy Dunlap, Aditya Bansal, gregkh; +Cc: devel, linux-kernel
On Tue, 2020-08-04 at 08:24 -0700, Randy Dunlap wrote:
> On 8/4/20 7:58 AM, Aditya Bansal wrote:
> > From: Aditya Bansal <adbansal99@gmail.com>
> >
> > Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file
> >
> > Correct the spelling of function
> >
> > Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
> > ---
> >
> > diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
> > index 5110f9b93762..6a485fa5b72b 100644
> > --- a/drivers/staging/wfx/hif_tx.c
> > +++ b/drivers/staging/wfx/hif_tx.c
> > @@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
> >
> > // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
> > // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
> > -// carefull to only call this funcion during device unregister.
> > +// carefull to only call this function during device unregister.
>
> careful
And if you could do all of them:
$ git grep -w -i -n carefull
arch/m68k/coldfire/pci.c:34: * We need to be carefull probing on bus 0 (directly connected to host
arch/openrisc/kernel/head.S:289: * a bit more carefull (if we have a PT_SP or current pointer
drivers/staging/wfx/debug.c:302: // Be carefull, write() is waiting for a full message while read()
drivers/staging/wfx/hif_tx.c:128:// carefull to only call this funcion during device unregister.
fs/ceph/inode.c:1475: /* parent inode is not locked, be carefull */
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: wfx: fixed misspelled word in comment
2020-08-04 15:43 ` Joe Perches
@ 2020-08-04 10:37 ` Aditya Bansal
2020-08-04 16:23 ` Joe Perches
0 siblings, 1 reply; 7+ messages in thread
From: Aditya Bansal @ 2020-08-04 10:37 UTC (permalink / raw)
To: Joe Perches; +Cc: Randy Dunlap, gregkh, devel, linux-kernel
Should I correct all the instances of the "careful" and submit the
patch including both "carefull" and "function" word correct? or only
for the "carefull"? I have already submitted one for the "funcion"
word.
On Tue, Aug 4, 2020 at 9:13 PM Joe Perches <joe@perches.com> wrote:
>
> On Tue, 2020-08-04 at 08:24 -0700, Randy Dunlap wrote:
> > On 8/4/20 7:58 AM, Aditya Bansal wrote:
> > > From: Aditya Bansal <adbansal99@gmail.com>
> > >
> > > Subject: [PATCH] fixed typo in driver/staging/wfx/hif_tx.c file
> > >
> > > Correct the spelling of function
> > >
> > > Signed-off-by: Aditya Bansal <adbansal99@gmail.com>
> > > ---
> > >
> > > diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c
> > > index 5110f9b93762..6a485fa5b72b 100644
> > > --- a/drivers/staging/wfx/hif_tx.c
> > > +++ b/drivers/staging/wfx/hif_tx.c
> > > @@ -125,7 +125,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct hif_msg *request,
> > >
> > > // This function is special. After HIF_REQ_ID_SHUT_DOWN, chip won't reply to any
> > > // request anymore. We need to slightly hack struct wfx_hif_cmd for that job. Be
> > > -// carefull to only call this funcion during device unregister.
> > > +// carefull to only call this function during device unregister.
> >
> > careful
>
> And if you could do all of them:
>
> $ git grep -w -i -n carefull
> arch/m68k/coldfire/pci.c:34: * We need to be carefull probing on bus 0 (directly connected to host
> arch/openrisc/kernel/head.S:289: * a bit more carefull (if we have a PT_SP or current pointer
> drivers/staging/wfx/debug.c:302: // Be carefull, write() is waiting for a full message while read()
> drivers/staging/wfx/hif_tx.c:128:// carefull to only call this funcion during device unregister.
> fs/ceph/inode.c:1475: /* parent inode is not locked, be carefull */
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: wfx: fixed misspelled word in comment
2020-08-04 10:37 ` Aditya Bansal
@ 2020-08-04 16:23 ` Joe Perches
0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2020-08-04 16:23 UTC (permalink / raw)
To: Aditya Bansal; +Cc: Randy Dunlap, gregkh, devel, linux-kernel
On Tue, 2020-08-04 at 16:07 +0530, Aditya Bansal wrote:
> Should I correct all the instances of the "careful" and submit the
> patch including both "carefull" and "function" word correct? or only
> for the "carefull"? I have already submitted one for the "funcion"
> word.
I suggest submitting a V2 patch with both fixes.
Generally it's better to submit all spelling fixes in a
single file at once, especially when multiple spelling
fixes are on the same line.
Also, it's generally better to submit separate patches
for individual files.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-18 13:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 14:58 [PATCH] staging: wfx: fixed misspelled word in comment Aditya Bansal
2020-08-04 12:47 ` [PATCH v2] " Aditya Bansal
2020-08-18 13:58 ` Greg KH
2020-08-04 15:24 ` [PATCH] " Randy Dunlap
2020-08-04 15:43 ` Joe Perches
2020-08-04 10:37 ` Aditya Bansal
2020-08-04 16:23 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).