* [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static
@ 2019-04-10 13:49 Yue Haibing
2019-04-10 16:37 ` Yonghong Song
2019-04-11 19:59 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Yue Haibing @ 2019-04-10 13:49 UTC (permalink / raw)
To: paul.burton, ralf, jhogan, ast, daniel, kafai, songliubraving, yhs
Cc: linux-kernel, linux-mips, netdev, bpf, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warning:
arch/mips/net/ebpf_jit.c:196:5: warning:
symbol 'ebpf_to_mips_reg' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/mips/net/ebpf_jit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/net/ebpf_jit.c b/arch/mips/net/ebpf_jit.c
index 3548a69..dfd5a4b 100644
--- a/arch/mips/net/ebpf_jit.c
+++ b/arch/mips/net/ebpf_jit.c
@@ -193,8 +193,9 @@ enum which_ebpf_reg {
* separate frame pointer, so BPF_REG_10 relative accesses are
* adjusted to be $sp relative.
*/
-int ebpf_to_mips_reg(struct jit_ctx *ctx, const struct bpf_insn *insn,
- enum which_ebpf_reg w)
+static int ebpf_to_mips_reg(struct jit_ctx *ctx,
+ const struct bpf_insn *insn,
+ enum which_ebpf_reg w)
{
int ebpf_reg = (w == src_reg || w == src_reg_no_fp) ?
insn->src_reg : insn->dst_reg;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static
2019-04-10 13:49 [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static Yue Haibing
@ 2019-04-10 16:37 ` Yonghong Song
2019-04-11 19:59 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2019-04-10 16:37 UTC (permalink / raw)
To: Yue Haibing, paul.burton, ralf, jhogan, ast, daniel, Martin Lau,
Song Liu
Cc: linux-kernel, linux-mips, netdev, bpf
On 4/10/19 6:49 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> arch/mips/net/ebpf_jit.c:196:5: warning:
> symbol 'ebpf_to_mips_reg' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static
2019-04-10 13:49 [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static Yue Haibing
2019-04-10 16:37 ` Yonghong Song
@ 2019-04-11 19:59 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2019-04-11 19:59 UTC (permalink / raw)
To: Yue Haibing, paul.burton, ralf, jhogan, ast, kafai, songliubraving, yhs
Cc: linux-kernel, linux-mips, netdev, bpf
On 04/10/2019 03:49 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> arch/mips/net/ebpf_jit.c:196:5: warning:
> symbol 'ebpf_to_mips_reg' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-11 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 13:49 [PATCH] MIPS: eBPF: Make ebpf_to_mips_reg() static Yue Haibing
2019-04-10 16:37 ` Yonghong Song
2019-04-11 19:59 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).