linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Stephen Boyd <swboyd@chromium.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Show correct direction from the beginning
Date: Thu, 20 Sep 2018 07:35:52 -0500	[thread overview]
Message-ID: <bcb79947-dfe0-e5e2-fb48-3b6992720f01@kernel.org> (raw)
In-Reply-To: <CACRpkdYGpEVG9gqPxNaOsD55k9idEfGaxOUrObbN9VZS06x5jw@mail.gmail.com>

On 9/20/18 12:23 AM, Linus Walleij wrote:
> I think most gpiochips easily survives calling the .get_direction()
> early, Qualcomm's stand out here.
> 
> Now that we have .valid_mask in the gpiochip could we simply just
> add this back, resepecting valid_mask and avoid checking the
> direction of precisely these GPIOs?

Can you be more specific?  One of the proposals made previously was to 
add a check in msm_gpio_get_direction(), but that was rejected because 
the consensus was the valid_mask checks in gpiolib are sufficient.


  reply	other threads:[~2018-09-20 12:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14  7:08 [RFC] gpiolib: Fix gpio_direction_* for single direction GPIOs Ricardo Ribalda Delgado
2018-09-14  7:08 ` [PATCH] gpiolib: Show correct direction from the beginning Ricardo Ribalda Delgado
2018-09-18 22:40   ` Linus Walleij
2018-09-19  4:04     ` Ricardo Ribalda Delgado
2018-09-19 11:50       ` Timur Tabi
2018-09-19 15:27         ` Ricardo Ribalda Delgado
2018-09-20 12:20           ` Timur Tabi
2018-09-20 14:14             ` Ricardo Ribalda Delgado
2018-09-20 22:43               ` Linus Walleij
2018-09-20 12:25           ` Timur Tabi
2018-09-20  5:23         ` Linus Walleij
2018-09-20 12:35           ` Timur Tabi [this message]
2018-09-20 22:36             ` Linus Walleij
2018-09-21  2:05               ` Timur Tabi
2018-09-21 16:07                 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcb79947-dfe0-e5e2-fb48-3b6992720f01@kernel.org \
    --to=timur@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).